client_{id,_secret} are no longer passed as query, but basic authentication only
#41
+162
−256
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…t basic authentication only
…authentication only
…authentication only
BREAKING CHANGE: `:client_id` and `:access_token` URL parameters are no longer set by default
BREAKING CHANGE: `client_id` and `client_secret` are now passed as basic authentication for any URL
BREAKING CHANGE: The `url` option has been removed for `auth({ type: "app" })`
BREAKING CHANGE: `auth({ type: "app" })` no longer returns a `.query` key
gr2m
force-pushed
the
drop-defaults-and-request-query
branch
from
f2b0fee to
e2d3977
Compare
|
🎉 This PR is included in version 3.0.0 🎉 The release is available on: Your semantic-release bot 📦🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses https://developer.github.com/changes/2020-02-10-deprecating-auth-through-query-param/