remove puka

PR-URL: #22
Credit: @nlf
Close: #22
Reviewed-by: @ruyadorno

lib/make-spawn-args.js

@@ -3,24 +3,6 @@ const isWindows = require('./is-windows.js')
 const setPATH = require('./set-path.js')
 const {resolve} = require('path')
 const npm_config_node_gyp = require.resolve('node-gyp/bin/node-gyp.js')
-const { quoteForShell, ShellString, ShellStringText, ShellStringUnquoted } = require('puka')
-
-const escapeCmd = cmd => {
-  const result = []
-  const parsed = ShellString.sh([cmd])
-  for (const child of parsed.children) {
-    if (child instanceof ShellStringText) {
-      const children = child.contents.filter(segment => segment !== null).map(segment => quoteForShell(segment, false, isWindows && 'win32'))
-      result.push(...children)
-    } else if (child instanceof ShellStringUnquoted) {
-      result.push(child.value)
-    } else {
-      result.push(isWindows ? '&' : ';')
-    }
-  }
-
-  return result.join('')
-}
 
 const makeSpawnArgs = options => {
   const {
@@ -34,7 +16,7 @@ const makeSpawnArgs = options => {
   } = options
 
   const isCmd = /(?:^|\\)cmd(?:\.exe)?$/i.test(scriptShell)
-  const args = isCmd ? ['/d', '/s', '/c', escapeCmd(cmd)] : ['-c', cmd]
+  const args = isCmd ? ['/d', '/s', '/c', cmd] : ['-c', cmd]
 
   const spawnOpts = {
     env: setPATH(path, {

package.json

@@ -32,7 +32,6 @@
     "@npmcli/promise-spawn": "^1.3.2",
     "infer-owner": "^1.0.4",
     "node-gyp": "^7.1.0",
-    "puka": "^1.0.1",
     "read-package-json-fast": "^2.0.1"
   },
   "files": [

test/make-spawn-args.js

@@ -24,7 +24,7 @@ if (isWindows) {
       cmd: 'script "quoted parameter"; second command',
     }), [
       'cmd',
-      [ '/d', '/s', '/c', `script "quoted parameter"& second command` ],
+      [ '/d', '/s', '/c', `script \"quoted parameter\"; second command` ],
       {
         env: {
           npm_package_json: /package\.json$/,
@@ -66,7 +66,7 @@ if (isWindows) {
       scriptShell: 'cmd.exe',
     }), [
       'cmd.exe',
-      [ '/d', '/s', '/c', `script "quoted parameter"& second command` ],
+      [ '/d', '/s', '/c', `script \"quoted parameter\"; second command` ],
       {
         env: {
           npm_package_json: /package\.json$/,
@@ -113,7 +113,7 @@ if (isWindows) {
       scriptShell: 'cmd.exe',
     }), [
       'cmd.exe',
-      [ '/d', '/s', '/c', `script 'quoted parameter'; second command` ],
+      [ '/d', '/s', '/c', `script \"quoted parameter\"; second command` ],
       {
         env: {
           npm_package_json: /package\.json$/,