Merge pull request #81 from npm/isaacs/include-all-dep-types-when-pre…

…paring fix: include all dep types when building for prepare
npm · Jul 2, 2021 · 7660b0b · 7660b0b
2 parents 6ad9ede + 0328fe0
commit 7660b0b
Show file tree

Hide file tree

Showing 3 changed files with 27 additions and 0 deletions.
diff --git a/lib/fetcher.js b/lib/fetcher.js
@@ -119,6 +119,13 @@ class FetcherBase {
       '--no-progress',
       '--no-save',
       '--no-audit',
+      // override any omit settings from the environment
+      '--include=dev',
+      '--include=peer',
+      '--include=optional',
+      // we need the actual things, not just the lockfile
+      '--no-package-lock-only',
+      '--no-dry-run',
     ]
   }
 

diff --git a/tap-snapshots/test/fetcher.js-fake-sudo.test.cjs b/tap-snapshots/test/fetcher.js-fake-sudo.test.cjs
@@ -43,6 +43,11 @@ Array [
   "--no-progress",
   "--no-save",
   "--no-audit",
+  "--include=dev",
+  "--include=peer",
+  "--include=optional",
+  "--no-package-lock-only",
+  "--no-dry-run",
 ]
 `
 
@@ -56,6 +61,11 @@ Array [
   "--no-progress",
   "--no-save",
   "--no-audit",
+  "--include=dev",
+  "--include=peer",
+  "--include=optional",
+  "--no-package-lock-only",
+  "--no-dry-run",
 ]
 `
 

diff --git a/tap-snapshots/test/fetcher.js.test.cjs b/tap-snapshots/test/fetcher.js.test.cjs
@@ -43,6 +43,11 @@ Array [
   "--no-progress",
   "--no-save",
   "--no-audit",
+  "--include=dev",
+  "--include=peer",
+  "--include=optional",
+  "--no-package-lock-only",
+  "--no-dry-run",
 ]
 `
 
@@ -56,6 +61,11 @@ Array [
   "--no-progress",
   "--no-save",
   "--no-audit",
+  "--include=dev",
+  "--include=peer",
+  "--include=optional",
+  "--no-package-lock-only",
+  "--no-dry-run",
 ]
 `