fix: do not do dry-run/package-lock installs for preparation

isaacs · isaacs · commit 0328fe06f666 · 2021-06-18T16:02:29.000-07:00
Fixes npm/cli#3300
diff --git a/lib/fetcher.js b/lib/fetcher.js
@@ -123,6 +123,9 @@ class FetcherBase {
       '--include=dev',
       '--include=peer',
       '--include=optional',
+      // we need the actual things, not just the lockfile
+      '--no-package-lock-only',
+      '--no-dry-run',
     ]
   }
 
diff --git a/tap-snapshots/test/fetcher.js-fake-sudo.test.cjs b/tap-snapshots/test/fetcher.js-fake-sudo.test.cjs
@@ -46,6 +46,8 @@ Array [
   "--include=dev",
   "--include=peer",
   "--include=optional",
+  "--no-package-lock-only",
+  "--no-dry-run",
 ]
 `
 
@@ -62,6 +64,8 @@ Array [
   "--include=dev",
   "--include=peer",
   "--include=optional",
+  "--no-package-lock-only",
+  "--no-dry-run",
 ]
 `
 
diff --git a/tap-snapshots/test/fetcher.js.test.cjs b/tap-snapshots/test/fetcher.js.test.cjs
@@ -46,6 +46,8 @@ Array [
   "--include=dev",
   "--include=peer",
   "--include=optional",
+  "--no-package-lock-only",
+  "--no-dry-run",
 ]
 `
 
@@ -62,6 +64,8 @@ Array [
   "--include=dev",
   "--include=peer",
   "--include=optional",
+  "--no-package-lock-only",
+  "--no-dry-run",
 ]
 `
 

Original file line number	Diff line number	Diff line change
`@@ -123,6 +123,9 @@ class FetcherBase {`
`123`	`123`	`'--include=dev',`
`124`	`124`	`'--include=peer',`
`125`	`125`	`'--include=optional',`
	`126`	`+ // we need the actual things, not just the lockfile`
	`127`	`+ '--no-package-lock-only',`
	`128`	`+ '--no-dry-run',`
`126`	`129`	`]`
`127`	`130`	`}`
`128`	`131`