fix(tarball): fix spurious errors from tarball.stream()

Author: zkat

lib/with-tarball-stream.js

@@ -103,7 +103,7 @@ function withTarballStream (spec, opts, streamHandler) {
           // Retry once if we have a cache, to clear up any weird conditions.
           // Don't retry network errors, though -- make-fetch-happen has already
           // taken care of making sure we're all set on that front.
-          if (opts.cache && !err.code.match(/^E\d{3}$/)) {
+          if (opts.cache && err.code && !err.code.match(/^E\d{3}$/)) {
             if (err.code === 'EINTEGRITY' || err.code === 'Z_DATA_ERROR') {
               opts.log.warn('tarball', `tarball data for ${spec} (${opts.integrity}) seems to be corrupted. Trying one more time.`)
             }

tarball.js

@@ -33,9 +33,9 @@ function tarballStream (spec, opts) {
       throw new Error('abort, abort!')
     } else {
       return new BB((resolve, reject) => {
+        stream.on('error', reject)
         output.on('error', reject)
         output.on('error', () => { hasTouchedOutput = true })
-        stream.on('error', err => output.emit('error', err))
         output.on('finish', resolve)
         stream.pipe(output)
         stream.once('data', () => { hasTouchedOutput = true })