Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: npm/npm-registry-fetch
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 71ab0e79d5aed213b63b75b224ad0d5f44dd0d7e
Choose a base ref
...
head repository: npm/npm-registry-fetch
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 8f61d9532ddb08c01778c3067eb77d5a07192c2f
Choose a head ref

Commits on Oct 4, 2019

  1. feat: refactor to use Minipass streams

    BREAKING CHANGE: this replaces all core streams (except for some
    PassThrough streams in a few tests) with Minipass streams, and updates
    all deps to the latest and greatest Minipass versions of things.
    isaacs committed Oct 4, 2019
    Copy the full SHA
    bb37f20 View commit details
  2. fix!: Use native Promises

    isaacs committed Oct 4, 2019
    Copy the full SHA
    e7286f7 View commit details
  3. Copy the full SHA
    5cfe30b View commit details
  4. Copy the full SHA
    e64702e View commit details
  5. Copy the full SHA
    90ac7b1 View commit details
  6. Copy the full SHA
    82abf26 View commit details
  7. Copy the full SHA
    97c1208 View commit details
  8. doc: fix badge url

    isaacs committed Oct 4, 2019
    Copy the full SHA
    39e5cfe View commit details
  9. chore: update travis config

    isaacs committed Oct 4, 2019
    Copy the full SHA
    41ff216 View commit details
  10. chore(release): 5.0.0

    isaacs committed Oct 4, 2019
    Copy the full SHA
    786f092 View commit details

Commits on Nov 11, 2019

  1. deps: npm-package-arg@7

    isaacs committed Nov 11, 2019
    Copy the full SHA
    5764c15 View commit details
  2. deps: update all deps

    isaacs committed Nov 11, 2019
    Copy the full SHA
    7aa14fd View commit details
  3. chore(release): 5.0.1

    isaacs committed Nov 11, 2019
    Copy the full SHA
    622afb4 View commit details

Commits on Dec 17, 2019

  1. chore: normalize settings, drop old nodes, update deps

    BREAKING CHANGE: This drops support for node < 10.
    
    There are some lint failures due to standard pushing for using WhatWG URL
    objects instead of url.parse/url.resolve.  However, the code in this lib
    does some fancy things with the query/search portions of the parsed url
    object, so it'll take a bit of care to make it work properly.
    isaacs committed Dec 17, 2019
    Copy the full SHA
    510b125 View commit details
  2. fix: Use WhatWG URLs instead of url.parse

    The better to make standard happy.
    isaacs committed Dec 17, 2019
    Copy the full SHA
    8ccfa8a View commit details
  3. chore: bump ssri to v7

    isaacs committed Dec 17, 2019
    Copy the full SHA
    62f81a2 View commit details
  4. Copy the full SHA
    e18ed22 View commit details
  5. Copy the full SHA
    3de1695 View commit details
  6. Copy the full SHA
    5813da6 View commit details
  7. chore: make-fetch-happen 7.1.0

    PR-URL: #16
    Credit: @isaacs
    Close: #16
    Reviewed-by: @isaacs
    isaacs committed Dec 17, 2019
    Copy the full SHA
    8c6622f View commit details
  8. chore(release): 6.0.0

    isaacs committed Dec 17, 2019
    Copy the full SHA
    d370dba View commit details
  9. chore: cleanup, force 100% test cov

    ruyadorno authored and isaacs committed Dec 17, 2019
    Copy the full SHA
    280ad2f View commit details
  10. Added missing ci tests

    PR-URL: #15
    Credit: @ruyadorno
    Close: #15
    Reviewed-by: @isaacs
    ruyadorno authored and isaacs committed Dec 17, 2019
    Copy the full SHA
    42f998a View commit details

Commits on Feb 13, 2020

  1. fix: use 30s default for timeout as per README

    PR-URL: #20
    Credit: @h4l
    Close: #20
    Reviewed-by: @isaacs
    h4l authored and isaacs committed Feb 13, 2020
    Copy the full SHA
    50e8afc View commit details

Commits on Feb 14, 2020

  1. chore(release): 6.0.1

    isaacs committed Feb 14, 2020
    Copy the full SHA
    55d602e View commit details
  2. fix: always bypass cache when ?write=true

    The npm CLI makes GET requests with ?write=true in some cases where it's
    intending to send an immediate PUT or DELETE.  Always bypass the cache
    for such requests, mirroring the behavior of the registry caching
    mechanisms.
    isaacs committed Feb 14, 2020
    Copy the full SHA
    83f89f3 View commit details
  3. Copy the full SHA
    450447f View commit details
  4. chore(doc): document the effect of ?write=true on caching

    PR-URL: #18
    Credit: @isaacs
    Close: #18
    Reviewed-by: @isaacs
    isaacs committed Feb 14, 2020
    Copy the full SHA
    1770f1b View commit details
  5. chore(release): 6.0.2

    isaacs committed Feb 14, 2020
    Copy the full SHA
    ae7e994 View commit details

Commits on Feb 17, 2020

  1. fix: Remove figgy-pudding, use canonical option names

    BREAKING CHANGE: this removes figgy-pudding, and drops several option
    aliases.
    
    Defaults and behavior are all the same, and this module is now using the
    canonical camelCase option names that npm v7 will provide to all its
    deps.
    
    Related to: npm/rfcs#102
    
    PR-URL: #22
    Credit: @isaacs
    Close: #22
    Reviewed-by: @claudiahdz
    isaacs committed Feb 17, 2020
    Copy the full SHA
    ede3c08 View commit details

Commits on Feb 18, 2020

  1. chore: remove extraneous semver dep

    Fix #17
    isaacs committed Feb 18, 2020
    Copy the full SHA
    6bccc1a View commit details
  2. chore: remove extraneous safe-buffer dep

    Node <v4.5 hasn't been supported for quite a while now.
    isaacs committed Feb 18, 2020
    Copy the full SHA
    152e666 View commit details
  3. chore: update cacache, ssri, make-fetch-happen

    BREAKING CHANGE: figgy pudding is now nowhere to be found.
    isaacs committed Feb 18, 2020
    Copy the full SHA
    57fcc88 View commit details
  4. chore: ignore coverage folder

    isaacs committed Feb 18, 2020
    Copy the full SHA
    5d78c78 View commit details
  5. chore(release): 7.0.0

    isaacs committed Feb 18, 2020
    Copy the full SHA
    68a2570 View commit details

Commits on Feb 24, 2020

  1. chore: make-fetch-happen@8.0.2

    isaacs committed Feb 24, 2020
    Copy the full SHA
    b1f4097 View commit details
  2. chore(release): 7.0.1

    isaacs committed Feb 24, 2020
    Copy the full SHA
    3186645 View commit details
  3. fix: remove referer header and opts.refer

    Re: npm/cli#930
    
    BREAKING CHANGE: Removes the 'opts.refer' option and the HTTP Referer
    header (unless explicitly added to the 'headers' option, of course).
    
    PR-URL: #25
    Credit: @isaacs
    Close: #25
    Reviewed-by: @mikemimik
    isaacs committed Feb 24, 2020
    Copy the full SHA
    eb8f7af View commit details
  4. chore(release): 8.0.0

    isaacs committed Feb 24, 2020
    Copy the full SHA
    ebddbe7 View commit details

Commits on Apr 28, 2020

  1. Increase default timeout value from 30s to 5m

    Re: #26
    Re: npm/cli#1151
    
    The previous default of 30s was too small for lots of users, causing
    problems when they attempt to download large objects from the npm
    registry.
    
    Bump up the default timeout to 5m.
    
    TODO: add a `--fetch-timeout` option on the CLI to explicitly set
    `timeout` in the npm.flatOptions object passed to all dependencies.
    
    PR-URL: #28
    Credit: @isaacs
    Close: #28
    Reviewed-by: @isaacs
    isaacs committed Apr 28, 2020
    Copy the full SHA
    fa211ab View commit details
  2. update deps to fix audit

    isaacs committed Apr 28, 2020
    Copy the full SHA
    ad328dc View commit details
  3. 8.0.1

    isaacs committed Apr 28, 2020
    Copy the full SHA
    aa164de View commit details

Commits on May 4, 2020

  1. fix: update make-fetch-happen to 8.0.6

    Workaround for #23
    isaacs committed May 4, 2020
    Copy the full SHA
    226df2c View commit details
  2. chore(release): 8.0.2

    isaacs committed May 4, 2020
    Copy the full SHA
    8196169 View commit details

Commits on May 13, 2020

  1. fix: update minipass and make-fetch-happen to latest

    Root cause found!
    
    Fix #23
    isaacs committed May 13, 2020
    Copy the full SHA
    3b6c5d0 View commit details
  2. chore(release): 8.0.3

    isaacs committed May 13, 2020
    Copy the full SHA
    022c909 View commit details

Commits on May 20, 2020

  1. Copy the full SHA
    1bb4eb2 View commit details
  2. chore(release): 8.1.0

    isaacs committed May 20, 2020
    Copy the full SHA
    09e540b View commit details

Commits on Jun 30, 2020

  1. chore: remove auth data from logs (#29)

    Claudia Hernández authored Jun 30, 2020
    Copy the full SHA
    18bf9b9 View commit details
  2. chore(release): 8.1.1

    claudiahdz committed Jun 30, 2020
    Copy the full SHA
    6cfc3c3 View commit details
10 changes: 10 additions & 0 deletions .commitlintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
/* This file is automatically added by @npmcli/template-oss. Do not edit. */

module.exports = {
extends: ['@commitlint/config-conventional'],
rules: {
'type-enum': [2, 'always', ['feat', 'fix', 'docs', 'deps', 'chore']],
'header-max-length': [2, 'always', 80],
'subject-case': [0, 'always', ['lower-case', 'sentence-case', 'start-case']],
},
}
17 changes: 17 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
/* This file is automatically added by @npmcli/template-oss. Do not edit. */

'use strict'

const { readdirSync: readdir } = require('fs')

const localConfigs = readdir(__dirname)
.filter((file) => file.startsWith('.eslintrc.local.'))
.map((file) => `./${file}`)

module.exports = {
root: true,
extends: [
'@npmcli',
...localConfigs,
],
}
3 changes: 3 additions & 0 deletions .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# This file is automatically added by @npmcli/template-oss. Do not edit.

* @npm/cli-team
54 changes: 54 additions & 0 deletions .github/ISSUE_TEMPLATE/bug.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,54 @@
# This file is automatically added by @npmcli/template-oss. Do not edit.

name: Bug
description: File a bug/issue
title: "[BUG] <title>"
labels: [ Bug, Needs Triage ]

body:
- type: checkboxes
attributes:
label: Is there an existing issue for this?
description: Please [search here](./issues) to see if an issue already exists for your problem.
options:
- label: I have searched the existing issues
required: true
- type: textarea
attributes:
label: Current Behavior
description: A clear & concise description of what you're experiencing.
validations:
required: false
- type: textarea
attributes:
label: Expected Behavior
description: A clear & concise description of what you expected to happen.
validations:
required: false
- type: textarea
attributes:
label: Steps To Reproduce
description: Steps to reproduce the behavior.
value: |
1. In this environment...
2. With this config...
3. Run '...'
4. See error...
validations:
required: false
- type: textarea
attributes:
label: Environment
description: |
examples:
- **npm**: 7.6.3
- **Node**: 13.14.0
- **OS**: Ubuntu 20.04
- **platform**: Macbook Pro
value: |
- npm:
- Node:
- OS:
- platform:
validations:
required: false
3 changes: 3 additions & 0 deletions .github/ISSUE_TEMPLATE/config.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,3 @@
# This file is automatically added by @npmcli/template-oss. Do not edit.

blank_issues_enabled: true
17 changes: 17 additions & 0 deletions .github/dependabot.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
# This file is automatically added by @npmcli/template-oss. Do not edit.

version: 2

updates:
- package-ecosystem: npm
directory: /
schedule:
interval: daily
allow:
- dependency-type: direct
versioning-strategy: increase-if-necessary
commit-message:
prefix: deps
prefix-development: chore
labels:
- "Dependencies"
32 changes: 32 additions & 0 deletions .github/matchers/tap.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
{
"//@npmcli/template-oss": "This file is automatically added by @npmcli/template-oss. Do not edit.",
"problemMatcher": [
{
"owner": "tap",
"pattern": [
{
"regexp": "^\\s*not ok \\d+ - (.*)",
"message": 1
},
{
"regexp": "^\\s*---"
},
{
"regexp": "^\\s*at:"
},
{
"regexp": "^\\s*line:\\s*(\\d+)",
"line": 1
},
{
"regexp": "^\\s*column:\\s*(\\d+)",
"column": 1
},
{
"regexp": "^\\s*file:\\s*(.*)",
"file": 1
}
]
}
]
}
2 changes: 2 additions & 0 deletions .github/settings.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
---
_extends: '.github:npm-cli/settings.yml'
37 changes: 37 additions & 0 deletions .github/workflows/audit.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
# This file is automatically added by @npmcli/template-oss. Do not edit.

name: Audit

on:
workflow_dispatch:
schedule:
# "At 08:00 UTC (01:00 PT) on Monday" https://crontab.guru/#0_8_*_*_1
- cron: "0 8 * * 1"

jobs:
audit:
name: Audit Dependencies
if: github.repository_owner == 'npm'
runs-on: ubuntu-latest
defaults:
run:
shell: bash
steps:
- name: Checkout
uses: actions/checkout@v3
- name: Setup Git User
run: |
git config --global user.email "npm-cli+bot@github.com"
git config --global user.name "npm CLI robot"
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: 18.x
- name: Install npm@latest
run: npm i --prefer-online --no-fund --no-audit -g npm@latest
- name: npm Version
run: npm -v
- name: Install Dependencies
run: npm i --ignore-scripts --no-audit --no-fund --package-lock
- name: Run Audit
run: npm audit
154 changes: 154 additions & 0 deletions .github/workflows/ci-release.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,154 @@
# This file is automatically added by @npmcli/template-oss. Do not edit.

name: CI - Release

on:
workflow_call:
inputs:
ref:
required: true
type: string
check-sha:
required: true
type: string

jobs:
lint-all:
name: Lint All
if: github.repository_owner == 'npm'
runs-on: ubuntu-latest
defaults:
run:
shell: bash
steps:
- name: Create Check
uses: LouisBrunner/checks-action@v1.3.1
id: check

with:
token: ${{ secrets.GITHUB_TOKEN }}
status: in_progress
name: Lint All
sha: ${{ inputs.check-sha }}
# XXX: this does not work when using the default GITHUB_TOKEN.
# Instead we post the main job url to the PR as a comment which
# will link to all the other checks. To work around this we would
# need to create a GitHub that would create on-demand tokens.
# https://github.com/LouisBrunner/checks-action/issues/18
# details_url:
- name: Checkout
uses: actions/checkout@v3
with:
ref: ${{ inputs.ref }}
- name: Setup Git User
run: |
git config --global user.email "npm-cli+bot@github.com"
git config --global user.name "npm CLI robot"
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: 18.x
- name: Install npm@latest
run: npm i --prefer-online --no-fund --no-audit -g npm@latest
- name: npm Version
run: npm -v
- name: Install Dependencies
run: npm i --ignore-scripts --no-audit --no-fund
- name: Lint
run: npm run lint --ignore-scripts
- name: Post Lint
run: npm run postlint --ignore-scripts
- name: Conclude Check
uses: LouisBrunner/checks-action@v1.3.1
if: always()
with:
token: ${{ secrets.GITHUB_TOKEN }}
conclusion: ${{ job.status }}
check_id: ${{ steps.check.outputs.check_id }}

test-all:
name: Test All - ${{ matrix.platform.name }} - ${{ matrix.node-version }}
if: github.repository_owner == 'npm'
strategy:
fail-fast: false
matrix:
platform:
- name: Linux
os: ubuntu-latest
shell: bash
- name: macOS
os: macos-latest
shell: bash
- name: Windows
os: windows-latest
shell: cmd
node-version:
- 14.17.0
- 14.x
- 16.13.0
- 16.x
- 18.0.0
- 18.x
runs-on: ${{ matrix.platform.os }}
defaults:
run:
shell: ${{ matrix.platform.shell }}
steps:
- name: Create Check
uses: LouisBrunner/checks-action@v1.3.1
id: check

with:
token: ${{ secrets.GITHUB_TOKEN }}
status: in_progress
name: Test All - ${{ matrix.platform.name }} - ${{ matrix.node-version }}
sha: ${{ inputs.check-sha }}
# XXX: this does not work when using the default GITHUB_TOKEN.
# Instead we post the main job url to the PR as a comment which
# will link to all the other checks. To work around this we would
# need to create a GitHub that would create on-demand tokens.
# https://github.com/LouisBrunner/checks-action/issues/18
# details_url:
- name: Checkout
uses: actions/checkout@v3
with:
ref: ${{ inputs.ref }}
- name: Setup Git User
run: |
git config --global user.email "npm-cli+bot@github.com"
git config --global user.name "npm CLI robot"
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: ${{ matrix.node-version }}
- name: Update Windows npm
# node 12 and 14 ship with npm@6, which is known to fail when updating itself in windows
if: matrix.platform.os == 'windows-latest' && (startsWith(matrix.node-version, '12.') || startsWith(matrix.node-version, '14.'))
run: |
curl -sO https://registry.npmjs.org/npm/-/npm-7.5.4.tgz
tar xf npm-7.5.4.tgz
cd package
node lib/npm.js install --no-fund --no-audit -g ..\npm-7.5.4.tgz
cd ..
rmdir /s /q package
- name: Install npm@7
if: startsWith(matrix.node-version, '10.')
run: npm i --prefer-online --no-fund --no-audit -g npm@7
- name: Install npm@latest
if: ${{ !startsWith(matrix.node-version, '10.') }}
run: npm i --prefer-online --no-fund --no-audit -g npm@latest
- name: npm Version
run: npm -v
- name: Install Dependencies
run: npm i --ignore-scripts --no-audit --no-fund
- name: Add Problem Matcher
run: echo "::add-matcher::.github/matchers/tap.json"
- name: Test
run: npm test --ignore-scripts
- name: Conclude Check
uses: LouisBrunner/checks-action@v1.3.1
if: always()
with:
token: ${{ secrets.GITHUB_TOKEN }}
conclusion: ${{ job.status }}
check_id: ${{ steps.check.outputs.check_id }}
Loading