Stop defaulting git-branch, return null when unset (#26)

BREAKING CHANGE: branch now defaults to `null` instead of `'master'`

Author: iarna

npa.js

@@ -140,10 +140,8 @@ function setGitCommittish (res, committish) {
   if (committish != null && committish.length >= 7 && committish.slice(0, 7) === 'semver:') {
     res.gitRange = decodeURIComponent(committish.slice(7))
     res.gitCommittish = null
-  } else if (committish == null || committish === '') {
-    res.gitCommittish = 'master'
   } else {
-    res.gitCommittish = committish
+    res.gitCommittish = committish === '' ? null : committish
   }
   return res
 }
@@ -213,7 +211,7 @@ function matchGitScp (spec) {
   const matched = spec.match(/^git\+ssh:\/\/([^:#]+:[^#]+(?:\.git)?)(?:#(.*))?$/i)
   return matched && !matched[1].match(/:[0-9]+\/?.*$/i) && {
     fetchSpec: matched[1],
-    gitCommittish: matched[2] || 'master'
+    gitCommittish: matched[2] == null ? null : matched[2]
   }
 }
 

test/basic.js

@@ -104,7 +104,7 @@ require('tap').test('basic', function (t) {
       type: 'git',
       saveSpec: 'git+ssh://git@notgithub.com/user/foo',
       fetchSpec: 'ssh://git@notgithub.com/user/foo',
-      gitCommittish: 'master',
+      gitCommittish: null,
       raw: 'git+ssh://git@notgithub.com/user/foo'
     },
 
@@ -114,7 +114,7 @@ require('tap').test('basic', function (t) {
       type: 'git',
       saveSpec: 'git+ssh://git@notgithub.com:user/foo',
       fetchSpec: 'git@notgithub.com:user/foo',
-      gitCommittish: 'master',
+      gitCommittish: null,
       raw: 'git+ssh://git@notgithub.com:user/foo'
     },
 
@@ -124,7 +124,7 @@ require('tap').test('basic', function (t) {
       type: 'git',
       saveSpec: 'git+ssh://mydomain.com:foo',
       fetchSpec: 'mydomain.com:foo',
-      gitCommittish: 'master',
+      gitCommittish: null,
       raw: 'git+ssh://mydomain.com:foo'
     },
 
@@ -184,7 +184,7 @@ require('tap').test('basic', function (t) {
       type: 'git',
       saveSpec: 'git+ssh://mydomain.com:1234/hey',
       fetchSpec: 'ssh://mydomain.com:1234/hey',
-      gitCommittish: 'master',
+      gitCommittish: null,
       raw: 'git+ssh://mydomain.com:1234/hey'
     },