Permalink
Comparing changes
Choose two branches to see what’s changed or to start a new pull request.
If you need to, you can also or
learn more about diff comparisons.
Open a pull request
Create a new pull request by comparing changes across two branches. If you need to, you can also .
Learn more about diff comparisons here.
...
5
contributors
Commits on Sep 13, 2019
-
-
This is going to be used to avoid harmful race conditions in parallel extraction operations. For example, a Link to a/b requires that the File at a/b is present. But, if they are run in parallel, then the File might not be written before the Link tries to create, and it'll fail with ENOENT. This gets worse if there's a Directory at a/b/c that unlinks the File so that it can create a dir.
-
Address unpack race conditions using path reservations
This addresses a race condition where one archive entry depends on an earlier archive entry completing its unpack operation. For example, a File entry followed by a Link to that file would fail if the File was not written before the link() call was attempted, raising an ENOENT. Or, a File entry at a/b could be clobbered mid-write by an entry at a/b/c. This was never a problem for npm packages, because those tarballs are created as a point-in-time snapshot of the package file tree. Indeed, even in the generic case, it's a bit of an edge case. However, this race condition led to some flaky tests, and could certainly be a problem in general tar archive usage, especially if someone were to use tar.update() often to append entries to an archive.
-
Change large-numbers errors from TypeError to Error
They're not technically TypeErrors, because the argument is of the correct _type_, just out of the acceptable range.
-
This adds error codes to all of the warnings emitted by tar operations, tests for several error conditions, and handling for errors raised by close(2). BREAKING CHANGES: - The `warn` event now emits with 3 arguments (code, message, data) rather than 2 (message, data). - The `data` argument to the warn event handler is always an object, (either an Error or a plain old JavaScript object) rather than sometimes being a string or undefined. - Failures from `fs.close()` are tracked and emitted.
-
Commits on Sep 17, 2019
-
do not treat ignored entries as an invalid archive
They're valid tar, just not tar we care about.
-
unpack test: move warning count assertion below content
So I can see what the warnings are in --bail mode when they fail.
-
unpack: keep path reservations longer
This avoids races when entries are zero-length, and emit end() before the fs object is fully finished and closed.
-
Commits on Sep 25, 2019
-
-
-
-
-
-
Typically we don't do merge commits on this library, but in this case, some bugfix patches were already landed on v4, which aren't relevant or necessary on the v5 codebase, prior to v5 being released. A merge commit is the cleanest way to do this without having to roll back the publish or break the continuity of the default branch.
Commits on Sep 26, 2019
-
unpack: conditionally use a file mapping to write files
Use a file mapping to write files up to 512KB. The limit where using a file mapping stops being an advantage varies from machine to machine. 512KB is a reasonable value to use here, close to the lower bound, to avoid tar becoming slower in some machines. PR-URL: #230 Credit: @joaocgreis Close: #230 Reviewed-by: @isaacs
-
-
get-write-flag: don't test invariants
If we're not on windows, or don't have fmap support, then just make this be a function that always returns 'w'. If it is windows, and has fmap support, only test the size.
-
Adds support for Brotli, which we don't use, but also removes a lot of extraneous range-checking code.
Commits on Oct 5, 2019
-
Set more portable 'mode' value in portable mode
Fix #235 The `mode` value in `portable` mode will be set to a reasonable default across Unix systems. First, the user must always have read and write permissions. (Ie, a mode of 0o044 becomes 0o644.) Next, the mode is masked against 0o022. (Ie, a file of 0o777 becomes 0o755. 0o666 becomes 0o644.) In practice, this means that all entries will usually have a mode of either 0644 or 0o755, depending on whether the executable bit was set. This avoids a situation where an archive created on a system with a umask of 0o2 creates an archive with files having modes 0o775 and 0o664, whereas an archive created on a system with a umask of 0o22 creates an archive with files having modes 0o755 and 0o644, for the same content. (Especially, for a check-out of the same git repository.) Without this consistency, it's impossible to honor the contract that the same content will produce the same archive, which is necessary for npm to create reprodicible build artifacts that match both in CI and development. This unfortunately still does not address windows, where the executable bit is never set on files. (This bit the mocha project when a publish from a Windows machine did not archive binaries with executable flags set: #210 (comment))
-
-
-
mock out get-write-flag on nodes where filemap is known
Can't overwrite or modify a constant, they're very... constant.
-
There are no files selected for viewing
This file was deleted.