pack: don't drop dots from dotfiles when prefixing

Author: isaacs

lib/pack.js

@@ -129,7 +129,7 @@ const Pack = warner(class Pack extends MiniPass {
   [ADDTARENTRY] (p) {
     const absolute = path.resolve(this.cwd, p.path)
     if (this.prefix)
-      p.path = this.prefix + '/' + p.path.replace(/^\.\/*/, '')
+      p.path = this.prefix + '/' + p.path.replace(/^\.(\/+|$)/, '')
 
     // in this case, we don't have to wait for the stat
     if (!this.filter(p.path, p))
@@ -148,7 +148,7 @@ const Pack = warner(class Pack extends MiniPass {
   [ADDFSENTRY] (p) {
     const absolute = path.resolve(this.cwd, p)
     if (this.prefix)
-      p = this.prefix + '/' + p.replace(/^\.\/*/, '')
+      p = this.prefix + '/' + p.replace(/^\.(\/+|$)/, '')
 
     this[QUEUE].push(new PackJob(p, absolute))
     this[PROCESS]()

test/fixtures/files/.dotfile

@@ -0,0 +1 @@
+.

test/pack.js

@@ -90,19 +90,19 @@ t.test('pack a file', t => {
 t.test('pack a file with a prefix', t => {
   const out = []
   new Pack({ cwd: files, prefix: 'package/' })
-    .end('one-byte.txt')
+    .end('.dotfile')
     .on('data', c => out.push(c))
     .on('end', _ => {
       const data = Buffer.concat(out)
       t.equal(data.length, 2048)
-      t.match(data.slice(512).toString(), /^a\0{511}\0{1024}$/)
+      t.match(data.slice(512).toString(), /^.\n\0{510}\0{1024}$/)
       const h = new Header(data)
       const expect = {
         cksumValid: true,
         needPax: false,
-        path: 'package/one-byte.txt',
+        path: 'package/.dotfile',
         mode: 0o644,
-        size: 1,
+        size: 2,
         mtime: mtime,
         cksum: Number,
         linkpath: '',
@@ -117,7 +117,7 @@ t.test('pack a file with a prefix', t => {
       }
       t.match(h, expect)
       const sync = new PackSync({ cwd: files, prefix: 'package' })
-        .add('one-byte.txt').end().read()
+        .add('.dotfile').end().read()
       t.equal(sync.slice(512).toString(), data.slice(512).toString())
       const hs = new Header(sync)
       t.match(hs, expect)