lint

Author: isaacs

lib/create.js

@@ -4,12 +4,11 @@
 const hlo = require('./high-level-opt.js')
 
 const Pack = require('./pack.js')
-const fs = require('fs')
 const fsm = require('fs-minipass')
 const t = require('./list.js')
 const path = require('path')
 
-const c = module.exports = (opt_, files, cb) => {
+module.exports = (opt_, files, cb) => {
   if (typeof files === 'function')
     cb = files
 
@@ -38,7 +37,7 @@ const c = module.exports = (opt_, files, cb) => {
 const createFileSync = (opt, files) => {
   const p = new Pack.Sync(opt)
   const stream = new fsm.WriteStreamSync(opt.file, {
-    mode: opt.mode || 0o666
+    mode: opt.mode || 0o666,
   })
   p.pipe(stream)
   addFilesSync(p, files)
@@ -47,7 +46,7 @@ const createFileSync = (opt, files) => {
 const createFile = (opt, files, cb) => {
   const p = new Pack(opt)
   const stream = new fsm.WriteStream(opt.file, {
-    mode: opt.mode || 0o666
+    mode: opt.mode || 0o666,
   })
   p.pipe(stream)
 
@@ -64,14 +63,14 @@ const createFile = (opt, files, cb) => {
 
 const addFilesSync = (p, files) => {
   files.forEach(file => {
-    if (file.charAt(0) === '@')
+    if (file.charAt(0) === '@') {
       t({
         file: path.resolve(p.cwd, file.substr(1)),
         sync: true,
         noResume: true,
-        onentry: entry => p.add(entry)
+        onentry: entry => p.add(entry),
       })
-    else
+    } else
       p.add(file)
   })
   p.end()
@@ -80,13 +79,13 @@ const addFilesSync = (p, files) => {
 const addFilesAsync = (p, files) => {
   while (files.length) {
     const file = files.shift()
-    if (file.charAt(0) === '@')
+    if (file.charAt(0) === '@') {
       return t({
         file: path.resolve(p.cwd, file.substr(1)),
         noResume: true,
-        onentry: entry => p.add(entry)
+        onentry: entry => p.add(entry),
       }).then(_ => addFilesAsync(p, files))
-    else
+    } else
       p.add(file)
   }
   p.end()

lib/extract.js

@@ -7,7 +7,7 @@ const fs = require('fs')
 const fsm = require('fs-minipass')
 const path = require('path')
 
-const x = module.exports = (opt_, files, cb) => {
+module.exports = (opt_, files, cb) => {
   if (typeof opt_ === 'function')
     cb = opt_, files = null, opt_ = {}
   else if (Array.isArray(opt_))
@@ -63,22 +63,20 @@ const extractFileSync = opt => {
   const u = new Unpack.Sync(opt)
 
   const file = opt.file
-  let threw = true
-  let fd
   const stat = fs.statSync(file)
   // This trades a zero-byte read() syscall for a stat
   // However, it will usually result in less memory allocation
-  const readSize = opt.maxReadSize || 16*1024*1024
+  const readSize = opt.maxReadSize || 16 * 1024 * 1024
   const stream = new fsm.ReadStreamSync(file, {
     readSize: readSize,
-    size: stat.size
+    size: stat.size,
   })
   stream.pipe(u)
 }
 
 const extractFile = (opt, cb) => {
   const u = new Unpack(opt)
-  const readSize = opt.maxReadSize || 16*1024*1024
+  const readSize = opt.maxReadSize || 16 * 1024 * 1024
 
   const file = opt.file
   const p = new Promise((resolve, reject) => {
@@ -93,7 +91,7 @@ const extractFile = (opt, cb) => {
       else {
         const stream = new fsm.ReadStream(file, {
           readSize: readSize,
-          size: stat.size
+          size: stat.size,
         })
         stream.on('error', reject)
         stream.pipe(u)
@@ -103,10 +101,6 @@ const extractFile = (opt, cb) => {
   return cb ? p.then(cb, cb) : p
 }
 
-const extractSync = opt => {
-  return new Unpack.Sync(opt)
-}
+const extractSync = opt => new Unpack.Sync(opt)
 
-const extract = opt => {
-  return new Unpack(opt)
-}
+const extract = opt => new Unpack(opt)

lib/header.js

@@ -95,19 +95,19 @@ class Header {
     }
 
     let sum = 8 * 0x20
-    for (let i = off; i < off + 148; i++) {
+    for (let i = off; i < off + 148; i++)
       sum += buf[i]
-    }
-    for (let i = off + 156; i < off + 512; i++) {
+
+    for (let i = off + 156; i < off + 512; i++)
       sum += buf[i]
-    }
+
     this.cksumValid = sum === this.cksum
     if (this.cksum === null && sum === 8 * 0x20)
       this.nullBlock = true
   }
 
   [SLURP] (ex, global) {
-    for (let k in ex) {
+    for (const k in ex) {
       // we slurp in everything except for the path attribute in
       // a global extended header, because that's weird.
       if (ex[k] !== null && ex[k] !== undefined &&
@@ -157,12 +157,12 @@ class Header {
     }
 
     let sum = 8 * 0x20
-    for (let i = off; i < off + 148; i++) {
+    for (let i = off; i < off + 148; i++)
       sum += buf[i]
-    }
-    for (let i = off + 156; i < off + 512; i++) {
+
+    for (let i = off + 156; i < off + 512; i++)
       sum += buf[i]
-    }
+
     this.cksum = sum
     encNumber(buf, off + 148, 8, this.cksum)
     this.cksumValid = true
@@ -171,7 +171,7 @@ class Header {
   }
 
   set (data) {
-    for (let i in data) {
+    for (const i in data) {
       if (data[i] !== null && data[i] !== undefined)
         this[i] = data[i]
     }
@@ -242,7 +242,7 @@ const numToDate = num => num === null ? null : new Date(num * 1000)
 
 const decNumber = (buf, off, size) =>
   buf[off] & 0x80 ? large.parse(buf.slice(off, off + size))
-    : decSmallNumber(buf, off, size)
+  : decSmallNumber(buf, off, size)
 
 const nanNull = value => isNaN(value) ? null : value
 
@@ -254,7 +254,7 @@ const decSmallNumber = (buf, off, size) =>
 // the maximum encodable as a null-terminated octal, by field size
 const MAXNUM = {
   12: 0o77777777777,
-  8 : 0o7777777
+  8: 0o7777777,
 }
 
 const encNumber = (buf, off, size, number) =>
@@ -283,6 +283,6 @@ const NULLS = new Array(156).join('\0')
 const encString = (buf, off, size, string) =>
   string === null ? false :
   (buf.write(string + NULLS, off, size, 'utf8'),
-   string.length !== Buffer.byteLength(string) || string.length > size)
+  string.length !== Buffer.byteLength(string) || string.length > size)
 
 module.exports = Header

lib/high-level-opt.js

@@ -21,9 +21,9 @@ const argmap = new Map([
   ['no-mtime', 'noMtime'],
   ['p', 'preserveOwner'],
   ['L', 'follow'],
-  ['h', 'follow']
+  ['h', 'follow'],
 ])
 
-const parse = module.exports = opt => opt ? Object.keys(opt).map(k => [
-  argmap.has(k) ? argmap.get(k) : k, opt[k]
+module.exports = opt => opt ? Object.keys(opt).map(k => [
+  argmap.has(k) ? argmap.get(k) : k, opt[k],
 ]).reduce((set, kv) => (set[kv[0]] = kv[1], set), Object.create(null)) : {}

lib/large-numbers.js

@@ -2,7 +2,7 @@
 // Tar can encode large and negative numbers using a leading byte of
 // 0xff for negative, and 0x80 for positive.
 
-const encode = exports.encode = (num, buf) => {
+const encode = (num, buf) => {
   if (!Number.isSafeInteger(num))
     // The number is so large that javascript cannot represent it with integer
     // precision.
@@ -18,7 +18,7 @@ const encodePositive = (num, buf) => {
   buf[0] = 0x80
 
   for (var i = buf.length; i > 1; i--) {
-    buf[i-1] = num & 0xff
+    buf[i - 1] = num & 0xff
     num = Math.floor(num / 0x100)
   }
 }
@@ -31,25 +31,22 @@ const encodeNegative = (num, buf) => {
     var byte = num & 0xff
     num = Math.floor(num / 0x100)
     if (flipped)
-      buf[i-1] = onesComp(byte)
+      buf[i - 1] = onesComp(byte)
     else if (byte === 0)
-      buf[i-1] = 0
+      buf[i - 1] = 0
     else {
       flipped = true
-      buf[i-1] = twosComp(byte)
+      buf[i - 1] = twosComp(byte)
     }
   }
 }
 
-const parse = exports.parse = (buf) => {
-  var post = buf[buf.length - 1]
-  var pre = buf[0]
-  var value;
-  if (pre === 0x80)
-    value = pos(buf.slice(1, buf.length))
-  else if (pre === 0xff)
-    value = twos(buf)
-  else
+const parse = (buf) => {
+  const pre = buf[0]
+  const value = pre === 0x80 ? pos(buf.slice(1, buf.length))
+    : pre === 0xff ? twos(buf)
+    : null
+  if (value === null)
     throw Error('invalid base256 encoding')
 
   if (!Number.isSafeInteger(value))
@@ -95,3 +92,8 @@ const pos = (buf) => {
 const onesComp = byte => (0xff ^ byte) & 0xff
 
 const twosComp = byte => ((0xff ^ byte) + 1) & 0xff
+
+module.exports = {
+  encode,
+  parse,
+}

lib/list.js

@@ -10,7 +10,7 @@ const fs = require('fs')
 const fsm = require('fs-minipass')
 const path = require('path')
 
-const t = module.exports = (opt_, files, cb) => {
+module.exports = (opt_, files, cb) => {
   if (typeof opt_ === 'function')
     cb = opt_, files = null, opt_ = {}
   else if (Array.isArray(opt_))
@@ -79,30 +79,33 @@ const listFileSync = opt => {
   let fd
   try {
     const stat = fs.statSync(file)
-    const readSize = opt.maxReadSize || 16*1024*1024
-    if (stat.size < readSize) {
+    const readSize = opt.maxReadSize || 16 * 1024 * 1024
+    if (stat.size < readSize)
       p.end(fs.readFileSync(file))
-    } else {
+    else {
       let pos = 0
       const buf = Buffer.allocUnsafe(readSize)
       fd = fs.openSync(file, 'r')
       while (pos < stat.size) {
-        let bytesRead = fs.readSync(fd, buf, 0, readSize, pos)
+        const bytesRead = fs.readSync(fd, buf, 0, readSize, pos)
         pos += bytesRead
         p.write(buf.slice(0, bytesRead))
       }
       p.end()
     }
     threw = false
   } finally {
-    if (threw && fd)
-      try { fs.closeSync(fd) } catch (er) {}
+    if (threw && fd) {
+      try {
+        fs.closeSync(fd)
+      } catch (er) {}
+    }
   }
 }
 
 const listFile = (opt, cb) => {
   const parse = new Parser(opt)
-  const readSize = opt.maxReadSize || 16*1024*1024
+  const readSize = opt.maxReadSize || 16 * 1024 * 1024
 
   const file = opt.file
   const p = new Promise((resolve, reject) => {
@@ -115,7 +118,7 @@ const listFile = (opt, cb) => {
       else {
         const stream = new fsm.ReadStream(file, {
           readSize: readSize,
-          size: stat.size
+          size: stat.size,
         })
         stream.on('error', reject)
         stream.pipe(parse)