fix: make defaults chaining actually work (v9 regression)
#144
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The README says: > A defaulted `fetch` will also have a `.defaults()` method, so they can > be chained. But this didn't really work, because while the `defaults` method was placed on the `defaulted` fetch, a chained defaulted fetch would just call the original fetch function directly instead of the intermediate function. This PR makes chaining actually work and adds a test. Also, it fixes the previous test, which wasn't actually verifying that the correct request headers were received because it used the nock API incorrectly: the option is `reqheaders` not `reqHeaders`.
glasser
changed the title
defaults chaining actually workdefaults chaining actually work (v9 regression)
wraithgar
approved these changes
May 9, 2022
|
Thank you |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The README says:
But this didn't really work, because while the
defaultsmethod wasplaced on the
defaultedfetch, a chained defaulted fetch would justcall the original fetch function directly instead of the intermediate
function.
This PR makes chaining actually work and adds a test.
Also, it fixes the previous test, which wasn't actually verifying that
the correct request headers were received because it used the nock API
incorrectly: the option is
reqheadersnotreqHeaders.Note that this was a regression in v9.0.0; the equivalent line before the refactor grabbed
thisand called that instead. (We don't use that approach here because it doesn't work in an arrow function.)