feat: removed figgy-pudding as a dependency

BREAKING CHANGE

Author: Michael Perrotte

index.js

@@ -1,93 +1,94 @@
 'use strict'
 
 const eu = encodeURIComponent
-const figgyPudding = require('figgy-pudding')
 const getStream = require('get-stream')
 const npmFetch = require('npm-registry-fetch')
 const validate = require('aproba')
 
-const TeamConfig = figgyPudding({
-  description: {},
-  Promise: { default: () => Promise }
-})
-
 const cmd = module.exports = {}
 
-cmd.create = (entity, opts) => {
-  opts = TeamConfig(opts)
+cmd.create = (entity, opts = { description: undefined }) => {
   return pwrap(opts, () => {
     const { scope, team } = splitEntity(entity)
     validate('SSO', [scope, team, opts])
-    return npmFetch.json(`/-/org/${eu(scope)}/team`, opts.concat({
+    const uri = `/-/org/${eu(scope)}/team`
+    return npmFetch.json(uri, {
+      ...opts,
       method: 'PUT',
       scope,
       body: { name: team, description: opts.description }
-    }))
+    })
   })
 }
 
-cmd.destroy = (entity, opts) => {
-  opts = TeamConfig(opts)
+cmd.destroy = (entity, opts = {}) => {
   return pwrap(opts, () => {
     const { scope, team } = splitEntity(entity)
     validate('SSO', [scope, team, opts])
-    return npmFetch.json(`/-/team/${eu(scope)}/${eu(team)}`, opts.concat({
+    const uri = `/-/team/${eu(scope)}/${eu(team)}`
+    return npmFetch.json(uri, {
+      ...opts,
       method: 'DELETE',
       scope
-    }))
+    })
   })
 }
 
-cmd.add = (user, entity, opts) => {
-  opts = TeamConfig(opts)
+cmd.add = (user, entity, opts = {}) => {
   return pwrap(opts, () => {
     const { scope, team } = splitEntity(entity)
     validate('SSO', [scope, team, opts])
-    return npmFetch.json(`/-/team/${eu(scope)}/${eu(team)}/user`, opts.concat({
+    const uri = `/-/team/${eu(scope)}/${eu(team)}/user`
+    return npmFetch.json(uri, {
+      ...opts,
       method: 'PUT',
       scope,
       body: { user }
-    }))
+    })
   })
 }
 
-cmd.rm = (user, entity, opts) => {
-  opts = TeamConfig(opts)
+cmd.rm = (user, entity, opts = {}) => {
   return pwrap(opts, () => {
     const { scope, team } = splitEntity(entity)
     validate('SSO', [scope, team, opts])
-    return npmFetch.json(`/-/team/${eu(scope)}/${eu(team)}/user`, opts.concat({
+    const uri = `/-/team/${eu(scope)}/${eu(team)}/user`
+    return npmFetch.json(uri, {
+      ...opts,
       method: 'DELETE',
       scope,
       body: { user }
-    }))
+    })
   })
 }
 
-cmd.lsTeams = (scope, opts) => {
-  opts = TeamConfig(opts)
-  return pwrap(opts, () => getStream.array(cmd.lsTeams.stream(scope, opts)))
+cmd.lsTeams = (scope, opts = {}) => {
+  return pwrap(opts, () => {
+    return getStream.array(cmd.lsTeams.stream(scope, { ...opts }))
+  })
 }
-cmd.lsTeams.stream = (scope, opts) => {
-  opts = TeamConfig(opts)
+cmd.lsTeams.stream = (scope, opts = {}) => {
   validate('SO', [scope, opts])
-  return npmFetch.json.stream(`/-/org/${eu(scope)}/team`, '.*', opts.concat({
+  const uri = `/-/org/${eu(scope)}/team`
+  return npmFetch.json.stream(uri, '.*', {
+    ...opts,
     query: { format: 'cli' }
-  }))
+  })
 }
 
-cmd.lsUsers = (entity, opts) => {
-  opts = TeamConfig(opts)
-  return pwrap(opts, () => getStream.array(cmd.lsUsers.stream(entity, opts)))
+cmd.lsUsers = (entity, opts = {}) => {
+  return pwrap(opts, () => {
+    return getStream.array(cmd.lsUsers.stream(entity, { ...opts }))
+  })
 }
-cmd.lsUsers.stream = (entity, opts) => {
-  opts = TeamConfig(opts)
+cmd.lsUsers.stream = (entity, opts = {}) => {
   const { scope, team } = splitEntity(entity)
   validate('SSO', [scope, team, opts])
   const uri = `/-/team/${eu(scope)}/${eu(team)}/user`
-  return npmFetch.json.stream(uri, '.*', opts.concat({
+  return npmFetch.json.stream(uri, '.*', {
+    ...opts,
     query: { format: 'cli' }
-  }))
+  })
 }
 
 cmd.edit = () => {
@@ -100,7 +101,7 @@ function splitEntity (entity = '') {
 }
 
 function pwrap (opts, fn) {
-  return new opts.Promise((resolve, reject) => {
+  return new Promise((resolve, reject) => {
     fn().then(resolve, reject)
   })
 }

package.json

@@ -25,7 +25,6 @@
   "homepage": "https://npmjs.com/package/libnpmteam",
   "dependencies": {
     "aproba": "^2.0.0",
-    "figgy-pudding": "^3.4.1",
     "get-stream": "^4.0.0",
     "npm-registry-fetch": "^4.0.0"
   },

test/index.js

@@ -1,16 +1,15 @@
 'use strict'
 
-const figgyPudding = require('figgy-pudding')
 const getStream = require('get-stream')
 const { test } = require('tap')
 const tnock = require('./fixtures/tnock.js')
 
 const team = require('../index.js')
 
 const REG = 'http://localhost:1337'
-const OPTS = figgyPudding({})({
+const OPTS = {
   registry: REG
-})
+}
 
 test('create', t => {
   tnock(t, REG).put(
@@ -40,9 +39,10 @@ test('create w/ description', t => {
     name: 'cli',
     description: 'just some cool folx'
   }).reply(201, { name: 'cli' })
-  return team.create('@foo:cli', OPTS.concat({
+  return team.create('@foo:cli', {
+    ...OPTS,
     description: 'just some cool folx'
-  })).then(ret => {
+  }).then(ret => {
     t.deepEqual(ret, { name: 'cli' }, 'no desc in return')
   })
 })