Skip to content
This repository was archived by the owner on Jan 19, 2022. It is now read-only.

Commit 54620fb

Browse files
author
Michael Perrotte
committedMar 2, 2020
fix: remove unneed promises; [PR feedback]
1 parent 36c5330 commit 54620fb

File tree

1 file changed

+28
-34
lines changed

1 file changed

+28
-34
lines changed
 

‎index.js

+28-34
Original file line numberDiff line numberDiff line change
@@ -5,7 +5,7 @@ const fetch = require('npm-registry-fetch')
55
const validate = require('aproba')
66

77
// From https://github.com/npm/registry/blob/master/docs/orgs/memberships.md
8-
const cmd = module.exports = {}
8+
const cmd = module.exports
99

1010
class MembershipDetail {}
1111
cmd.set = (org, user, role, opts = {}) => {
@@ -16,46 +16,40 @@ cmd.set = (org, user, role, opts = {}) => {
1616
opts = role
1717
role = undefined
1818
}
19-
return Promise.resolve().then(() => {
20-
validate('SSSO|SSZO', [org, user, role, opts])
21-
user = user.replace(/^@?/, '')
22-
org = org.replace(/^@?/, '')
23-
return fetch.json(`/-/org/${eu(org)}/user`, {
24-
...opts,
25-
method: 'PUT',
26-
body: { user, role }
27-
}).then(ret => Object.assign(new MembershipDetail(), ret))
28-
})
19+
validate('SSSO|SSZO', [org, user, role, opts])
20+
user = user.replace(/^@?/, '')
21+
org = org.replace(/^@?/, '')
22+
return fetch.json(`/-/org/${eu(org)}/user`, {
23+
...opts,
24+
method: 'PUT',
25+
body: { user, role }
26+
}).then(ret => Object.assign(new MembershipDetail(), ret))
2927
}
3028

3129
cmd.rm = (org, user, opts = {}) => {
32-
return Promise.resolve().then(() => {
33-
validate('SSO', [org, user, opts])
34-
user = user.replace(/^@?/, '')
35-
org = org.replace(/^@?/, '')
36-
return fetch(`/-/org/${eu(org)}/user`, {
37-
...opts,
38-
method: 'DELETE',
39-
body: { user },
40-
ignoreBody: true
41-
}).then(() => null)
42-
})
30+
validate('SSO', [org, user, opts])
31+
user = user.replace(/^@?/, '')
32+
org = org.replace(/^@?/, '')
33+
return fetch(`/-/org/${eu(org)}/user`, {
34+
...opts,
35+
method: 'DELETE',
36+
body: { user },
37+
ignoreBody: true
38+
}).then(() => null)
4339
}
4440

4541
class Roster {}
4642
cmd.ls = (org, opts = {}) => {
47-
return Promise.resolve().then(() => {
48-
return cmd.ls.stream(org, opts)
49-
.collect()
50-
.then(data => data.reduce((acc, [key, val]) => {
51-
if (!acc) {
52-
acc = {}
53-
}
54-
acc[key] = val
55-
return acc
56-
}, null))
57-
.then(ret => Object.assign(new Roster(), ret))
58-
})
43+
return cmd.ls.stream(org, opts)
44+
.collect()
45+
.then(data => data.reduce((acc, [key, val]) => {
46+
if (!acc) {
47+
acc = {}
48+
}
49+
acc[key] = val
50+
return acc
51+
}, null))
52+
.then(ret => Object.assign(new Roster(), ret))
5953
}
6054

6155
cmd.ls.stream = (org, opts = {}) => {

0 commit comments

Comments
 (0)
This repository has been archived.