feat: replace get-stream with minipass

Author: Michael Perrotte

index.js

@@ -1,9 +1,8 @@
 'use strict'
 
-const getStream = require('get-stream')
+const Minipass = require('minipass')
 const npa = require('npm-package-arg')
 const npmFetch = require('npm-registry-fetch')
-const { PassThrough } = require('stream')
 const validate = require('aproba')
 
 const eu = encodeURIComponent
@@ -81,15 +80,17 @@ cmd.revoke = (spec, entity, opts) => {
 
 cmd.lsPackages = (entity, opts) => {
   return pwrap(opts, () => {
-    return getStream.array(
-      cmd.lsPackages.stream(entity, opts)
-    ).then(data => data.reduce((acc, [key, val]) => {
-      if (!acc) {
-        acc = {}
-      }
-      acc[key] = val
-      return acc
-    }, null))
+    return cmd.lsPackages.stream(entity, opts)
+      .collect()
+      .then(data => {
+        return data.reduce((acc, [key, val]) => {
+          if (!acc) {
+            acc = {}
+          }
+          acc[key] = val
+          return acc
+        }, null)
+      })
   })
 }
 
@@ -104,7 +105,7 @@ cmd.lsPackages.stream = (entity, opts) => {
   }
   opts.query = { format: 'cli' }
   opts.mapJSON = mapJSON
-  const ret = new PassThrough({ objectMode: true })
+  const ret = new Minipass({ objectMode: true })
   npmFetch.json.stream(uri, '*', opts).on('error', err => {
     if (err.code === 'E404' && !team) {
       uri = `/-/user/${eu(scope)}/package`
@@ -124,15 +125,17 @@ cmd.lsCollaborators = (spec, user, opts) => {
     user = undefined
   }
   return pwrap(opts, () => {
-    return getStream.array(
-      cmd.lsCollaborators.stream(spec, user, opts)
-    ).then(data => data.reduce((acc, [key, val]) => {
-      if (!acc) {
-        acc = {}
-      }
-      acc[key] = val
-      return acc
-    }, null))
+    return cmd.lsCollaborators.stream(spec, user, opts)
+      .collect()
+      .then(data => {
+        return data.reduce((acc, [key, val]) => {
+          if (!acc) {
+            acc = {}
+          }
+          acc[key] = val
+          return acc
+        }, null)
+      })
   })
 }
 

package-lock.json

@@ -25,7 +25,7 @@
   "homepage": "https://npmjs.com/package/libnpmaccess",
   "dependencies": {
     "aproba": "^2.0.0",
-    "get-stream": "^4.0.0",
+    "minipass": "^3.1.1",
     "npm-package-arg": "^8.0.0",
     "npm-registry-fetch": "^4.0.0"
   },

package.json

@@ -1,6 +1,5 @@
 'use strict'
 
-const getStream = require('get-stream')
 const { test } = require('tap')
 const tnock = require('./util/tnock.js')
 
@@ -227,11 +226,11 @@ test('ls-packages stream', t => {
   tnock(t, REG).get(
     '/-/team/myorg/myteam/package?format=cli'
   ).reply(200, serverPackages)
-  return getStream.array(
-    access.lsPackages.stream('myorg:myteam', OPTS)
-  ).then(data => {
-    t.deepEqual(data, clientPackages, 'got streamed client package info')
-  })
+  return access.lsPackages.stream('myorg:myteam', OPTS)
+    .collect()
+    .then(data => {
+      t.deepEqual(data, clientPackages, 'got streamed client package info')
+    })
 })
 
 test('ls-collaborators', t => {
@@ -267,11 +266,11 @@ test('ls-collaborators stream', t => {
   tnock(t, REG).get(
     '/-/package/%40foo%2Fbar/collaborators?format=cli'
   ).reply(200, serverCollaborators)
-  return getStream.array(
-    access.lsCollaborators.stream('@foo/bar', OPTS)
-  ).then(data => {
-    t.deepEqual(data, clientCollaborators, 'got collaborators')
-  })
+  return access.lsCollaborators.stream('@foo/bar', OPTS)
+    .collect()
+    .then(data => {
+      t.deepEqual(data, clientCollaborators, 'got collaborators')
+    })
 })
 
 test('ls-collaborators w/scope', t => {