Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: npm/cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: cb0db7c3fd1d0a4c30db9f44e9ea9e69ec327fe8
Choose a base ref
...
head repository: npm/cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: d0e7491162965e539da51903f87fa5991d3cd04b
Choose a head ref

Commits on Jul 12, 2022

  1. chore: add dependencies script (#5148)

    No more having to manually remember to run this!
    wraithgar authored Jul 12, 2022
    Copy the full SHA
    6e68d23 View commit details
  2. Copy the full SHA
    52ec5ec View commit details
  3. Copy the full SHA
    c6c4ba3 View commit details
  4. Copy the full SHA
    e58f02f View commit details
  5. deps: minipass@3.3.4

    wraithgar committed Jul 12, 2022
    Copy the full SHA
    b8c0580 View commit details
  6. deps: lru-cache@7.12.0

    wraithgar committed Jul 12, 2022
    Copy the full SHA
    ad72611 View commit details
  7. deps: just-diff@5.0.3

    wraithgar committed Jul 12, 2022
    Copy the full SHA
    c94919d View commit details
  8. deps: just-diff-apply@5.3.1

    wraithgar committed Jul 12, 2022
    Copy the full SHA
    18ddc57 View commit details
  9. deps: npm-package-arg@9.1.0

    wraithgar committed Jul 12, 2022
    Copy the full SHA
    a2d700b View commit details
  10. deps: @npmcli/run-script@4.1.7

      * unique filename for temporary script files
      * correctly translate paths when using bash in windows
    wraithgar committed Jul 12, 2022
    Copy the full SHA
    99dc697 View commit details
  11. chore: tap@16.3.0

    wraithgar committed Jul 12, 2022
    Copy the full SHA
    13381b9 View commit details
  12. chore: nock@13.2.8

    wraithgar committed Jul 12, 2022
    Copy the full SHA
    d3791e6 View commit details
  13. feat: Add web auth type (#5076)

    jumoel authored Jul 12, 2022
    Copy the full SHA
    e8102c1 View commit details
  14. Copy the full SHA
    4a9f2dc View commit details
  15. Copy the full SHA
    45a9bde View commit details

Commits on Jul 13, 2022

  1. chore: suggest dogfooding npm when developing it (#5159)

    Some folks may be running older versions of npm globally, or maybe even
    have aliased another package manager to `npm`.  This will ensure the
    latest npm source is running when developing the cli itself.
    wraithgar authored Jul 13, 2022
    Copy the full SHA
    2dfa8a4 View commit details
  2. Copy the full SHA
    51cdee4 View commit details
  3. Copy the full SHA
    f1a9fc9 View commit details
  4. Copy the full SHA
    40c2b19 View commit details
  5. chore: update AUTHORS

    wraithgar committed Jul 13, 2022
    Copy the full SHA
    6462e24 View commit details
  6. 8.14.0

    wraithgar committed Jul 13, 2022
    Copy the full SHA
    0c209ff View commit details

Commits on Jul 19, 2022

  1. deps: @npmcli/config@4.2.0

    wraithgar authored and fritzy committed Jul 19, 2022
    Copy the full SHA
    64fe64b View commit details
  2. deps: npm-registry-fetch@13.3.0

    wraithgar authored and fritzy committed Jul 19, 2022
    Copy the full SHA
    51b12a0 View commit details

Commits on Jul 20, 2022

  1. feat: accept registry-scoped certfile and keyfile as credentials (#5160)

    Closes #4765
    RFC: npm/rfcs#591
    
    While this doesn't directly allow top-level cert/key as credentials (per the
    original issue), it's a more targeted/secure approach that accomplishes the
    same end-result; the new options are scoped to a specific registry, and the
    actual cert/key contents are much less likely to be exposed. See the RFC for
    more context.
    
    Depends on:
    * npm/npm-registry-fetch#125
    * npm/config#69
    jenseng authored Jul 20, 2022
    Copy the full SHA
    5ef53ee View commit details
  2. docs: Update audit signatures cmd (#5168)

    fix: Update docs for audit signatures cmd
    
    Update command documentation for `npm audit signatures` added in this PR:
    #4827
    feelepxyz authored Jul 20, 2022
    Copy the full SHA
    7efad06 View commit details
  3. fix: disable progress bar on publish (#5172)

    It is not supposed to be there, in that it doesn't get any updates and
    gets in the way of logging messages.  We already log the server we are
    publishing to in the `notice` headers so the one `http` log message that
    we get during publish isn't needed on stdout.
    wraithgar authored Jul 20, 2022
    Copy the full SHA
    9c590fa View commit details
  4. Copy the full SHA
    2fa3271 View commit details
  5. docs: correct bundledDependencies -> bundleDependencies (#5171)

    arborist normalizes `bundledDependencies` to `bundleDependencies`, this change corrects the documentation to match that reality
    nlf authored Jul 20, 2022
    Copy the full SHA
    8ab5fca View commit details
  6. deps: make-fetch-happen@10.2.0 (#5190)

    * store link header in cached responses
    wraithgar authored Jul 20, 2022
    Copy the full SHA
    3ae1b81 View commit details
  7. Copy the full SHA
    bf3b26c View commit details
  8. chore(contributing.md): add conventional commit info (#5169)

    Update info on coverage too, it's auto-enforce now no separate command
    needed.
    wraithgar authored Jul 20, 2022
    Copy the full SHA
    68ade72 View commit details
  9. feat: Support pure web authentication for commands

    * feat: Add support for web auth, utilizing code from npm-profile
    
    Co-authored-by: Jordan Harband <ljharb@gmail.com>
    Co-authored-by: Hayden Faulds <fauldsh@gmail.com>
    Co-authored-by: Sandeep Meduru <sandeepmeduru@github.com>
    4 people authored and fritzy committed Jul 20, 2022
    Copy the full SHA
    c8bdb4a View commit details
  10. chore: changelog for v8.15.0

    fritzy committed Jul 20, 2022
    Copy the full SHA
    6014a94 View commit details
  11. chore: update AUTHORS

    fritzy committed Jul 20, 2022
    Copy the full SHA
    a06d196 View commit details
  12. 8.15.0

    fritzy committed Jul 20, 2022
    Copy the full SHA
    4c94530 View commit details

Commits on Jul 21, 2022

  1. fix: don't fail immediately if cache dir is not accessible (#5197)

    This also changes all the log messages about not being able to create
    initial directories and files to `log.verbose` since we know run those
    commands on init. There are a lot of valid reasons why those might fail,
    and we don't want to show a warning for them every time.
    
    Fixes: #4769
    Fixes: #4838
    Fixes: #4996
    lukekarrys authored Jul 21, 2022
    Copy the full SHA
    9905d0e View commit details
  2. Copy the full SHA
    f9abee7 View commit details

Commits on Jul 27, 2022

  1. Copy the full SHA
    77bf2e1 View commit details
  2. Copy the full SHA
    0e3660e View commit details
  3. Copy the full SHA
    de40c31 View commit details
  4. fix: allow hash character in paths (#5122)

    * fix: allow link from path with hash character
    
    * fix: allow hash character in path in other places
    
    * Remove extra semicolon
    AgainPsychoX authored Jul 27, 2022
    Copy the full SHA
    62b95a0 View commit details
  5. docs: describe implicit workspace and prefix configuration (#5221)

    * docs: describe implicit workspace and prefix configuration
    
    * Update docs/content/using-npm/workspaces.md
    
    Co-authored-by: Gar <gar+gh@danger.computer>
    
    Co-authored-by: Luke Karrys <luke@lukekarrys.com>
    Co-authored-by: Gar <gar+gh@danger.computer>
    3 people authored Jul 27, 2022
    Copy the full SHA
    4d1d8a9 View commit details
  6. Copy the full SHA
    a02cce5 View commit details
  7. deps: @npmcli/arborist@5.3.1

    npm-cli-bot authored and lukekarrys committed Jul 27, 2022
    Copy the full SHA
    3bbb293 View commit details
  8. Copy the full SHA
    a1f6d97 View commit details
  9. chore: update AUTHORS

    lukekarrys committed Jul 27, 2022
    Copy the full SHA
    17b1dea View commit details
  10. 8.15.1

    lukekarrys committed Jul 27, 2022
    Copy the full SHA
    58cc362 View commit details

Commits on Aug 1, 2022

  1. fix(ls): when filtering workspaces, make sure the edge has a to befor…

    …e checking if its a workspace (#5164)
    nlf authored Aug 1, 2022
    Copy the full SHA
    eac1bf2 View commit details
  2. docs: Use the full proper name of Travis CI (#5240)

    Use the full proper name of Travis CI
    
    Signed-off-by: Takuya Noguchi <takninnovationresearch@gmail.com>
    tnir authored Aug 1, 2022
    Copy the full SHA
    a6153cf View commit details
  3. fix(arborist): use the sourceReference root rather than the node root…

    … for overrides (#5227)
    
    when we examine override references, if we look at only `this.from.root.package` the root could actually be a virtual one. in order to ensure we resolve references from the real root, we instead need to look at `this.from.sourceReference.root.package` to get the correct value.
    
    closes #4395
    nlf authored Aug 1, 2022
    Copy the full SHA
    47cc95d View commit details
Showing 1,975 changed files with 179,621 additions and 133,412 deletions.
10 changes: 10 additions & 0 deletions .commitlintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,10 @@
/* This file is automatically added by @npmcli/template-oss. Do not edit. */

module.exports = {
extends: ['@commitlint/config-conventional'],
rules: {
'type-enum': [2, 'always', ['feat', 'fix', 'docs', 'deps', 'chore']],
'header-max-length': [2, 'always', 80],
'subject-case': [0, 'always', ['lower-case', 'sentence-case', 'start-case']],
},
}
11 changes: 11 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -1,3 +1,7 @@
/* This file is automatically added by @npmcli/template-oss. Do not edit. */

'use strict'

const { readdirSync: readdir } = require('fs')

const localConfigs = readdir(__dirname)
@@ -6,6 +10,13 @@ const localConfigs = readdir(__dirname)

module.exports = {
root: true,
ignorePatterns: [
'docs/**',
'smoke-tests/**',
'mock-globals/**',
'mock-registry/**',
'workspaces/**',
],
extends: [
'@npmcli',
...localConfigs,
37 changes: 37 additions & 0 deletions .eslintrc.local.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,37 @@
const { resolve, relative } = require('path')

// Create an override to lockdown a file to es6 syntax only
// and only allow it to require an allowlist of files
const rel = (p) => relative(__dirname, resolve(__dirname, p))
const braces = (a) => a.length > 1 ? `{${a.map(rel).join(',')}}` : a[0]

const es6Files = (e) => Object.entries(e).map(([file, allow]) => ({
files: `./${rel(file)}`,
parserOptions: {
ecmaVersion: 6,
},
rules: Array.isArray(allow) ? {
'node/no-restricted-require': ['error', [{
name: ['/**', `!${__dirname}/${braces(allow)}`],
message: `This file can only require: ${allow.join(',')}`,
}]],
} : {},
}))

module.exports = {
rules: {
'no-console': 'error',
},
overrides: es6Files({
'index.js': ['lib/cli.js'],
'bin/npm-cli.js': ['lib/cli.js'],
'lib/cli.js': ['lib/es6/validate-engines.js'],
'lib/es6/validate-engines.js': ['package.json'],
// TODO: This file should also have its requires restricted as well since it
// is an entry point but it currently pulls in config definitions which have
// a large require graph, so that is not currently feasible. A future config
// refactor should keep that in mind and see if only config definitions can
// be exported in a way that is compatible with ES6.
'bin/npx-cli.js': null,
}),
}
20 changes: 0 additions & 20 deletions .eslintrc.local.json

This file was deleted.

29 changes: 27 additions & 2 deletions .gitattributes
Original file line number Diff line number Diff line change
@@ -1,2 +1,27 @@
/node_modules/** linguist-generated=false
/package-lock.json linguist-generated=false
# normalize all line endings by default
* text=auto

# our shell/bin scripts always need to be LF
/bin/* text eol=lf
/workspaces/arborist/bin/index.js text eol=lf
/configure text eol=lf

# our cmd scripts always need to be CRLF
/bin/*.cmd text eol=crlf

# ignore all line endings in node_modules since we dont control that
/node_modules/** -text

# the files we write should be LF so they can be generated cross platform
/node_modules/.gitignore text eol=lf
/workspaces/arborist/test/fixtures/.gitignore text eol=lf
/DEPENDENCIES.md text eol=lf
/AUTHORS text eol=lf

# fixture tarballs should be treated as binary
/workspaces/*/test/fixtures/**/*.tgz binary

# these hint to GitHub to show these files as not generated so they default to
# showing the full diff in pull requests
/node_modules/** linguist-generated=false
/package-lock.json linguist-generated=false
4 changes: 3 additions & 1 deletion .github/CODEOWNERS
Original file line number Diff line number Diff line change
@@ -1 +1,3 @@
* @npm/cli-team
# This file is automatically added by @npmcli/template-oss. Do not edit.

* @npm/cli-team
63 changes: 63 additions & 0 deletions .github/ISSUE_TEMPLATE/bug_9.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,63 @@
name: 🐞 Bug v9
description: File a bug/issue against v9.x
title: "[BUG] <title>"
labels: [Bug, Needs Triage, Release 9.x]
body:
- type: checkboxes
attributes:
label: Is there an existing issue for this?
description: Please [search here](https://github.com/npm/cli/issues) to see if an issue already exists for your problem.
options:
- label: I have searched the existing issues
required: true
- type: checkboxes
attributes:
label: This issue exists in the latest npm version
description: Please make sure you have installed the latest npm and verified it is still an issue.
options:
- label: I am using the latest npm
required: true
- type: textarea
attributes:
label: Current Behavior
description: A clear & concise description of what you're experiencing.
validations:
required: false
- type: textarea
attributes:
label: Expected Behavior
description: A clear & concise description of what you expected to happen.
validations:
required: false
- type: textarea
attributes:
label: Steps To Reproduce
description: Steps to reproduce the behavior.
value: |
1. In this environment...
2. With this config...
3. Run '...'
4. See error...
validations:
required: false
- type: textarea
attributes:
label: Environment
description: |
examples:
- **`npm -v`**: **npm**: 7.6.3
- **`node -v`**: **Node.js**: 13.14.0
- **OS Name**: Ubuntu 20.04
- **System Model Name**: Macbook Pro
- **`npm config ls`**: `; "user" config from ...`
value: |
- npm:
- Node.js:
- OS Name:
- System Model Name:
- npm config:
```ini
; copy and paste output from `npm config ls` here
```
validations:
required: false
32 changes: 32 additions & 0 deletions .github/matchers/tap.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
{
"//@npmcli/template-oss": "This file is automatically added by @npmcli/template-oss. Do not edit.",
"problemMatcher": [
{
"owner": "tap",
"pattern": [
{
"regexp": "^\\s*not ok \\d+ - (.*)",
"message": 1
},
{
"regexp": "^\\s*---"
},
{
"regexp": "^\\s*at:"
},
{
"regexp": "^\\s*line:\\s*(\\d+)",
"line": 1
},
{
"regexp": "^\\s*column:\\s*(\\d+)",
"column": 1
},
{
"regexp": "^\\s*file:\\s*(.*)",
"file": 1
}
]
}
]
}
39 changes: 39 additions & 0 deletions .github/workflows/audit.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,39 @@
# This file is automatically added by @npmcli/template-oss. Do not edit.

name: Audit

on:
workflow_dispatch:
schedule:
# "At 08:00 UTC (01:00 PT) on Monday" https://crontab.guru/#0_8_*_*_1
- cron: "0 8 * * 1"

jobs:
audit:
name: Audit Dependencies
if: github.repository_owner == 'npm'
runs-on: ubuntu-latest
defaults:
run:
shell: bash
steps:
- name: Checkout
uses: actions/checkout@v3
- name: Setup Git User
run: |
git config --global user.email "npm-cli+bot@github.com"
git config --global user.name "npm CLI robot"
- name: Setup Node
uses: actions/setup-node@v3
with:
node-version: 20.x
cache: npm
check-latest: true
- name: Check Git Status
run: node scripts/git-dirty.js
- name: Reset Deps
run: node scripts/resetdeps.js --package-lock
- name: Run Production Audit
run: node . audit --omit=dev
- name: Run Full Audit
run: node . audit --audit-level=none
85 changes: 0 additions & 85 deletions .github/workflows/ci-docs.yml

This file was deleted.

Loading