Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: npm/cli
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 0ee4927d2e8206dd24fa7eea5e1c10ea649ecc49
Choose a base ref
...
head repository: npm/cli
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: b74e53e4584f41c7f7f774fb5575df6b81d81734
Choose a head ref

Commits on Jan 26, 2022

  1. Copy the full SHA
    76afe15 View commit details

Commits on Jan 27, 2022

  1. Copy the full SHA
    6c0dc1f View commit details
  2. Copy the full SHA
    41b8f7b View commit details
  3. Copy the full SHA
    433e6aa View commit details
  4. Copy the full SHA
    6654b6e View commit details
  5. Copy the full SHA
    3423a98 View commit details
  6. Copy the full SHA
    fb03e48 View commit details
  7. docs: changelog for v8.4.0

    wraithgar committed Jan 27, 2022
    Copy the full SHA
    385cf5e View commit details
  8. update AUTHORS

    wraithgar committed Jan 27, 2022
    Copy the full SHA
    1acae20 View commit details
  9. 8.4.0

    wraithgar committed Jan 27, 2022
    Copy the full SHA
    b7ba444 View commit details
  10. Copy the full SHA
    f5a7360 View commit details

Commits on Feb 1, 2022

  1. deps: wide-align@1.1.5

    wraithgar committed Feb 1, 2022
    Copy the full SHA
    3d41447 View commit details
  2. Copy the full SHA
    dc1a057 View commit details
  3. Copy the full SHA
    adcefef View commit details
  4. deps: debug@4.3.3

    wraithgar committed Feb 1, 2022
    Copy the full SHA
    d7e2499 View commit details
  5. deps: @npmcli/fs@1.1.0

    wraithgar committed Feb 1, 2022
    Copy the full SHA
    f0f3071 View commit details
  6. deps: is-core-module@2.8.1

    wraithgar committed Feb 1, 2022
    Copy the full SHA
    1cb107d View commit details
  7. deps: cli-table3@0.6.1

    wraithgar committed Feb 1, 2022
    Copy the full SHA
    e198ac0 View commit details
  8. deps: graceful-fs@4.2.9

    wraithgar committed Feb 1, 2022
    Copy the full SHA
    5a84e65 View commit details

Commits on Feb 3, 2022

  1. Copy the full SHA
    003d7fb View commit details
  2. fix(log): pass in logger to external modules

    Most of these module use npm-registry-fetch under the hood, which will
    log things like the `npm-notice` header if seen.  Currently we aren't
    passing in a logger to them, which means that log message is never seen,
    among any other logged messages those modules may need to make.
    
    I added tests where I could. Some tests were in a state where the entire
    libnpm* module was an empty mocked function, so asserting that it got
    passed a `log` attribute was onerous.
    wraithgar committed Feb 3, 2022
    Copy the full SHA
    1b93385 View commit details
  3. docs: bundleDependencies can be a boolean. (#4361)

    This has been possible since this commit in `npm-bundled`:
    npm/npm-bundled@101a94d
    forty authored Feb 3, 2022
    Copy the full SHA
    0b0a7cc View commit details
  4. fix(ci): lock file validation

    Make sure to validate any lock file (either package-lock.json or
    npm-shrinkwrap.json) against the current install. This will properly
    throw an error in case any of the dependencies being installed don't
    match the dependencies that are currently listed in the lock file.
    
    Fixes: #2701
    Fixes: #3947
    ruyadorno committed Feb 3, 2022
    Copy the full SHA
    457e0ae View commit details
  5. fix(ci): should not use package-lock config

    `npm ci` should never be affected by the `package-lock` config.
    
    Fixes: #4185
    ruyadorno committed Feb 3, 2022
    Copy the full SHA
    c0519ed View commit details
  6. fix(outdated): parse aliased modules

    Fixes `npm outdated` to properly parse and display info on aliased
    packages.
    
    Fixes: #2800
    ruyadorno committed Feb 3, 2022
    Copy the full SHA
    ebb4283 View commit details
  7. Copy the full SHA
    4d3587b View commit details
  8. docs: changelog for v8.4.1

    ruyadorno committed Feb 3, 2022
    Copy the full SHA
    cde93cb View commit details
  9. update AUTHORS

    ruyadorno committed Feb 3, 2022
    Copy the full SHA
    24c882d View commit details
  10. 8.4.1

    ruyadorno committed Feb 3, 2022
    Copy the full SHA
    e3e8153 View commit details
  11. Copy the full SHA
    892b66e View commit details
  12. chore(deps): bump simple-get from 3.1.0 to 3.1.1

    Bumps [simple-get](https://github.com/feross/simple-get) from 3.1.0 to 3.1.1.
    - [Release notes](https://github.com/feross/simple-get/releases)
    - [Commits](feross/simple-get@v3.1.0...v3.1.1)
    
    ---
    updated-dependencies:
    - dependency-name: simple-get
      dependency-type: indirect
    ...
    
    Signed-off-by: dependabot[bot] <support@github.com>
    dependabot[bot] authored and wraithgar committed Feb 3, 2022
    Copy the full SHA
    415a70b View commit details

Commits on Feb 7, 2022

  1. Copy the full SHA
    2ba09cc View commit details
  2. deps: @npmcli/arborist@4.3.1

    nlf committed Feb 7, 2022
    Copy the full SHA
    8732f39 View commit details
  3. Copy the full SHA
    0cc9d4c View commit details

Commits on Feb 8, 2022

  1. Copy the full SHA
    b836d59 View commit details
  2. fix(log): pass in logger to more external modules

    We missed two commands in the last PR. This should complete the task
    wraithgar committed Feb 8, 2022
    Copy the full SHA
    fb6e2dd View commit details
  3. Copy the full SHA
    e631faf View commit details
  4. Copy the full SHA
    f3fbeea View commit details
  5. Copy the full SHA
    4884821 View commit details
  6. Copy the full SHA
    0e231d4 View commit details
  7. Copy the full SHA
    e2f1f7b View commit details
  8. Copy the full SHA
    2937b43 View commit details
  9. deps: libnpmpack@3.1.0

    nlf committed Feb 8, 2022
    Copy the full SHA
    d3a7c15 View commit details

Commits on Feb 9, 2022

  1. Copy the full SHA
    2786578 View commit details
  2. Copy the full SHA
    ab92699 View commit details
  3. deps: npmlog@6.0.1

    wraithgar committed Feb 9, 2022
    Copy the full SHA
    1c0d069 View commit details

Commits on Feb 10, 2022

  1. Copy the full SHA
    3c33a58 View commit details
  2. docs: changelog for v8.5.0

    nlf committed Feb 10, 2022
    Copy the full SHA
    509ff0e View commit details
  3. update AUTHORS

    nlf committed Feb 10, 2022
    Copy the full SHA
    5769ef4 View commit details
  4. 8.5.0

    nlf committed Feb 10, 2022
    Copy the full SHA
    20a9818 View commit details
Showing 1,182 changed files with 63,657 additions and 46,206 deletions.
13 changes: 13 additions & 0 deletions .eslintrc.js
Original file line number Diff line number Diff line change
@@ -0,0 +1,13 @@
const { readdirSync: readdir } = require('fs')

const localConfigs = readdir(__dirname)
.filter((file) => file.startsWith('.eslintrc.local.'))
.map((file) => `./${file}`)

module.exports = {
root: true,
extends: [
'@npmcli',
...localConfigs,
],
}
15 changes: 0 additions & 15 deletions .eslintrc.json

This file was deleted.

20 changes: 20 additions & 0 deletions .eslintrc.local.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,20 @@
{
"ignorePatterns": [
"docs/",
"workspaces/*"
],
"rules": {
"no-shadow": "off",
"no-console": "error"
},
"overrides": [{
"files": [
"scripts/**",
"bin/**",
"test/**"
],
"rules": {
"no-console": "off"
}
}]
}
32 changes: 32 additions & 0 deletions .github/matchers/tap.json
Original file line number Diff line number Diff line change
@@ -0,0 +1,32 @@
{
"//@npmcli/template-oss": "This file is automatically added by @npmcli/template-oss. Do not edit.",
"problemMatcher": [
{
"owner": "tap",
"pattern": [
{
"regexp": "^\\s*not ok \\d+ - (.*)",
"message": 1
},
{
"regexp": "^\\s*---"
},
{
"regexp": "^\\s*at:"
},
{
"regexp": "^\\s*line:\\s*(\\d+)",
"line": 1
},
{
"regexp": "^\\s*column:\\s*(\\d+)",
"column": 1
},
{
"regexp": "^\\s*file:\\s*(.*)",
"file": 1
}
]
}
]
}
87 changes: 0 additions & 87 deletions .github/workflows/benchmark-comment.yml

This file was deleted.

105 changes: 66 additions & 39 deletions .github/workflows/benchmark.yml
Original file line number Diff line number Diff line change
@@ -1,52 +1,79 @@
---
name: Benchmark Suite
name: Benchmark - CLI

on:
pull_request:
branches:
- "**"
- '*'
paths:
- lib/**
issue_comment:
types:
- created
- edited

jobs:
build:
name: Trigger Benchmarks

trigger-benchmark:
runs-on: ubuntu-latest

steps:
- name: Handle Incoming Pull-Request
- name: Incoming Pull Request
if: |
github.event_name == 'pull_request' || (
github.event_name == 'issue_comment' &&
github.event.issue.pull_request &&
github.event.issue.state == 'open' &&
startsWith(github.event.comment.body, '@npm-cli-bot benchmark this')
)
env:
DISPATCH_REPO: "benchmarks"
DISPATCH_OWNER: "npm"
EVENT_NAME: ${{ github.event_name }}
REPO: ${{ github.event.repository.name }}
PR_NUMBER: ${{ github.event.pull_request.number }}
PR_OWNER: ${{ github.event.pull_request.head.repo.owner.login }}
AUTH_TOKEN: ${{ secrets.NPM_BENCHMARKS_TOKEN }}
# gh cli uses these env vars for owner/repo/token
GH_REPO: "npm/benchmarks"
GITHUB_TOKEN: ${{ secrets.BENCHMARK_DISPATCH_TOKEN }}
run: |
# Dispatch Handler
dispatch_request () {
echo "Dispatching request..."
curl \
-s \
-X POST https://api.github.com/repos/${DISPATCH_OWNER}/${DISPATCH_REPO}/dispatches \
-H "Accept: application/vnd.github.v3+json" \
-H "Authorization: token ${AUTH_TOKEN}" \
-d \
'
{
"event_type": "'"${EVENT_NAME} ${PR_OWNER}/${REPO}#${PR_NUMBER}"'",
"client_payload": {
"pr_id": "'"${PR_NUMBER}"'",
"repo": "'"${REPO}"'",
"owner": "'"${PR_OWNER}"'"
}
}'
}
EVENT_NAME="${{ github.event_name }}"
OWNER="${{ github.event.repository.owner.login }}"
REPO="${{ github.event.repository.name }}"
PR=""
if [ "${AUTH_TOKEN}" != "" ]; then
# Dispatch request for benchmarks
dispatch_request
if [[ "$EVENT_NAME" == "pull_request" ]]; then
if [[ "$GITHUB_TOKEN" == "" ]]; then
echo "No auth - from fork pull request, exiting"
exit 0
fi
PR="${{ github.event.pull_request.number }}"
else
echo "NO AUTH - FORK PULL REQUEST"
PR="${{ github.event.issue.number }}"
SENDER="${{ github.event.comment.user.login }}"
ROLE=$(gh api repos/${OWNER}/${REPO}/collaborators/${SENDER}/permission -q '.permission')
if [[ "$ROLE" != "admin" ]]; then
echo "${SENDER} is ${ROLE}, not an admin, exiting"
exit 0
fi
# add emoji to comment if user is an admin to signal
# benchmark is running
COMMENT_NODE_ID="${{ github.event.comment.node_id }}"
QUERY='mutation ($inputData:AddReactionInput!) {
addReaction (input:$inputData) {
reaction { content }
}
}'
echo '{
"query": "'${QUERY}'",
"variables": {
"inputData": {
"subjectId": "'"${COMMENT_NODE_ID}"'",
"content": "ROCKET"
}
}
}' | gh api graphql --input -
fi
EVENT="${EVENT_NAME} ${OWNER}/${REPO}#${PR}"
echo '{
"event_type": "'"$EVENT"'",
"client_payload": {
"pr_id": "'"$PR"'",
"repo": "'"$REPO"'",
"owner": "'"$OWNER"'"
}
}' | gh api repos/{owner}/{repo}/dispatches --input -
Loading