Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/remark-preset-lint-node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: b46f9672e2ad9af9870f6943ff1168646cea2ebb
Choose a base ref
...
head repository: nodejs/remark-preset-lint-node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 0e10afefe68651b63dcc087ebc5f679ea3503eaf
Choose a head ref
6 contributors
Loading
Showing with 5,007 additions and 864 deletions.
  1. +2 −0 .gitattributes
  2. +13 −11 .github/workflows/test.yml
  3. +1 −1 README.md
  4. +3 −1 index.js
  5. +4,934 −811 package-lock.json
  6. +39 −39 package.json
  7. +3 −0 test/fixtures/fail-nodejs-yaml-comments.md
  8. 0 test/fixtures/{fail.md → fail-prohibited-string.md}
  9. +12 −1 test/test.js
2 changes: 2 additions & 0 deletions .gitattributes
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,2 @@
# Enforce Unix newlines
* text=auto eol=lf
24 changes: 13 additions & 11 deletions .github/workflows/test.yml
View file
Original file line number Diff line number Diff line change
@@ -7,34 +7,36 @@ on:
pull_request:

env:
CI: true
NODE: 12.x
FORCE_COLOR: 2

jobs:
test:
name: Node ${{ matrix.node }}
runs-on: ubuntu-latest

strategy:
fail-fast: false
matrix:
node: [12, 14, 16]

steps:
- name: Clone repository
uses: actions/checkout@v2.3.4
uses: actions/checkout@v2

- name: Clone nodejs/node repository
uses: actions/checkout@v2.3.4
uses: actions/checkout@v2
with:
repository: nodejs/node
path: tmp

- name: Set up Node.js
uses: actions/setup-node@v2.4.1
uses: actions/setup-node@v2
with:
node-version: "${{ env.NODE }}"
cache: "npm"

- run: node --version
- run: npm --version
node-version: ${{ matrix.node }}
cache: npm

- name: Install npm dependencies
run: npm ci

- name: Run tests
run: npm run test
run: npm test
2 changes: 1 addition & 1 deletion README.md
View file
Original file line number Diff line number Diff line change
@@ -22,7 +22,7 @@ npm test

1. PR the [nodejs/node](https://github.com/nodejs/node) repo adding the
language/grammar to the
[documentation style guide](https://github.com/nodejs/node/blob/master/doc/guides/doc-style-guide.md).
[documentation style guide](https://github.com/nodejs/node/blob/HEAD/doc/README.md).

### Adding the language to the linter

4 changes: 3 additions & 1 deletion index.js
View file
Original file line number Diff line number Diff line change
@@ -1,4 +1,4 @@
// @see https://github.com/nodejs/node/blob/HEAD/doc/guides/doc-style-guide.md
// @see https://github.com/nodejs/node/blob/HEAD/doc/README.md

import remarkGfm from "remark-gfm";
import remarkPresetLintRecommended from "remark-preset-lint-recommended";
@@ -62,6 +62,7 @@ const plugins = [
"powershell",
"r",
"text",
"ts",
],
},
],
@@ -100,6 +101,7 @@ const plugins = [
{ yes: "RFC" },
{ no: "[Rr][Ff][Cc]\\d+", yes: "RFC <number>" },
{ yes: "Unix" },
{ yes: "Valgrind" },
{ yes: "V8" },
],
],
Loading