Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/remark-preset-lint-node
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 050fc152091e1215c79d392b0f3e772f786cbb18
Choose a base ref
...
head repository: nodejs/remark-preset-lint-node
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 76e7b96835dbc90193b44868912e85da85ad1104
Choose a head ref

Commits on Nov 30, 2018

  1. update meta info

    watilde committed Nov 30, 2018
    Copy the full SHA
    a748f16 View commit details
  2. Copy the full SHA
    c75948a View commit details
  3. Merge pull request #11 from watilde/feature/update-meta

    Update docs, meta info and add lint
    watilde authored Nov 30, 2018
    Copy the full SHA
    be0e4d0 View commit details

Commits on Feb 22, 2019

  1. Copy the full SHA
    510655f View commit details

Commits on Feb 23, 2019

  1. 1.4.0

    Trott committed Feb 23, 2019
    Copy the full SHA
    c5df944 View commit details

Commits on Mar 4, 2019

  1. add End-of-life to prohibited strings

    Add another variant of `End-of-Life`.
    richardlau authored and BridgeAR committed Mar 4, 2019
    Copy the full SHA
    8dc7202 View commit details
  2. 1.5.0

    Trott committed Mar 4, 2019
    Copy the full SHA
    56f53e2 View commit details

Commits on Mar 18, 2019

  1. update remark-lint-prohibited-strings to version 1.1.0

    remark-lint-prohibited-strings provides better messages for regexp-y
    things, which will come in handy for #15
    Trott committed Mar 18, 2019
    Copy the full SHA
    f6b7db8 View commit details
  2. Normalize on RFC <number> (#15)

    * add rfc to prohibited strings
    
    * prohibit RFC<number>/rfc<number>
    
    Enforce a space between `RFC` and the number.
    richardlau authored and Trott committed Mar 18, 2019
    Copy the full SHA
    782a2cc View commit details
  3. 1.6.0

    Trott committed Mar 18, 2019
    Copy the full SHA
    171bf39 View commit details

Commits on May 17, 2019

  1. Copy the full SHA
    8b3edbe View commit details
  2. 1.6.1

    Trott committed May 17, 2019
    Copy the full SHA
    38f694f View commit details

Commits on Jun 23, 2019

  1. Copy the full SHA
    24492f1 View commit details
  2. 1.7.0

    Trott committed Jun 23, 2019
    Copy the full SHA
    a95cf31 View commit details

Commits on Jul 10, 2019

  1. Copy the full SHA
    6b65672 View commit details
  2. 1.8.0

    Trott committed Jul 10, 2019
    Copy the full SHA
    91b7789 View commit details

Commits on Sep 5, 2019

  1. feat: add remark-lint-no-consecutive-blank-lines (#18)

    * feat: add remark-lint-no-consecutive-blank-lines
    
    * chore: sort rule loading
    nschonni authored and Trott committed Sep 5, 2019
    Copy the full SHA
    86bcc3e View commit details
  2. 1.9.0

    Trott committed Sep 5, 2019
    Copy the full SHA
    e5fd1c0 View commit details

Commits on Sep 7, 2019

  1. Add Travis-CI setup (#20)

    * feat: Run Travis-CI to test rule changes
    
    * chore: npm upgrade for first-heading-level warning
    
    * chore: Add Travis-CI badge
    
    Minor readme formatting
    nschonni authored and Trott committed Sep 7, 2019
    Copy the full SHA
    fb48277 View commit details

Commits on Sep 17, 2019

  1. feat: add remark-lint-unordered-list-marker-style (#22)

    Node was normalized in nodejs/node@e2dcbf1
    nschonni authored and Trott committed Sep 17, 2019
    Copy the full SHA
    d733a7f View commit details
  2. 1.10.0

    Trott committed Sep 17, 2019
    Copy the full SHA
    10ba741 View commit details

Commits on Sep 20, 2019

  1. Remove test submodule. (#25)

    XhmikosR authored and Trott committed Sep 20, 2019
    Copy the full SHA
    a489275 View commit details
  2. Travis CI: specify depth 1 when cloning the Node.js repo. (#23)

    This should speed things up.
    XhmikosR authored and Trott committed Sep 20, 2019
    Copy the full SHA
    90bd515 View commit details

Commits on Sep 28, 2019

  1. Switch to GitHub Actions CI. (#24)

    XhmikosR authored and Trott committed Sep 28, 2019
    Copy the full SHA
    a1f082c View commit details

Commits on Oct 9, 2019

  1. Copy the full SHA
    2784527 View commit details
  2. Regenerate package-lock.json. (#29)

    Flattens the deps tree.
    XhmikosR authored and Trott committed Oct 9, 2019
    Copy the full SHA
    83cd6aa View commit details
  3. Copy the full SHA
    f3d3ff5 View commit details
  4. CI: move CI env variable to the root of the workflow. (#27)

    This way we match the Travis CI behavior, and it's inherited by all steps.
    XhmikosR authored and Trott committed Oct 9, 2019
    Copy the full SHA
    d5cf71f View commit details

Commits on Oct 12, 2019

  1. Use and extend remark-preset-lint-recommended (#21)

    * fix: Disable rules that don't pass from the preset
    
    * feat: Use remark-preset-lint-recommended
    
    * chore: remove rules overlapping preset
    nschonni authored and Trott committed Oct 12, 2019
    Copy the full SHA
    f24b17e View commit details

Commits on Oct 14, 2019

  1. chore: remove duplicated dependiences (#30)

    This are coming from remark-preset-lint-recommended now
    nschonni authored and Trott committed Oct 14, 2019
    2
    Copy the full SHA
    4f662e3 View commit details
  2. 1.10.1-0

    Trott committed Oct 14, 2019
    Copy the full SHA
    d950b79 View commit details
  3. Copy the full SHA
    4bac2ef View commit details
  4. 1.10.1

    Trott committed Oct 14, 2019
    Copy the full SHA
    9eb7383 View commit details
  5. feat: Flag lowercase node.js (#32)

    nschonni authored and Trott committed Oct 14, 2019
    Copy the full SHA
    7722c10 View commit details

Commits on Oct 15, 2019

  1. feat: flag lowercase JavaScript (#33)

    nschonni authored and Trott committed Oct 15, 2019
    Copy the full SHA
    31f2242 View commit details

Commits on Oct 16, 2019

  1. chore: Expand CI test globs (#34)

    Fixes #31
    nschonni authored and Trott committed Oct 16, 2019
    Copy the full SHA
    7e357aa View commit details

Commits on Dec 4, 2019

  1. Copy the full SHA
    d1c80fe View commit details
  2. 1.11.0

    Trott committed Dec 4, 2019
    Copy the full SHA
    6aaf40e View commit details

Commits on Dec 13, 2019

  1. CI: switch to actions/checkout@v2 (#36)

    XhmikosR authored and Trott committed Dec 13, 2019
    Copy the full SHA
    81778d7 View commit details

Commits on Jan 14, 2020

  1. Copy the full SHA
    95e39bb View commit details
  2. 1.12.0

    Trott committed Jan 14, 2020
    Copy the full SHA
    68e3bc4 View commit details

Commits on Jan 16, 2020

  1. Update test.yml (#38)

    * use actions/checkout to clone the node repo
    * add an env variable for the Node.js version we use
    XhmikosR authored and Trott committed Jan 16, 2020
    Copy the full SHA
    c80e558 View commit details
  2. Add lockfile-lint (#40)

    * Update devDependencies
    
    * Add lockfile-lint
    XhmikosR authored and Trott committed Jan 16, 2020
    Copy the full SHA
    4851bf4 View commit details

Commits on Feb 19, 2020

  1. feat: prohibit possessive form of Node.js (#41)

    * chore: update remark-lint-prohibited-strings@1.2.1
    
    1.2.1 includes a fix necessary to make checking for possessive forms of
    Node.js easier.
    
    * feat: prohibit possessive form of Node.js
    
    Instead of "Node.js's internal module system", use "the Node.js internal
    module system:.
    Trott authored Feb 19, 2020
    Copy the full SHA
    e09c468 View commit details
  2. 1.13.0

    Trott committed Feb 19, 2020
    Copy the full SHA
    b7b2404 View commit details

Commits on Mar 17, 2020

  1. Bump minimist from 1.2.0 to 1.2.5 (#42)

    Bumps [minimist](https://github.com/substack/minimist) from 1.2.0 to 1.2.5.
    - [Release notes](https://github.com/substack/minimist/releases)
    - [Commits](https://github.com/substack/minimist/compare/1.2.0...1.2.5)
    
    Signed-off-by: dependabot[bot] <support@github.com>
    
    Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
    dependabot[bot] authored Mar 17, 2020
    Copy the full SHA
    62103cd View commit details

Commits on Mar 25, 2020

  1. Bump prettier from 1.19.1 to 2.0.2

    Bumps [prettier](https://github.com/prettier/prettier) from 1.19.1 to 2.0.2.
    - [Release notes](https://github.com/prettier/prettier/releases)
    - [Changelog](https://github.com/prettier/prettier/blob/master/CHANGELOG.md)
    - [Commits](prettier/prettier@1.19.1...2.0.2)
    
    Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
    dependabot-preview[bot] authored and nschonni committed Mar 25, 2020
    Copy the full SHA
    ae768ef View commit details

Commits on Mar 27, 2020

  1. Bump remark-preset-lint-recommended from 3.0.3 to 3.0.4

    Bumps [remark-preset-lint-recommended](https://github.com/remarkjs/remark-lint) from 3.0.3 to 3.0.4.
    - [Release notes](https://github.com/remarkjs/remark-lint/releases)
    - [Changelog](https://github.com/remarkjs/remark-lint/blob/master/changelog.md)
    - [Commits](https://github.com/remarkjs/remark-lint/commits)
    
    Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
    dependabot-preview[bot] authored and nschonni committed Mar 27, 2020
    Copy the full SHA
    828870f View commit details
  2. Bump remark-lint-rule-style from 1.0.3 to 1.0.4

    Bumps [remark-lint-rule-style](https://github.com/remarkjs/remark-lint) from 1.0.3 to 1.0.4.
    - [Release notes](https://github.com/remarkjs/remark-lint/releases)
    - [Changelog](https://github.com/remarkjs/remark-lint/blob/master/changelog.md)
    - [Commits](https://github.com/remarkjs/remark-lint/commits/ordered-list-marker-value@1.0.4)
    
    Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
    dependabot-preview[bot] authored and nschonni committed Mar 27, 2020
    Copy the full SHA
    30e23f4 View commit details
  3. Bump remark-lint-checkbox-character-style from 1.0.3 to 1.0.4

    Bumps [remark-lint-checkbox-character-style](https://github.com/remarkjs/remark-lint) from 1.0.3 to 1.0.4.
    - [Release notes](https://github.com/remarkjs/remark-lint/releases)
    - [Changelog](https://github.com/remarkjs/remark-lint/blob/master/changelog.md)
    - [Commits](https://github.com/remarkjs/remark-lint/commits/ordered-list-marker-value@1.0.4)
    
    Signed-off-by: dependabot-preview[bot] <support@dependabot.com>
    dependabot-preview[bot] authored and nschonni committed Mar 27, 2020
    Copy the full SHA
    cda4dec View commit details
Showing with 1,868 additions and 303 deletions.
  1. +33 −0 .github/workflows/test.yml
  2. +3 −0 .gitignore
  3. +15 −0 README.md
  4. +50 −49 index.js
  5. +1,716 −210 package-lock.json
  6. +51 −44 package.json
33 changes: 33 additions & 0 deletions .github/workflows/test.yml
Original file line number Diff line number Diff line change
@@ -0,0 +1,33 @@
name: Tests
on: [push, pull_request]
env:
CI: true
NODE: 12.x

jobs:
test:
runs-on: ubuntu-latest

steps:
- name: Clone repository
uses: actions/checkout@v2

- name: Clone nodejs/node repository
uses: actions/checkout@v2
with:
repository: nodejs/node
path: tmp

- name: Set up Node.js
uses: actions/setup-node@v1
with:
node-version: "${{ env.NODE }}"

- run: node --version
- run: npm --version

- name: Install npm dependencies
run: npm ci

- name: Run tests
run: npm run test-ci
3 changes: 3 additions & 0 deletions .gitignore
Original file line number Diff line number Diff line change
@@ -35,3 +35,6 @@ jspm_packages

# Optional REPL history
.node_repl_history

# Cloned nodejs/node for testing
tmp/
15 changes: 15 additions & 0 deletions README.md
Original file line number Diff line number Diff line change
@@ -1,2 +1,17 @@
# remark-preset-lint-node

[![Build Status](https://github.com/nodejs/remark-preset-lint-node/workflows/Tests/badge.svg)](https://github.com/nodejs/remark-preset-lint-node/actions?workflow=Tests)

remark preset to configure remark-lint with settings for nodejs/node

## Install

```console
npm install remark-preset-lint-node
```

## Test

```console
npm test
```
99 changes: 50 additions & 49 deletions index.js
Original file line number Diff line number Diff line change
@@ -1,60 +1,61 @@
// @see https://github.com/nodejs/node/blob/master/doc/STYLE_GUIDE.md

'use strict';
"use strict";

// Add in rules alphabetically
module.exports.plugins = [
require('remark-lint'),
require('remark-lint-checkbox-content-indent'),
require('remark-lint-definition-spacing'),
require('remark-lint-fenced-code-flag'),
require('remark-lint-final-definition'),
require('remark-lint-final-newline'),
require('remark-lint-hard-break-spaces'),
require('remark-lint-hard-break-spaces'),
require("remark-lint"),
// Leave preset at the top so it can be overridden
require("remark-preset-lint-recommended"),
[require("remark-lint-blockquote-indentation"), 2],
[
require('remark-lint-list-item-indent'),
'space'
],
require('remark-lint-maximum-line-length'),
require('remark-lint-no-auto-link-without-protocol'),
require('remark-lint-no-blockquote-without-marker'),
require('remark-lint-no-duplicate-definitions'),
require('remark-lint-no-file-name-articles'),
require('remark-lint-no-file-name-consecutive-dashes'),
require('remark-lint-no-file-name-outer-dashes'),
require('remark-lint-no-heading-content-indent'),
require('remark-lint-no-heading-indent'),
require('remark-lint-no-inline-padding'),
require('remark-lint-no-multiple-toplevel-headings'),
require('remark-lint-no-shell-dollars'),
require('remark-lint-no-shortcut-reference-image'),
require('remark-lint-no-table-indentation'),
require('remark-lint-no-tabs'),
require('remark-lint-no-trailing-spaces'),
require('remark-lint-no-unused-definitions'),
require('remark-lint-rule-style'),
require('remark-lint-table-pipes'),
[require('remark-lint-blockquote-indentation'), 2],
[
require('remark-lint-checkbox-character-style'),
require("remark-lint-checkbox-character-style"),
{
'checked': 'x', 'unchecked': ' '
}
checked: "x",
unchecked: " ",
},
],
[require('remark-lint-code-block-style'), 'fenced'],
[require('remark-lint-fenced-code-marker'), '`'],
[require('remark-lint-file-extension'), 'md'],
[require('remark-lint-first-heading-level'), 1],
[require('remark-lint-heading-style'), 'atx'],
require("remark-lint-checkbox-content-indent"),
[require("remark-lint-code-block-style"), "fenced"],
require("remark-lint-definition-spacing"),
require("remark-lint-fenced-code-flag"),
[require("remark-lint-fenced-code-marker"), "`"],
[require("remark-lint-file-extension"), "md"],
require("remark-lint-final-definition"),
[require("remark-lint-first-heading-level"), 1],
[require("remark-lint-heading-style"), "atx"],
[require("remark-lint-list-item-indent"), "space"],
require("remark-lint-maximum-line-length"),
require("remark-lint-no-consecutive-blank-lines"),
require("remark-lint-no-file-name-articles"),
require("remark-lint-no-file-name-consecutive-dashes"),
require("remark-lint-no-file-name-outer-dashes"),
require("remark-lint-no-heading-indent"),
require("remark-lint-no-multiple-toplevel-headings"),
require("remark-lint-no-shell-dollars"),
require("remark-lint-no-table-indentation"),
require("remark-lint-no-tabs"),
require("remark-lint-no-trailing-spaces"),
[
require('remark-lint-prohibited-strings'),
require("remark-lint-prohibited-strings"),
[
{ no: 'Github', yes: 'GitHub' },
{ no: 'Javascript', yes: 'JavaScript' },
{ no: 'Node.JS', yes: 'Node.js' },
{ no: 'v8', yes: 'V8' }
]
{ yes: "End-of-Life" },
{ yes: "GitHub" },
{ no: "hostname", yes: "host name" },
{ yes: "JavaScript" },
{ no: "Node", yes: "Node.js" },
{ yes: "Node.js" },
{ no: "Node\\.js's?", yes: "the Node.js" },
{ no: "[Nn]ote that", yes: "<nothing>" },
{ yes: "RFC" },
{ no: "[Rr][Ff][Cc]\\d+", yes: "RFC <number>" },
{ yes: "Unix" },
{ yes: "V8" },
],
],
[require('remark-lint-strong-marker'), '*'],
[require('remark-lint-table-cell-padding'), 'padded']
require("remark-lint-rule-style"),
[require("remark-lint-strong-marker"), "*"],
[require("remark-lint-table-cell-padding"), "padded"],
require("remark-lint-table-pipes"),
[require("remark-lint-unordered-list-marker-style"), "*"],
];
Loading