Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-gyp
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 4793e1dcb8f16182d6292fd2af579082fc11294f
Choose a base ref
...
head repository: nodejs/node-gyp
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 41f2b236a0f93adaa6ac4205620157633c07c062
Choose a head ref
36 contributors

Commits on Jan 17, 2017

  1. Update link of gyp as Google code is shutting down 

    PR-URL: #1061
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    @PeterDaveHello @bnoordhuis
    PeterDaveHello authored and bnoordhuis committed Jan 17, 2017
    Copy the full SHA
    ff9a6fa View commit details

Commits on Feb 15, 2017

  1. Upgrade semver dependency. 

    Should fix reports of "TypeError: Cannot read property 'length' of
undefined" runtime exceptions where node-gyp uses a buggy version
of semver due to our overly broad accepted version range.

npm updated to semver@5.3.0 recently so we can too now and still
share the module with npm, keeping the download small.

Fixes: #1094
PR-URL: #1107
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    @bnoordhuis
    bnoordhuis committed Feb 15, 2017
    Copy the full SHA
    93d7fa8 View commit details

  2. Add support to build node.js with chakracore. 

    Microsoft's chakracore engine is dependent on Windows SDK, and build
tools should know the version installed on user machine. This change
adds those dependencies in node-gyp tools. Below is the summary:

* Configure msvs_windows_target_platform_version to use the right
  Windows SDK.

* Configure msvs_use_library_dependency_inputs to export symbols
  correctly (otherwise functions not used by node.exe but might be
  needed by native addon modules could be optimized away by linker).

These changes were originally made in nodejs/node#4765, but as @shigeki
mentioned, it was more sensible to send these changes as PR to node-gyp
repo.

PR-URL: #873
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @kunalspathak @bnoordhuis
    kunalspathak authored and bnoordhuis committed Feb 15, 2017
    2
    Copy the full SHA
    a04ea30 View commit details

  3. Add support to build node.js with chakracore for ARM. 

    * Support building node.js with chakracore on Windows on ARM

* Building chakracore for ARM has a dependency on Windows SDK installed
  on the machine. Update python script to populate
  `WindowsSDKDesktopARMSupport` and `WindowsTargetPlatformVersion` for
  ARM builds. This will be using in node repo to build`chakracore.gyp`.

PR-URL: #873
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @kunalspathak @bnoordhuis
    kunalspathak authored and bnoordhuis committed Feb 15, 2017
    Copy the full SHA
    ec5fc36 View commit details

Commits on Mar 15, 2017

  1. win: find and setup for VS2017 

    PR-URL: #1130
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rod Vagg <rod@vagg.org>
    @refack @joaocgreis
    refack authored and joaocgreis committed Mar 15, 2017
    Copy the full SHA
    ae141e1 View commit details

  2. 3.6.0

    @rvagg
    rvagg committed Mar 15, 2017
    Copy the full SHA
    8d04acf View commit details

  3. doc: update changelog for v3.6.0

    @rvagg
    rvagg committed Mar 15, 2017
    Copy the full SHA
    761c7cb View commit details

Commits on Mar 20, 2017

  1. Delete superfluous .patch files. 

    The patch files are unnecessary, they also exist as commits in the
history.  Delete the files.

PR-URL: #1122
Reviewed-By: João Reis <reis@janeasystems.com>
    @bnoordhuis
    bnoordhuis committed Mar 20, 2017
    Copy the full SHA
    da9cb5f View commit details

Commits on Apr 23, 2017

  1. doc: add a note for using configure on Windows 

    PR-URL: #1152
Fixes: #1149
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    @vsemozhetbyt @gibfahn
    vsemozhetbyt authored and gibfahn committed Apr 23, 2017
    Copy the full SHA
    c09cf76 View commit details

  2. gyp: Revert quote_cmd workaround 

    PR-URL: #1153
Fixes: #1151
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
    @kunalspathak @gibfahn
    kunalspathak authored and gibfahn committed Apr 23, 2017
    Copy the full SHA
    8a76714 View commit details

Commits on Apr 25, 2017

  1. test: fix test/test-configure-python on AIX 

    On AIX, lib/configure.js attempts to locate node.exp via calls to
fs.openSync() and fs.closeSync(). Add these functions to the mocked
`graceful-fs` object in test/test-configure-python.js.

PR-URL: #1131
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    @richardlau @gibfahn
    richardlau authored and gibfahn committed Apr 25, 2017
    Copy the full SHA
    a83a380 View commit details

  2. test: fix test-find-python on v0.10.x buildbot. 

    Work around a v0.10.x CI issue where path.resolve() on UNIX systems
prefixes Windows paths with the current working directory.

v0.12 and up are free of this issue because they use
path.win32.resolve() which does the right thing.

PR-URL: #1172
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @bnoordhuis @gibfahn
    bnoordhuis authored and gibfahn committed Apr 25, 2017
    Copy the full SHA
    4980171 View commit details

Commits on Apr 30, 2017

  1. 3.6.1

    @rvagg
    rvagg committed Apr 30, 2017
    Copy the full SHA
    ce815f9 View commit details

Commits on May 14, 2017

  1. doc: blorb about setting npm_config_OPTION_NAME 

    PR-URL: #1185
Fixes: #1180
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @refack @gibfahn
    refack authored and gibfahn committed May 14, 2017
    Copy the full SHA
    c307b30 View commit details

Commits on May 15, 2017

  1. build, win: use target_arch to link with node.lib 

    Using `target_arch` in addon.gypi to link against Node.js library. This
variable was written into build/config.gypi on the `configure` stage.

Do not copy node.lib into node_root_dir/Release or node_root_dir/Debug
on Windows, link it from node_root_dir/target_arch directory.

PR-URL: #964
Reviewed-By: João Reis <reis@janeasystems.com>
    @pmed @joaocgreis
    pmed authored and joaocgreis committed May 15, 2017
    Copy the full SHA
    0913b2d View commit details

  2. configure: use full path in node_lib_file GYP var 

    Set path to node lib in `$(Configuration)` dir when `--nodedir` option
is supplied, otherwise use value of `target_arch` variable.

PR-URL: #964
Reviewed-By: João Reis <reis@janeasystems.com>
    @pmed @joaocgreis
    pmed authored and joaocgreis committed May 15, 2017
    Copy the full SHA
    386746c View commit details

Commits on May 17, 2017

  1. Log dist-url. 

    The default download URL can be overridden by `--dist-url` or one of the
`*_MIRROR` environment variables.  Log the URL to ease troubleshooting.

Fixes: #1169
PR-URL: #1170
Reviewed-By: Refael Ackermann <refack@gmail.com>
    @bnoordhuis
    bnoordhuis committed May 17, 2017
    Copy the full SHA
    241752f View commit details

  2. win: more robust parsing of SDK version 

    PR-URL: #1198
Fixes: #1179
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: João Reis <reis@janeasystems.com>
    @refack
    refack committed May 17, 2017
    Copy the full SHA
    bad903a View commit details

Commits on May 27, 2017

  1. build: rename copyNodeLib() to doBuild() 

    PR-URL: #1206
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    @lc-soft @refack
    lc-soft authored and refack committed May 27, 2017
    Copy the full SHA
    72afdd6 View commit details

Commits on Jun 1, 2017

  1. 3.6.2

    @rvagg
    rvagg committed Jun 1, 2017
    Copy the full SHA
    b5b52f7 View commit details

Commits on Oct 10, 2017

  1. deps: pin request version range 

    Required for "node < 4" compatibility and is congruent with `npm`

minimum for passing `npm test` >= 2.9.0
setting < 2.82.0 allows deduping

PR-URL: #1300
Fixes: #1299
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @refack
    refack committed Oct 10, 2017
    Copy the full SHA
    7900122 View commit details

Commits on Jun 8, 2018

  1. gyp: fix regex to match multi-digit versions 

    This fixes the regular expression matching in `xcode_emulation`
to also handle version numbers with multiple-digit major versions
which would otherwise break under use of XCode 10

Fixes: #1454
PR-URL: #1455
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @jhermsmeier @bnoordhuis
    jhermsmeier authored and bnoordhuis committed Jun 8, 2018
    Copy the full SHA
    40f24e4 View commit details

  2. 3.6.3

    @bnoordhuis
    bnoordhuis committed Jun 8, 2018
    Copy the full SHA
    4c38707 View commit details

  3. configure: don't set ensure if tarball is set 

    If you're providing a path to a header tarball to install, you probably
want it to always be re-installed.

PR-URL: #1220
Fixes: #1216
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Refael Ackermann <refack@gmail.com>
    @gibfahn @bnoordhuis
    gibfahn authored and bnoordhuis committed Jun 8, 2018
    Copy the full SHA
    0a07e48 View commit details

  4. gyp: update xml string encoding conversion 

    * test: build simple addon in path with non-ascii characters
* test: add test-charmap.py

PR-URL: #1203
Reviewed-By: Refael Ackermann <refack@gmail.com>
    @lc-soft @bnoordhuis
    lc-soft authored and bnoordhuis committed Jun 8, 2018
    Copy the full SHA
    f275991 View commit details

  5. doc: headerify the Install instructions 

    Enable linking to the platform specific installation instructions

PR-URL: #1225
Reviewed-By: Refael Ackermann <refack@gmail.com>
    @nschonni @bnoordhuis
    nschonni authored and bnoordhuis committed Jun 8, 2018
    Copy the full SHA
    7e803d5 View commit details

  6. doc: update proposed DCO and CoC 

    Lifted verbatim from
https://github.com/nodejs/node/blob/master/CONTRIBUTING.md
then `s/Node.js/node-gyp/`.

PR-URL: #1229
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    @mikeal @bnoordhuis
    mikeal authored and bnoordhuis committed Jun 8, 2018
    Copy the full SHA
    a46a770 View commit details

  7. doc: add github PR and Issue templates 

    Give users reporting bugs a clearer idea of the info that will be
helpful when reporting issues.

PR-URL: #1228
Refs: https://github.com/nodejs/node/tree/master/.github
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @gibfahn @bnoordhuis
    gibfahn authored and bnoordhuis committed Jun 8, 2018
    Copy the full SHA
    2da5f86 View commit details

  8. win: run PS with -NoProfile 

    PR-URL: #1292
Refs: #1195 (comment)
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @refack @bnoordhuis
    refack authored and bnoordhuis committed Jun 8, 2018
    Copy the full SHA
    90d8651 View commit details

  9. zos: support platform 

    Initial work to add z/OS support to node-gyp.


PR-URL: #1276
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @jBarz @bnoordhuis
    jBarz authored and bnoordhuis committed Jun 8, 2018
    Copy the full SHA
    b2024de View commit details

  10. Fix IndexError when parsing GYP files. 

    GYP automatically turns variables ending in _dir, _file or _path into
absolute paths but didn't check for empty strings.

It interacted badly with variables inherited through the environment
from npm, the `scripts-prepend-node-path=false` setting in particular
because it is turned into `npm_config_script_prepend_node_path=`.

Fixes: #1217
PR-URL: #1267
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
    @bnoordhuis
    bnoordhuis committed Jun 8, 2018
    Copy the full SHA
    47496bf View commit details

  11. Update README with another way to install on windows 

    PR-URL: #1352
    @JeffAtDeere @bnoordhuis
    JeffAtDeere authored and bnoordhuis committed Jun 8, 2018
    Copy the full SHA
    a613603 View commit details

  12. Update --nodedir description in README. 

    The description erroneously stated that it should point the node binary.
It needs to point to the node source code.

PR-URL: #1372
Reviewed-By: Joyee Cheung <joyeec9h3@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    @bnoordhuis
    bnoordhuis committed Jun 8, 2018
    Copy the full SHA
    2580b91 View commit details

  13. Fix infinite install loop. 

    Retry the download+install dance only once after encountering an EACCES.

That only happens when both the devdir (usually: `$HOME/.node-gyp`) and
the current working directory aren't writable.  Users won't often hit
that except through `sudo npm install` because npm drops privileges
before executing node-gyp.

Fixes: #1383
PR-URL: #1384
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    @bnoordhuis
    bnoordhuis committed Jun 8, 2018
    Copy the full SHA
    6f1286f View commit details

  14. gyp: don't print xcodebuild not found errors 

    As node-gyp rebuild doesn't seem to need xcodebuild, we don't need to be
printing the error every time GYP is run.

PR-URL: #1370
Fixes: #569
Refs: #1057
Refs: https://chromium-review.googlesource.com/c/492046/
    @gibfahn @bnoordhuis
    gibfahn authored and bnoordhuis committed Jun 8, 2018
    Copy the full SHA
    9425448 View commit details

  15. doc: update macOS information in README 

    PR-URL: #1323
Fixes: #1295
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    @josh- @bnoordhuis
    josh- authored and bnoordhuis committed Jun 8, 2018
    Copy the full SHA
    79febac View commit details

  16. zos: add search locations for libnode.x 

    Node.js on z/OS uses shared dll (libnode.so). When linking native
addons, node-gyp needs to find the corresponding libnode.x during
the link step.

PR-URL: #1451
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Refael Ackermann <refack@gmail.com>
    @jBarz @bnoordhuis
    jBarz authored and bnoordhuis committed Jun 8, 2018
    Copy the full SHA
    e5a6901 View commit details

  17. zos: don't use universal-new-lines mode 

    PR-URL: #1451
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Refael Ackermann <refack@gmail.com>
    @jBarz @bnoordhuis
    jBarz authored and bnoordhuis committed Jun 8, 2018
    Copy the full SHA
    dd8561e View commit details

  18. gyp: add support for .mm files to msvs generator 

    PR-URL: #1167
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @jracle @bnoordhuis
    jracle authored and bnoordhuis committed Jun 8, 2018
    Copy the full SHA
    53a5f8f View commit details

  19. Prefix build targets with /t: on Windows 

    Currently, on non-Windows platforms, it is possible to have
a multi-target native module and specify building just some
of the targets using `node-gyp build my_target`.

On Windows, however, specifying the targets to build requires the `/t:`
or `/target:` flag. Without this change you will get an `MSB1008` error
because MSBuild thinks you are trying to specify multiple solutions.

PR-URL: #1164
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @NatalieWolfe @bnoordhuis
    NatalieWolfe authored and bnoordhuis committed Jun 8, 2018
    Copy the full SHA
    53d8cb9 View commit details

  20. Fix include path when pointing to Node.js source 

    Header files for deps are in a different location in the Node.js
source tree compared to the release tarballs.

PR-URL: #1055
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @richardlau @bnoordhuis
    richardlau authored and bnoordhuis committed Jun 8, 2018
    Copy the full SHA
    1e203c5 View commit details

  21. Drop dependency on minimatch. 

    PR-URL: #1158
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Refael Ackermann <refack@gmail.com>
    @doowb @bnoordhuis
    doowb authored and bnoordhuis committed Jun 8, 2018
    Copy the full SHA
    88fc6fa View commit details

  22. gyp: escape spaces in filenames in make generator 

    PR-URL: #1436
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @bnoordhuis
    Jeff Senn authored and bnoordhuis committed Jun 8, 2018
    Copy the full SHA
    0540e4e View commit details

  23. Remove unused gyp test scripts. 

    Shrinks node-gyp's size by about 100 kB.

PR-URL: #1458
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    @bnoordhuis
    bnoordhuis committed Jun 8, 2018
    Copy the full SHA
    84cea7b View commit details

  24. 3.7.0

    @bnoordhuis
    bnoordhuis committed Jun 8, 2018
    Copy the full SHA
    d8a0ca7 View commit details

Commits on Aug 8, 2018

  1. win: improve parsing of SDK version 

    This makes the parsing more robust and fixes the additional issue
related to USB Device Connectivity component.

Fixes: #1466
PR-URL: #1516
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    @Loghorn @joaocgreis
    Loghorn authored and joaocgreis committed Aug 8, 2018
    Copy the full SHA
    340403c View commit details

Commits on Aug 9, 2018

  1. deps: bump request to 2.8.7, fixes heok/hawk issues 

    PR-URL: #1492
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Rod Vagg <rod@vagg.org>
    @Rohithzr @rvagg
    Rohithzr authored and rvagg committed Aug 9, 2018
    Copy the full SHA
    969447c View commit details

  2. test: added test/processExecSync.js for when execFileSync is not avai… 

    …lable.

PR-URL: #1492
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Matheus Marchini <matheus@sthima.com>
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Rod Vagg <rod@vagg.org>
    @Rohithzr @rvagg
    Rohithzr authored and rvagg committed Aug 9, 2018
    Copy the full SHA
    60e4213 View commit details

  3. test: formatting and minor fixes for execFileSync replacement 

    PR-URL: #1521
Reviewed-By: Jon Moss <me@jonathanmoss.me>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
    @rvagg
    rvagg committed Aug 9, 2018
    Copy the full SHA
    6cd84b8 View commit details

  4. gyp: backport GYP fix to fix AIX shared suffix 

    Required to support the shared library builds on AIX - this sets the
shared library suffix within GYP to .a instead of .so on AIX
My patch: https://codereview.chromium.org/2492233002/ was landed as
as part of this one which fixed some other (not required, but
included for completeness of the backport) changes:

PR-URL: https://github.com/nodejs/node/pull9675
Reviewed-By: James M Snell <jasnell@gmail.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
Ref: https://codereview.chromium.org/2511733005/
    @rvagg
    Stewart Addison authored and rvagg committed Aug 9, 2018
    Copy the full SHA
    8aedbfd View commit details
Showing with 1,292 additions and 1,211 deletions.
  1. +26 −0 .github/ISSUE_TEMPLATE.md
  2. +17 −0 .github/PULL_REQUEST_TEMPLATE.md
  3. +0 −35 0001-gyp-always-install-into-PRODUCT_DIR.patch
  4. +0 −36 0002-gyp-apply-https-codereview.chromium.org-11361103.patch
  5. +0 −39 0003-gyp-don-t-use-links-at-all-just-copy-the-files-inste.patch
  6. +88 −0 CHANGELOG.md
  7. +34 −0 CONTRIBUTING.md
  8. +52 −27 README.md
  9. +33 −2 addon.gypi
  10. +4 −3 gyp/AUTHORS
  11. +14 −12 gyp/PRESUBMIT.py
  12. +0 −466 gyp/buildbot/aosp_manifest.xml
  13. +0 −136 gyp/buildbot/buildbot_run.py
  14. +0 −6 gyp/buildbot/commit_queue/OWNERS
  15. +0 −3 gyp/buildbot/commit_queue/README
  16. +0 −15 gyp/buildbot/commit_queue/cq_config.json
  17. +0 −274 gyp/gyptest.py
  18. +1 −1 gyp/pylib/gyp/MSVSSettings.py
  19. +4 −0 gyp/pylib/gyp/common.py
  20. +5 −5 gyp/pylib/gyp/easy_xml.py
  21. +50 −7 gyp/pylib/gyp/generator/make.py
  22. +36 −1 gyp/pylib/gyp/generator/msvs.py
  23. +19 −7 gyp/pylib/gyp/generator/ninja.py
  24. +7 −2 gyp/pylib/gyp/input.py
  25. +27 −3 gyp/pylib/gyp/xcode_emulation.py
  26. +273 −0 lib/Find-VS2017.cs
  27. +17 −31 lib/build.js
  28. +67 −38 lib/configure.js
  29. +46 −0 lib/find-vs2017.js
  30. +33 −33 lib/install.js
  31. +2 −0 lib/process-release.js
  32. +5 −7 package.json
  33. +22 −0 test/fixtures/test-charmap.py
  34. +3 −4 test/node_modules/hello_world/hello.cc
  35. +138 −0 test/process-exec-sync.js
  36. +90 −5 test/test-addon.js
  37. +5 −3 test/test-configure-python.js
  38. +22 −10 test/test-find-python.js
  39. +37 −0 test/test-install.js
  40. +115 −0 tools/gyp/pylib/gyp/generator/compile_commands_json.py
26 changes: 26 additions & 0 deletions .github/ISSUE_TEMPLATE.md
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
<!--
Thank you for reporting an issue. The more information you can give us, the
better the chance we can fix your problem.
This issue tracker is for issues with node-gyp,
if you have an issue installing a specific module, please file an issue on
that module's issue tracker (`npm issues modulename`).
-->

* **Node Version**: <!-- `node -v` and `npm -v` -->
* **Platform**: <!-- `uname -a` (UNIX), or `systeminfo | findstr /B /C:"OS Name" /C:"OS Version" /C:"System Type"` (Windows) -->
* **Compiler**: <!-- `cc -v` (UNIX) or `msbuild /version & cl` (Windows) -->
* **Module**: <!-- what you tried to build/install -->

<details><summary>Verbose output (from npm or node-gyp):</summary>

<!-- Paste your log between the backticks. Contents of npm-debug.log or verbose build output -->

```
```

</details>

<!-- Any further details -->

17 changes: 17 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
<!--
Thank you for your pull request. Please review the below requirements.
Contributor guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md
-->

##### Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

- [ ] `npm install && npm test` passes
- [ ] tests are included <!-- Bug fixes and new features should include tests -->
- [ ] documentation is changed or added
- [ ] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)

##### Description of change
<!-- Provide a description of the change -->

35 changes: 0 additions & 35 deletions 0001-gyp-always-install-into-PRODUCT_DIR.patch
View file

This file was deleted.

36 changes: 0 additions & 36 deletions 0002-gyp-apply-https-codereview.chromium.org-11361103.patch
View file

This file was deleted.

39 changes: 0 additions & 39 deletions 0003-gyp-don-t-use-links-at-all-just-copy-the-files-inste.patch
View file

This file was deleted.

88 changes: 88 additions & 0 deletions CHANGELOG.md
View file
Original file line number Diff line number Diff line change
@@ -1,3 +1,91 @@
v4.0.0 2019-04-24
=================

* [[`ceed5cbe10`](https://github.com/nodejs/node-gyp/commit/ceed5cbe10)] - **deps**: updated tar package version to 4.4.8 (Pobegaylo Maksim) [#1713](https://github.com/nodejs/node-gyp/pull/1713)
* [[`374519e066`](https://github.com/nodejs/node-gyp/commit/374519e066)] - **(SEMVER-MAJOR)** Upgrade to tar v3 (isaacs) [#1212](https://github.com/nodejs/node-gyp/pull/1212)
* [[`e6699d13cd`](https://github.com/nodejs/node-gyp/commit/e6699d13cd)] - **test**: fix addon test for Node.js 12 and V8 7.4 (Richard Lau) [#1705](https://github.com/nodejs/node-gyp/pull/1705)
* [[`0c6bf530a0`](https://github.com/nodejs/node-gyp/commit/0c6bf530a0)] - **lib**: use print() for python version detection (GreenAddress) [#1534](https://github.com/nodejs/node-gyp/pull/1534)

v3.8.0 2018-08-09
=================

* [[`c5929cb4fe`](https://github.com/nodejs/node-gyp/commit/c5929cb4fe)] - **doc**: update Xcode preferences tab name. (Ivan Daniluk) [#1330](https://github.com/nodejs/node-gyp/pull/1330)
* [[`8b488da8b9`](https://github.com/nodejs/node-gyp/commit/8b488da8b9)] - **doc**: update link to commit guidelines (Jonas Hermsmeier) [#1456](https://github.com/nodejs/node-gyp/pull/1456)
* [[`b4fe8c16f9`](https://github.com/nodejs/node-gyp/commit/b4fe8c16f9)] - **doc**: fix visual studio links (Bartosz Sosnowski) [#1490](https://github.com/nodejs/node-gyp/pull/1490)
* [[`536759c7e9`](https://github.com/nodejs/node-gyp/commit/536759c7e9)] - **configure**: use sys.version\_info to get python version (Yang Guo) [#1504](https://github.com/nodejs/node-gyp/pull/1504)
* [[`94c39c604e`](https://github.com/nodejs/node-gyp/commit/94c39c604e)] - **gyp**: fix ninja build failure (GYP patch) (Daniel Bevenius) [nodejs/node#12484](https://github.com/nodejs/node/pull/12484)
* [[`e8ea74e0fa`](https://github.com/nodejs/node-gyp/commit/e8ea74e0fa)] - **tools**: patch gyp to avoid xcrun errors (Ujjwal Sharma) [nodejs/node#21520](https://github.com/nodejs/node/pull/21520)
* [[`ea9aff44f2`](https://github.com/nodejs/node-gyp/commit/ea9aff44f2)] - **tools**: fix "the the" typos in comments (Masashi Hirano) [nodejs/node#20716](https://github.com/nodejs/node/pull/20716)
* [[`207e5aa4fd`](https://github.com/nodejs/node-gyp/commit/207e5aa4fd)] - **gyp**: implement LD/LDXX for ninja and FIPS (Sam Roberts)
* [[`b416c5f4b7`](https://github.com/nodejs/node-gyp/commit/b416c5f4b7)] - **gyp**: enable cctest to use objects (gyp part) (Daniel Bevenius) [nodejs/node#12450](https://github.com/nodejs/node/pull/12450)
* [[`40692d016b`](https://github.com/nodejs/node-gyp/commit/40692d016b)] - **gyp**: add compile\_commands.json gyp generator (Ben Noordhuis) [nodejs/node#12450](https://github.com/nodejs/node/pull/12450)
* [[`fc3c4e2b10`](https://github.com/nodejs/node-gyp/commit/fc3c4e2b10)] - **gyp**: float gyp patch for long filenames (Anna Henningsen) [nodejs/node#7963](https://github.com/nodejs/node/pull/7963)
* [[`8aedbfdef6`](https://github.com/nodejs/node-gyp/commit/8aedbfdef6)] - **gyp**: backport GYP fix to fix AIX shared suffix (Stewart Addison)
* [[`6cd84b84fc`](https://github.com/nodejs/node-gyp/commit/6cd84b84fc)] - **test**: formatting and minor fixes for execFileSync replacement (Rod Vagg) [#1521](https://github.com/nodejs/node-gyp/pull/1521)
* [[`60e421363f`](https://github.com/nodejs/node-gyp/commit/60e421363f)] - **test**: added test/processExecSync.js for when execFileSync is not available. (Rohit Hazra) [#1492](https://github.com/nodejs/node-gyp/pull/1492)
* [[`969447c5bd`](https://github.com/nodejs/node-gyp/commit/969447c5bd)] - **deps**: bump request to 2.8.7, fixes heok/hawk issues (Rohit Hazra) [#1492](https://github.com/nodejs/node-gyp/pull/1492)
* [[`340403ccfe`](https://github.com/nodejs/node-gyp/commit/340403ccfe)] - **win**: improve parsing of SDK version (Alessandro Vergani) [#1516](https://github.com/nodejs/node-gyp/pull/1516)

v3.7.0 2018-06-08
=================

* [[`84cea7b30d`](https://github.com/nodejs/node-gyp/commit/84cea7b30d)] - Remove unused gyp test scripts. (Ben Noordhuis) [#1458](https://github.com/nodejs/node-gyp/pull/1458)
* [[`0540e4ec63`](https://github.com/nodejs/node-gyp/commit/0540e4ec63)] - **gyp**: escape spaces in filenames in make generator (Jeff Senn) [#1436](https://github.com/nodejs/node-gyp/pull/1436)
* [[`88fc6fa0ec`](https://github.com/nodejs/node-gyp/commit/88fc6fa0ec)] - Drop dependency on minimatch. (Brian Woodward) [#1158](https://github.com/nodejs/node-gyp/pull/1158)
* [[`1e203c5148`](https://github.com/nodejs/node-gyp/commit/1e203c5148)] - Fix include path when pointing to Node.js source (Richard Lau) [#1055](https://github.com/nodejs/node-gyp/pull/1055)
* [[`53d8cb967c`](https://github.com/nodejs/node-gyp/commit/53d8cb967c)] - Prefix build targets with /t: on Windows (Natalie Wolfe) [#1164](https://github.com/nodejs/node-gyp/pull/1164)
* [[`53a5f8ff38`](https://github.com/nodejs/node-gyp/commit/53a5f8ff38)] - **gyp**: add support for .mm files to msvs generator (Julien Racle) [#1167](https://github.com/nodejs/node-gyp/pull/1167)
* [[`dd8561e528`](https://github.com/nodejs/node-gyp/commit/dd8561e528)] - **zos**: don't use universal-new-lines mode (John Barboza) [#1451](https://github.com/nodejs/node-gyp/pull/1451)
* [[`e5a69010ed`](https://github.com/nodejs/node-gyp/commit/e5a69010ed)] - **zos**: add search locations for libnode.x (John Barboza) [#1451](https://github.com/nodejs/node-gyp/pull/1451)
* [[`79febace53`](https://github.com/nodejs/node-gyp/commit/79febace53)] - **doc**: update macOS information in README (Josh Parnham) [#1323](https://github.com/nodejs/node-gyp/pull/1323)
* [[`9425448945`](https://github.com/nodejs/node-gyp/commit/9425448945)] - **gyp**: don't print xcodebuild not found errors (Gibson Fahnestock) [#1370](https://github.com/nodejs/node-gyp/pull/1370)
* [[`6f1286f5b2`](https://github.com/nodejs/node-gyp/commit/6f1286f5b2)] - Fix infinite install loop. (Ben Noordhuis) [#1384](https://github.com/nodejs/node-gyp/pull/1384)
* [[`2580b9139e`](https://github.com/nodejs/node-gyp/commit/2580b9139e)] - Update `--nodedir` description in README. (Ben Noordhuis) [#1372](https://github.com/nodejs/node-gyp/pull/1372)
* [[`a61360391a`](https://github.com/nodejs/node-gyp/commit/a61360391a)] - Update README with another way to install on windows (JeffAtDeere) [#1352](https://github.com/nodejs/node-gyp/pull/1352)
* [[`47496bf6dc`](https://github.com/nodejs/node-gyp/commit/47496bf6dc)] - Fix IndexError when parsing GYP files. (Ben Noordhuis) [#1267](https://github.com/nodejs/node-gyp/pull/1267)
* [[`b2024dee7b`](https://github.com/nodejs/node-gyp/commit/b2024dee7b)] - **zos**: support platform (John Barboza) [#1276](https://github.com/nodejs/node-gyp/pull/1276)
* [[`90d86512f4`](https://github.com/nodejs/node-gyp/commit/90d86512f4)] - **win**: run PS with `-NoProfile` (Refael Ackermann) [#1292](https://github.com/nodejs/node-gyp/pull/1292)
* [[`2da5f86ef7`](https://github.com/nodejs/node-gyp/commit/2da5f86ef7)] - **doc**: add github PR and Issue templates (Gibson Fahnestock) [#1228](https://github.com/nodejs/node-gyp/pull/1228)
* [[`a46a770d68`](https://github.com/nodejs/node-gyp/commit/a46a770d68)] - **doc**: update proposed DCO and CoC (Mikeal Rogers) [#1229](https://github.com/nodejs/node-gyp/pull/1229)
* [[`7e803d58e0`](https://github.com/nodejs/node-gyp/commit/7e803d58e0)] - **doc**: headerify the Install instructions (Nick Schonning) [#1225](https://github.com/nodejs/node-gyp/pull/1225)
* [[`f27599193a`](https://github.com/nodejs/node-gyp/commit/f27599193a)] - **gyp**: update xml string encoding conversion (Liu Chao) [#1203](https://github.com/nodejs/node-gyp/pull/1203)
* [[`0a07e481f7`](https://github.com/nodejs/node-gyp/commit/0a07e481f7)] - **configure**: don't set ensure if tarball is set (Gibson Fahnestock) [#1220](https://github.com/nodejs/node-gyp/pull/1220)

v3.6.3 2018-06-08
=================

* [[`90cd2e8da9`](https://github.com/nodejs/node-gyp/commit/90cd2e8da9)] - **gyp**: fix regex to match multi-digit versions (Jonas Hermsmeier) [#1455](https://github.com/nodejs/node-gyp/pull/1455)
* [[`7900122337`](https://github.com/nodejs/node-gyp/commit/7900122337)] - deps: pin `request` version range (Refael Ackerman) [#1300](https://github.com/nodejs/node-gyp/pull/1300)

v3.6.2 2017-06-01
=================

* [[`72afdd62cd`](https://github.com/nodejs/node-gyp/commit/72afdd62cd)] - **build**: rename copyNodeLib() to doBuild() (Liu Chao) [#1206](https://github.com/nodejs/node-gyp/pull/1206)
* [[`bad903ac70`](https://github.com/nodejs/node-gyp/commit/bad903ac70)] - **win**: more robust parsing of SDK version (Refael Ackermann) [#1198](https://github.com/nodejs/node-gyp/pull/1198)
* [[`241752f381`](https://github.com/nodejs/node-gyp/commit/241752f381)] - Log dist-url. (Ben Noordhuis) [#1170](https://github.com/nodejs/node-gyp/pull/1170)
* [[`386746c7d1`](https://github.com/nodejs/node-gyp/commit/386746c7d1)] - **configure**: use full path in node_lib_file GYP var (Pavel Medvedev) [#964](https://github.com/nodejs/node-gyp/pull/964)
* [[`0913b2dd99`](https://github.com/nodejs/node-gyp/commit/0913b2dd99)] - **build, win**: use target_arch to link with node.lib (Pavel Medvedev) [#964](https://github.com/nodejs/node-gyp/pull/964)
* [[`c307b302f7`](https://github.com/nodejs/node-gyp/commit/c307b302f7)] - **doc**: blorb about setting `npm_config_OPTION_NAME` (Refael Ackermann) [#1185](https://github.com/nodejs/node-gyp/pull/1185)

v3.6.1 2017-04-30
=================

* [[`49801716c2`](https://github.com/nodejs/node-gyp/commit/49801716c2)] - **test**: fix test-find-python on v0.10.x buildbot. (Ben Noordhuis) [#1172](https://github.com/nodejs/node-gyp/pull/1172)
* [[`a83a3801fc`](https://github.com/nodejs/node-gyp/commit/a83a3801fc)] - **test**: fix test/test-configure-python on AIX (Richard Lau) [#1131](https://github.com/nodejs/node-gyp/pull/1131)
* [[`8a767145c9`](https://github.com/nodejs/node-gyp/commit/8a767145c9)] - **gyp**: Revert quote_cmd workaround (Kunal Pathak) [#1153](https://github.com/nodejs/node-gyp/pull/1153)
* [[`c09cf7671e`](https://github.com/nodejs/node-gyp/commit/c09cf7671e)] - **doc**: add a note for using `configure` on Windows (Vse Mozhet Byt) [#1152](https://github.com/nodejs/node-gyp/pull/1152)
* [[`da9cb5f411`](https://github.com/nodejs/node-gyp/commit/da9cb5f411)] - Delete superfluous .patch files. (Ben Noordhuis) [#1122](https://github.com/nodejs/node-gyp/pull/1122)

v3.6.0 2017-03-16
=================

* [[`ae141e1906`](https://github.com/nodejs/node-gyp/commit/ae141e1906)] - **win**: find and setup for VS2017 (Refael Ackermann) [#1130](https://github.com/nodejs/node-gyp/pull/1130)
* [[`ec5fc36a80`](https://github.com/nodejs/node-gyp/commit/ec5fc36a80)] - Add support to build node.js with chakracore for ARM. (Kunal Pathak) [#873](https://github.com/nodejs/node-gyp/pull/873)
* [[`a04ea3051a`](https://github.com/nodejs/node-gyp/commit/a04ea3051a)] - Add support to build node.js with chakracore. (Kunal Pathak) [#873](https://github.com/nodejs/node-gyp/pull/873)
* [[`93d7fa83c8`](https://github.com/nodejs/node-gyp/commit/93d7fa83c8)] - Upgrade semver dependency. (Ben Noordhuis) [#1107](https://github.com/nodejs/node-gyp/pull/1107)
* [[`ff9a6fadfd`](https://github.com/nodejs/node-gyp/commit/ff9a6fadfd)] - Update link of gyp as Google code is shutting down (Peter Dave Hello) [#1061](https://github.com/nodejs/node-gyp/pull/1061)


v3.5.0 2017-01-10
=================

34 changes: 34 additions & 0 deletions CONTRIBUTING.md
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,34 @@
# Contributing to node-gyp

## Code of Conduct

Please read the
[Code of Conduct](https://github.com/nodejs/TSC/blob/master/CODE_OF_CONDUCT.md)
which explains the minimum behavior expectations for node-gyp contributors.

<a id="developers-certificate-of-origin"></a>
## Developer's Certificate of Origin 1.1

By making a contribution to this project, I certify that:

* (a) The contribution was created in whole or in part by me and I
have the right to submit it under the open source license
indicated in the file; or

* (b) The contribution is based upon previous work that, to the best
of my knowledge, is covered under an appropriate open source
license and I have the right under that license to submit that
work with modifications, whether created in whole or in part
by me, under the same open source license (unless I am
permitted to submit under a different license), as indicated
in the file; or

* (c) The contribution was provided directly to me by some other
person who certified (a), (b) or (c) and I have not modified
it.

* (d) I understand and agree that this project and the contribution
are public and that a record of the contribution (including all
personal information I submit with it, including my sign-off) is
maintained indefinitely and may be redistributed consistent with
this project or the open source license(s) involved.
Loading