Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: nodejs/node-gyp
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: 1dcf356ca7b658789447108b29a985c00ffcf0f5
Choose a base ref
...
head repository: nodejs/node-gyp
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 41f2b236a0f93adaa6ac4205620157633c07c062
Choose a head ref
51 contributors

Commits on Mar 31, 2016

  1. Add support for the Python launcher on Windows 

    When looking for a Python executable on Windows, before falling back to
guessing the default location or failing completely, attempt to use the
Python launcher to figure out the location of the Python executable.

The Python launcher is being distributed by default with Python
distributions on Windows, and is placed in the %WINDIR% folder (which is
in the PATH). This allows us to locate a Python installation even if it
was installed without putting the python.exe executable itself into the
PATH.

Because the Python launcher supports all versions of Python, we have to
explicitly request a Python 2 version. This is done by supplying "-2" as
the first command line argument. Since "py.exe -2" would be an invalid
executable for "execFile", we have to use the launcher to figure out where
the actual "python.exe" executable is located.

PR-URL: #894
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @poke @bnoordhuis
    poke authored and bnoordhuis committed Mar 31, 2016
    Copy the full SHA
    3bcb172 View commit details

Commits on Apr 28, 2016

  1. gyp: inherit CC/CXX for CC/CXX.host 

    Gyp defaults to gcc/g++ if CC.host/CXX.host is unset. This is not
suitable for environments that only uses the clang toolchain.

Since we already assume that the user will provide clang/clang++
through CC/CXX, lean against it (then drop to gcc/g++).

PR-URL: #908
Refs: nodejs/node#6173
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
    @jbergstroem @bnoordhuis
    jbergstroem authored and bnoordhuis committed Apr 28, 2016
    Copy the full SHA
    625c151 View commit details

Commits on May 17, 2016

  1. Update Windows install instructions 

    * Point to the latest release of the VC++ Build Tools.
* Simplify and consolidate install instructions for all Windows versions.

PR-URL: #867
Fixes: #629
Reviewed-By: orangemocha - Alexis Campailla <orangemocha@nodejs.org>
Reviewed-By: thealphanerd - Myles Borins <myles.borins@gmail.com>
    @mousetraps @orangemocha
    mousetraps authored and orangemocha committed May 17, 2016
    Copy the full SHA
    0880827 View commit details

Commits on May 19, 2016

  1. gyp: improvements for android generator 

    When generating Android.mk files for HOST binaries, we need to specify
the LOCAL_CXX_STL to use when linking.
Also, set the variable GYP_HOST_MULTILIB to 'first'. This is used as
LOCAL_MULTILIB, and since we don't provide flags for both types of
builds (32-bit and 64-bit), the build system will try to build both and
fail.
More details about LOCAL_MULTILIB can be found here:
https://source.android.com/source/64-bit-builds.html

Signed-off-by: Robert Chiras <robert.chiras@intel.com>
PR-URL: #935
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @robertchiras @bnoordhuis
    robertchiras authored and bnoordhuis committed May 19, 2016
    Copy the full SHA
    7f1c1b9 View commit details

Commits on May 30, 2016

  1. Enable V8 deprecation warnings for native modules 

    It will be helpful for native module developers to be aware of any
deprecated apis they are using so that they can update before their
modules break completely. Module developers can override this option
in their binding.gyp if they do not want to see these warnings.

PR-URL: #920
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @bnoordhuis
    Matt Loring authored and bnoordhuis committed May 30, 2016
    Copy the full SHA
    15fd56b View commit details

Commits on May 31, 2016

  1. Upgrade to glob@7.0.3. 

    Matches what npm v2.15.5 and npm v3.8.6 use.

Fixes: #941
PR-URL: #943
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
Reviewed-By: Rod Vagg <rod@vagg.org>
    @bnoordhuis
    bnoordhuis committed May 31, 2016
    Copy the full SHA
    ac29d23 View commit details

  2. Add --silent option for zero output. 

    Passing --silent is equivalent to passing --loglevel=silent.

PR-URL: #937
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @gibfahn @bnoordhuis
    gibfahn authored and bnoordhuis committed May 31, 2016
    Copy the full SHA
    c8c7ca8 View commit details

  3. doc: add command options to README.md 

    Documents options accepted by node-gyp.

PR-URL: #937
Refs: #880
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @gibfahn @bnoordhuis
    gibfahn authored and bnoordhuis committed May 31, 2016
    Copy the full SHA
    4ee3132 View commit details

Commits on Jun 2, 2016

  1. More verbose error on locating msbuild.exe failure. 

    PR-URL: #930
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @purplecode @bnoordhuis
    purplecode authored and bnoordhuis committed Jun 2, 2016
    Copy the full SHA
    a4fa07b View commit details

Commits on Jun 7, 2016

  1. Allow for npmlog@3.x 

    npmlog version 3 switches to gauge version 2.  The interface change is
in setGaugeTemplate, which node-gyp does not use.

PR-URL: #950
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @iarna @bnoordhuis
    iarna authored and bnoordhuis committed Jun 7, 2016
    Copy the full SHA
    3df8222 View commit details

Commits on Jun 13, 2016

  1. win: work around __pfnDliNotifyHook2 type change 

    Visual Studio 2015 Update 3 defines __pfnDliNotifyHook2 as const.
The decltype specifier makes the declaration work across all supported
versions of VS. It also requires that the source be compiled as C++.

Fixes: #949

PR-URL: #952
Reviewed-By: bnoordhuis - Ben Noordhuis <info@bnoordhuis.nl>
    @orangemocha
    orangemocha authored Jun 13, 2016
    9
    Copy the full SHA
    f31482e View commit details

Commits on Jun 16, 2016

  1. Move VC++ Build Tools to Build Tools landing page. 

    PR-URL: #953
Reviewed-By: Alexis Campailla <orangemocha@nodejs.org>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @bnoordhuis
    Andrew Pardoe authored and bnoordhuis committed Jun 16, 2016
    Copy the full SHA
    af35b2a View commit details

  2. Override BUILDING_UV_SHARED, BUILDING_V8_SHARED. 

    We were inheriting BUILDING_UV_SHARED and BUILDING_V8_SHARED from
the common.gypi from the node.js source tree.  Override them with
USING_UV_SHARED and USING_V8_SHARED so symbols get tagged with
`__declspec(dllimport)` instead of `__declspec(dllexport)`, which
is the desired attribute when building add-ons.

Fixes: #914
PR-URL: #915
Reviewed-By: Benjamin Byholm <bbyholm@abo.fi>
Reviewed-By: Fedor Indutny <fedor@indutny.com>
    @bnoordhuis
    bnoordhuis committed Jun 16, 2016
    Copy the full SHA
    cc778e9 View commit details

Commits on Jun 17, 2016

  1. doc: add --target option to README 

    PR-URL: #958
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @gibfahn @bnoordhuis
    gibfahn authored and bnoordhuis committed Jun 17, 2016
    Copy the full SHA
    c4344b3 View commit details

  2. test: add simple addon test 

    PR-URL: #955
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @richardlau @bnoordhuis
    richardlau authored and bnoordhuis committed Jun 17, 2016
    Copy the full SHA
    0dba4bd View commit details

  3. Replace fs.accessSync call to fs.statSync 

    fs.accessSync does not exist in Node 0.10.x.

PR-URL: #955
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @richardlau @bnoordhuis
    richardlau authored and bnoordhuis committed Jun 17, 2016
    Copy the full SHA
    77383dd View commit details

Commits on Jun 28, 2016

  1. deps: update minimatch version 

    PR-URL: #961
Reviewed-By: Rod Vagg <rod@vagg.org>
    @delphiactual @rvagg
    delphiactual authored and rvagg committed Jun 28, 2016
    Copy the full SHA
    ce5fd04 View commit details

  2. changelog for v3.4.0

    @rvagg
    rvagg committed Jun 28, 2016
    Copy the full SHA
    cc312ca View commit details

  3. 3.4.0

    @rvagg
    rvagg committed Jun 28, 2016
    Copy the full SHA
    d460084 View commit details

Commits on Jul 25, 2016

  1. doc: add windows-build-tools to readme 

    Added Microsoft's [windows-build-tools](https://github.com/felixrieseberg/windows-build-tools) to the readme.

PR-URL: #970
Reviewed-By: João Reis <reis@janeasystems.com>
    @felixrieseberg @joaocgreis
    felixrieseberg authored and joaocgreis committed Jul 25, 2016
    Copy the full SHA
    f6eab1f View commit details

Commits on Oct 7, 2016

  1. Add --devdir flag. 

    Overrides the location where node-gyp will look for (and download to)
the node.js SDK.

For harmonization with the --nodedir flag, `osenv.home()` is now used
instead of `process.env.HOME || process.env.USERPROFILE`.

`osenv.home()` defaults to the built-in `os.homedir()` when available
and falls back to sane defaults based on the platform.

`%USERPROFILE%` is now preferred on Windows and `%HOME%` is ignored;
similarly, UNIX systems ignore `$USERPROFILE` from now on.  Neither
behavior made much sense, IMO.

Fixes: #21
PR-URL: #916
Reviewed-By: Rod Vagg <rod@vagg.org>
    @bnoordhuis
    bnoordhuis committed Oct 7, 2016
    Copy the full SHA
    9c8d275 View commit details

  2. Revert "configure: use "path-array" for PYTHONPATH" 

    This reverts commit ff88e5f.

Of the 5.5MB footprint of node-gyp, path-array makes up 3.6MB.

Removing this reduces the weight of npm (and thus node) appreciably.

PR-URL: #990
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @mhart @bnoordhuis
    mhart authored and bnoordhuis committed Oct 7, 2016
    Copy the full SHA
    7c08b85 View commit details

  3. Revert "add "path-array" dep" 

    This reverts commit 81eadc5.

PR-URL: #990
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @mhart @bnoordhuis
    mhart authored and bnoordhuis committed Oct 7, 2016
    Copy the full SHA
    b182a19 View commit details

  4. Use push on PYTHONPATH and add tests 

    Using push instead of the original unshift makes the logic a little
cleaner to read here.

PR-URL: #990
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @mhart @bnoordhuis
    mhart authored and bnoordhuis committed Oct 7, 2016
    Copy the full SHA
    ddac348 View commit details

  5. Unset executable bit for .bat files 

    On Windows this bit is not meaningful, on Posix systems such files
should not be executable.

PR-URL: #969
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Ingvar Stepanyan <me@rreverser.com>
    @pmed @bnoordhuis
    pmed authored and bnoordhuis committed Oct 7, 2016
    Copy the full SHA
    afc766a View commit details

Commits on Oct 8, 2016

  1. Add lots of findPython() tests. 

    Break up findPython() into pieces that can be tested in isolation and
add tests that do so.

PR-URL: #992
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
    @bnoordhuis
    bnoordhuis committed Oct 8, 2016
    Copy the full SHA
    e3778d9 View commit details

  2. Try python launcher when stock python is python 3. 

    Consult the python launcher when the python on the path is python 3.
If a python 2 exists on the system, it will tell us.

Fixes: #987
PR-URL: #992
Reviewed-By: Johan Bergström <bugs@bergstroem.nu>
    @bnoordhuis
    bnoordhuis committed Oct 8, 2016
    Copy the full SHA
    37ae7be View commit details

Commits on Nov 16, 2016

  1. Open the build file with universal-newlines mode 

    To make sure platform specific newlines ('\r\n' or '\r') are converted
to '\n' which otherwise will fail eval().

This should handle multiple issues reported on syntax error reading
binding.gyp (partial list):

#979
#199
nospaceships/node-net-ping#24
nospaceships/node-net-ping#21
mathiask88/node-snap7#11
node-hid/node-hid#28
xdenser/node-firebird-libfbclient#24

PR-URL: #1053
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @guymguym @bnoordhuis
    guymguym authored and bnoordhuis committed Nov 16, 2016
    Copy the full SHA
    05c4494 View commit details

Commits on Dec 15, 2016

  1. Fix deprecated dependency warning 

    Refs: https://github.com/iarna/gauge/pull/77
PR-URL: #1069
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    @Fishrock123
    Simone Primarosa authored and Fishrock123 committed Dec 15, 2016
    Copy the full SHA
    80fc5c3 View commit details

Commits on Jan 10, 2017

  1. [doc] merge History.md and CHANGELOG.md

    @rvagg
    rvagg committed Jan 10, 2017
    Copy the full SHA
    762d19a View commit details

  2. 3.5.0

    @rvagg
    rvagg committed Jan 10, 2017
    Copy the full SHA
    4793e1d View commit details

Commits on Jan 17, 2017

  1. Update link of gyp as Google code is shutting down 

    PR-URL: #1061
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    @PeterDaveHello @bnoordhuis
    PeterDaveHello authored and bnoordhuis committed Jan 17, 2017
    Copy the full SHA
    ff9a6fa View commit details

Commits on Feb 15, 2017

  1. Upgrade semver dependency. 

    Should fix reports of "TypeError: Cannot read property 'length' of
undefined" runtime exceptions where node-gyp uses a buggy version
of semver due to our overly broad accepted version range.

npm updated to semver@5.3.0 recently so we can too now and still
share the module with npm, keeping the download small.

Fixes: #1094
PR-URL: #1107
Reviewed-By: Jeremiah Senkpiel <fishrock123@rocketmail.com>
    @bnoordhuis
    bnoordhuis committed Feb 15, 2017
    Copy the full SHA
    93d7fa8 View commit details

  2. Add support to build node.js with chakracore. 

    Microsoft's chakracore engine is dependent on Windows SDK, and build
tools should know the version installed on user machine. This change
adds those dependencies in node-gyp tools. Below is the summary:

* Configure msvs_windows_target_platform_version to use the right
  Windows SDK.

* Configure msvs_use_library_dependency_inputs to export symbols
  correctly (otherwise functions not used by node.exe but might be
  needed by native addon modules could be optimized away by linker).

These changes were originally made in nodejs/node#4765, but as @shigeki
mentioned, it was more sensible to send these changes as PR to node-gyp
repo.

PR-URL: #873
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @kunalspathak @bnoordhuis
    kunalspathak authored and bnoordhuis committed Feb 15, 2017
    2
    Copy the full SHA
    a04ea30 View commit details

  3. Add support to build node.js with chakracore for ARM. 

    * Support building node.js with chakracore on Windows on ARM

* Building chakracore for ARM has a dependency on Windows SDK installed
  on the machine. Update python script to populate
  `WindowsSDKDesktopARMSupport` and `WindowsTargetPlatformVersion` for
  ARM builds. This will be using in node repo to build`chakracore.gyp`.

PR-URL: #873
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @kunalspathak @bnoordhuis
    kunalspathak authored and bnoordhuis committed Feb 15, 2017
    Copy the full SHA
    ec5fc36 View commit details

Commits on Mar 15, 2017

  1. win: find and setup for VS2017 

    PR-URL: #1130
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Bartosz Sosnowski <bartosz@janeasystems.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Rod Vagg <rod@vagg.org>
    @refack @joaocgreis
    refack authored and joaocgreis committed Mar 15, 2017
    Copy the full SHA
    ae141e1 View commit details

  2. 3.6.0

    @rvagg
    rvagg committed Mar 15, 2017
    Copy the full SHA
    8d04acf View commit details

  3. doc: update changelog for v3.6.0

    @rvagg
    rvagg committed Mar 15, 2017
    Copy the full SHA
    761c7cb View commit details

Commits on Mar 20, 2017

  1. Delete superfluous .patch files. 

    The patch files are unnecessary, they also exist as commits in the
history.  Delete the files.

PR-URL: #1122
Reviewed-By: João Reis <reis@janeasystems.com>
    @bnoordhuis
    bnoordhuis committed Mar 20, 2017
    Copy the full SHA
    da9cb5f View commit details

Commits on Apr 23, 2017

  1. doc: add a note for using configure on Windows 

    PR-URL: #1152
Fixes: #1149
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    @vsemozhetbyt @gibfahn
    vsemozhetbyt authored and gibfahn committed Apr 23, 2017
    Copy the full SHA
    c09cf76 View commit details

  2. gyp: Revert quote_cmd workaround 

    PR-URL: #1153
Fixes: #1151
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
Reviewed-By: Refael Ackermann <refack@gmail.com>
    @kunalspathak @gibfahn
    kunalspathak authored and gibfahn committed Apr 23, 2017
    Copy the full SHA
    8a76714 View commit details

Commits on Apr 25, 2017

  1. test: fix test/test-configure-python on AIX 

    On AIX, lib/configure.js attempts to locate node.exp via calls to
fs.openSync() and fs.closeSync(). Add these functions to the mocked
`graceful-fs` object in test/test-configure-python.js.

PR-URL: #1131
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Michael Dawson <michael_dawson@ca.ibm.com>
    @richardlau @gibfahn
    richardlau authored and gibfahn committed Apr 25, 2017
    Copy the full SHA
    a83a380 View commit details

  2. test: fix test-find-python on v0.10.x buildbot. 

    Work around a v0.10.x CI issue where path.resolve() on UNIX systems
prefixes Windows paths with the current working directory.

v0.12 and up are free of this issue because they use
path.win32.resolve() which does the right thing.

PR-URL: #1172
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
    @bnoordhuis @gibfahn
    bnoordhuis authored and gibfahn committed Apr 25, 2017
    Copy the full SHA
    4980171 View commit details

Commits on Apr 30, 2017

  1. 3.6.1

    @rvagg
    rvagg committed Apr 30, 2017
    Copy the full SHA
    ce815f9 View commit details

Commits on May 14, 2017

  1. doc: blorb about setting npm_config_OPTION_NAME 

    PR-URL: #1185
Fixes: #1180
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
Reviewed-By: Richard Lau <riclau@uk.ibm.com>
Reviewed-By: Anna Henningsen <anna@addaleax.net>
    @refack @gibfahn
    refack authored and gibfahn committed May 14, 2017
    Copy the full SHA
    c307b30 View commit details

Commits on May 15, 2017

  1. build, win: use target_arch to link with node.lib 

    Using `target_arch` in addon.gypi to link against Node.js library. This
variable was written into build/config.gypi on the `configure` stage.

Do not copy node.lib into node_root_dir/Release or node_root_dir/Debug
on Windows, link it from node_root_dir/target_arch directory.

PR-URL: #964
Reviewed-By: João Reis <reis@janeasystems.com>
    @pmed @joaocgreis
    pmed authored and joaocgreis committed May 15, 2017
    Copy the full SHA
    0913b2d View commit details

  2. configure: use full path in node_lib_file GYP var 

    Set path to node lib in `$(Configuration)` dir when `--nodedir` option
is supplied, otherwise use value of `target_arch` variable.

PR-URL: #964
Reviewed-By: João Reis <reis@janeasystems.com>
    @pmed @joaocgreis
    pmed authored and joaocgreis committed May 15, 2017
    Copy the full SHA
    386746c View commit details

Commits on May 17, 2017

  1. Log dist-url. 

    The default download URL can be overridden by `--dist-url` or one of the
`*_MIRROR` environment variables.  Log the URL to ease troubleshooting.

Fixes: #1169
PR-URL: #1170
Reviewed-By: Refael Ackermann <refack@gmail.com>
    @bnoordhuis
    bnoordhuis committed May 17, 2017
    Copy the full SHA
    241752f View commit details

  2. win: more robust parsing of SDK version 

    PR-URL: #1198
Fixes: #1179
Reviewed-By: Ben Noordhuis <info@bnoordhuis.nl>
Reviewed-By: João Reis <reis@janeasystems.com>
    @refack
    refack committed May 17, 2017
    Copy the full SHA
    bad903a View commit details

Commits on May 27, 2017

  1. build: rename copyNodeLib() to doBuild() 

    PR-URL: #1206
Reviewed-By: Refael Ackermann <refack@gmail.com>
Reviewed-By: João Reis <reis@janeasystems.com>
Reviewed-By: Gibson Fahnestock <gibfahn@gmail.com>
    @lc-soft @refack
    lc-soft authored and refack committed May 27, 2017
    Copy the full SHA
    72afdd6 View commit details
Showing with 2,138 additions and 1,349 deletions.
  1. +26 −0 .github/ISSUE_TEMPLATE.md
  2. +17 −0 .github/PULL_REQUEST_TEMPLATE.md
  3. +0 −35 0001-gyp-always-install-into-PRODUCT_DIR.patch
  4. +0 −36 0002-gyp-apply-https-codereview.chromium.org-11361103.patch
  5. +0 −39 0003-gyp-don-t-use-links-at-all-just-copy-the-files-inste.patch
  6. +178 −0 CHANGELOG.md
  7. +34 −0 CONTRIBUTING.md
  8. +0 −41 History.md
  9. +90 −45 README.md
  10. +43 −4 addon.gypi
  11. +15 −0 bin/node-gyp.js
  12. +4 −3 gyp/AUTHORS
  13. +14 −12 gyp/PRESUBMIT.py
  14. +0 −466 gyp/buildbot/aosp_manifest.xml
  15. +0 −136 gyp/buildbot/buildbot_run.py
  16. +0 −6 gyp/buildbot/commit_queue/OWNERS
  17. +0 −3 gyp/buildbot/commit_queue/README
  18. +0 −15 gyp/buildbot/commit_queue/cq_config.json
  19. 0 gyp/gyp.bat
  20. +0 −274 gyp/gyptest.py
  21. +1 −1 gyp/pylib/gyp/MSVSSettings.py
  22. +4 −0 gyp/pylib/gyp/common.py
  23. +5 −5 gyp/pylib/gyp/easy_xml.py
  24. +2 −1 gyp/pylib/gyp/generator/android.py
  25. +54 −11 gyp/pylib/gyp/generator/make.py
  26. +36 −1 gyp/pylib/gyp/generator/msvs.py
  27. +19 −7 gyp/pylib/gyp/generator/ninja.py
  28. +10 −2 gyp/pylib/gyp/input.py
  29. +27 −3 gyp/pylib/gyp/xcode_emulation.py
  30. +273 −0 lib/Find-VS2017.cs
  31. +23 −37 lib/build.js
  32. +222 −108 lib/configure.js
  33. +46 −0 lib/find-vs2017.js
  34. +33 −33 lib/install.js
  35. +3 −12 lib/node-gyp.js
  36. +2 −0 lib/process-release.js
  37. +11 −11 package.json
  38. +1 −1 src/{win_delay_load_hook.c → win_delay_load_hook.cc}
  39. +22 −0 test/fixtures/test-charmap.py
  40. +11 −0 test/node_modules/hello_world/binding.gyp
  41. +11 −0 test/node_modules/hello_world/hello.cc
  42. +3 −0 test/node_modules/hello_world/hello.js
  43. +15 −0 test/node_modules/hello_world/package.json
  44. +138 −0 test/process-exec-sync.js
  45. +113 −0 test/test-addon.js
  46. +74 −0 test/test-configure-python.js
  47. +86 −0 test/test-find-accessible-sync.js
  48. +320 −1 test/test-find-python.js
  49. +37 −0 test/test-install.js
  50. +115 −0 tools/gyp/pylib/gyp/generator/compile_commands_json.py
26 changes: 26 additions & 0 deletions .github/ISSUE_TEMPLATE.md
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,26 @@
<!--
Thank you for reporting an issue. The more information you can give us, the
better the chance we can fix your problem.
This issue tracker is for issues with node-gyp,
if you have an issue installing a specific module, please file an issue on
that module's issue tracker (`npm issues modulename`).
-->

* **Node Version**: <!-- `node -v` and `npm -v` -->
* **Platform**: <!-- `uname -a` (UNIX), or `systeminfo | findstr /B /C:"OS Name" /C:"OS Version" /C:"System Type"` (Windows) -->
* **Compiler**: <!-- `cc -v` (UNIX) or `msbuild /version & cl` (Windows) -->
* **Module**: <!-- what you tried to build/install -->

<details><summary>Verbose output (from npm or node-gyp):</summary>

<!-- Paste your log between the backticks. Contents of npm-debug.log or verbose build output -->

```
```

</details>

<!-- Any further details -->

17 changes: 17 additions & 0 deletions .github/PULL_REQUEST_TEMPLATE.md
View file
Original file line number Diff line number Diff line change
@@ -0,0 +1,17 @@
<!--
Thank you for your pull request. Please review the below requirements.
Contributor guide: https://github.com/nodejs/node/blob/master/CONTRIBUTING.md
-->

##### Checklist
<!-- Remove items that do not apply. For completed items, change [ ] to [x]. -->

- [ ] `npm install && npm test` passes
- [ ] tests are included <!-- Bug fixes and new features should include tests -->
- [ ] documentation is changed or added
- [ ] commit message follows [commit guidelines](https://github.com/nodejs/node/blob/master/doc/guides/contributing/pull-requests.md#commit-message-guidelines)

##### Description of change
<!-- Provide a description of the change -->

35 changes: 0 additions & 35 deletions 0001-gyp-always-install-into-PRODUCT_DIR.patch
View file

This file was deleted.

36 changes: 0 additions & 36 deletions 0002-gyp-apply-https-codereview.chromium.org-11361103.patch
View file

This file was deleted.

39 changes: 0 additions & 39 deletions 0003-gyp-don-t-use-links-at-all-just-copy-the-files-inste.patch
View file

This file was deleted.

Loading