fix(): align with the rest of codebase

Author: kamilmysliwiec

lib/plugin/visitors/model-class.visitor.ts

@@ -204,9 +204,8 @@ export class ModelClassVisitor extends AbstractFileVisitor {
         const remainingTypes = node.types.filter(
           (item) => item !== nullableType
         );
-        /**
-         * when we have more than 1 type left, we could use oneOf
-         */
+
+        // When we have more than 1 type left, we could use oneOf
         if (remainingTypes.length === 1) {
           const remainingTypesProperties = this.createTypePropertyAssignments(
             remainingTypes[0],

test/plugin/model-class-visitor.spec.ts

@@ -22,27 +22,6 @@ import {
 } from './fixtures/nullable.dto';
 
 describe('API model properties', () => {
-  it('should understand nullable', () => {
-    const options: ts.CompilerOptions = {
-      module: ts.ModuleKind.ESNext,
-      target: ts.ScriptTarget.ESNext,
-      newLine: ts.NewLineKind.LineFeed,
-      noEmitHelpers: true,
-      strict: true
-    };
-    const filename = 'nullable.dto.ts';
-    const fakeProgram = ts.createProgram([filename], options);
-
-    const result = ts.transpileModule(nullableDtoText, {
-      compilerOptions: options,
-      fileName: filename,
-      transformers: {
-        before: [before({ classValidatorShim: true }, fakeProgram)]
-      }
-    });
-    expect(result.outputText).toEqual(nullableDtoTextTranspiled);
-  });
-
   it('should add the metadata factory when no decorators exist', () => {
     const options: ts.CompilerOptions = {
       module: ts.ModuleKind.ESNext,
@@ -126,4 +105,25 @@ describe('API model properties', () => {
     });
     expect(result.outputText).toEqual(es5CreateCatDtoTextTranspiled);
   });
+
+  it('should support & understand nullable type unions', () => {
+    const options: ts.CompilerOptions = {
+      module: ts.ModuleKind.ESNext,
+      target: ts.ScriptTarget.ESNext,
+      newLine: ts.NewLineKind.LineFeed,
+      noEmitHelpers: true,
+      strict: true
+    };
+    const filename = 'nullable.dto.ts';
+    const fakeProgram = ts.createProgram([filename], options);
+
+    const result = ts.transpileModule(nullableDtoText, {
+      compilerOptions: options,
+      fileName: filename,
+      transformers: {
+        before: [before({ classValidatorShim: true }, fakeProgram)]
+      }
+    });
+    expect(result.outputText).toEqual(nullableDtoTextTranspiled);
+  });
 });