Skip to content
Permalink

Comparing changes

Choose two branches to see what’s changed or to start a new pull request. If you need to, you can also or learn more about diff comparisons.

Open a pull request

Create a new pull request by comparing changes across two branches. If you need to, you can also . Learn more about diff comparisons here.
base repository: neo4j/neo4j-javascript-driver
Failed to load repositories. Confirm that selected base ref is valid, then try again.
Loading
base: ae46eb4a6462dab322be9c8bc3335ae3451aa71c
Choose a base ref
...
head repository: neo4j/neo4j-javascript-driver
Failed to load repositories. Confirm that selected head ref is valid, then try again.
Loading
compare: 5617f28515c839a5aae95fe8bf120550b3c52893
Choose a head ref
  • 8 commits
  • 39 files changed
  • 2 contributors

Commits on Dec 1, 2020

  1. Supporting browser, integration and stress tests on testkit (#642)

    Teskit doesn't run Neo4j on the localhost and with the same credentials of boltkit, but it exposes
    the host and credentials as env variables.
    
    So all this configuration being loaded to karma on the config files, parsed in `shared-neo4j` with fallback to
    the process env (case it's running the usual integration test) and to the default boltkit values.
    
    All the integration tests were changed to use the values from the shareNeo4j object.
    
    Disabled tests:
    * IPV6 tests are skipped on the testkit because of the lack of support for this
    * TLS tests are disabled since it's already tested on the testkit suite
    * Tests which depends on the enterprise edition of Neo4j is running only on this scenario
    bigmontz authored Dec 1, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    5bb6d4b View commit details

Commits on Dec 14, 2020

  1. teskit: Fine tunning stress tests to run in testkit

    Fix the way the url is generated during the stress test enabling to use configurations came from the test environment.
    Skipping the non-cluster-safe stress test commands to avoid unstable behaviours and flaky tests.
    bigmontz authored Dec 14, 2020
    Copy the full SHA
    f539b97 View commit details

Commits on Dec 15, 2020

  1. Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    2eb06f9 View commit details
  2. test: Improve the test timeout definition

    The timeout was being defined using the jasmine global variable and it was causing some flakyness in the tests.
    bigmontz committed Dec 15, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    3d43e2e View commit details

Commits on Dec 17, 2020

  1. Make the stress test more reliable

     Avoid session.run usage
     Treat the session.close() exception in the command.
     Check the number of commands run
    bigmontz authored Dec 17, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    c719102 View commit details

Commits on Dec 23, 2020

  1. Providing protocol version in Result get by Transaction.run

    The result summary was not filled with the protocol version because the transactions were creating
    the Result object with a empty connection holder. Since the Result releases the connection from holder
    when it completes, the original holder could not be passed to it.
    
    The ReadOnlyConnectionHolder provides a safe way to pass the holder forward without let the consumer initialize,
    close or release the connection by simulating this methods without do the action and delegating part of the requests to the original ConnectionHolder.
    
    These changes also made shared-neo4j cluster friendly.
    bigmontz authored Dec 23, 2020

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    14ea911 View commit details

Commits on Jan 15, 2021

  1. Disable secure connection warning when the window.protocol is not ava…

    …ilable (#664)
    
    The window.location is not available in the WebWorkers contexts and because of the driver keeps wrongly warning about a misconfiguration.
    If the information location protocol is not available, the driver should not warning.
    bigmontz authored Jan 15, 2021

    Verified

    This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
    Copy the full SHA
    2cf69fe View commit details
  2. Add type-safety to Record class

    This commit adds ability to create type-safe Record entities by assigning type to Record's value.
    The implementation is based on adding type parameters to types, interfaces, and classes. It is implemented however in a backwards-compatible manner, so that opting in to type safety is optional.
    
    Examples:
    
    // before (unsafe)
    const record = new Record(['name'], ['Alice'])
    record.get('neam') // no errors
    record.toObject().neam[0] // run-time (late) error
    
    // after (safe)
    const record = new Record<Person>(['name'], ['Alice'])
    record.get('neam') // Error: does not exist
    record.toObject().neam[0] // design-time (early) error
    parzhitsky authored and bigmontz committed Jan 15, 2021
    Copy the full SHA
    5617f28 View commit details
Loading