Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Revert cell/row mode if processRowUpdate fails #6319

Merged
merged 1 commit into from
Sep 29, 2022
Merged

[DataGrid] Revert cell/row mode if processRowUpdate fails #6319

merged 1 commit into from
Sep 29, 2022
+90 −65

Conversation

m4theushw
Copy link
Member

Backport of #6185

@m4theushw m4theushw added the component: data grid This is the name of the generic UI component, not the React module! label Sep 28, 2022
@mui-bot
Copy link

mui-bot commented Sep 28, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 597.8 1,178.7 597.8 842.38 222.718
Sort 100k rows ms 770.2 1,135.5 1,135.5 1,002.02 123.98
Select 100k rows ms 198.3 322.7 282.2 271.84 41.172
Deselect 100k rows ms 174.8 393.9 264.1 265.9 73.02

Generated by 🚫 dangerJS against 4eb551a

@m4theushw m4theushw changed the title [DataGrid] Revert cell/row mode if processRowUpdate fails (#6185) [DataGrid] Revert cell/row mode if processRowUpdate fails Sep 29, 2022
@m4theushw m4theushw merged commit b1cfee3 into mui:master Sep 29, 2022
@m4theushw m4theushw deleted the revert-mode-processrowupdate-fail-v5 branch September 29, 2022 00:25
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
component: data grid This is the name of the generic UI component, not the React module!
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@m4theushw @mui-bot