Skip to content

[DataGrid] Fix undefined value being showed in filter button tooltip text #6271

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Sep 26, 2022
Merged

[DataGrid] Fix undefined value being showed in filter button tooltip text #6271

merged 1 commit into from
Sep 26, 2022
+1 −1

Conversation

cherniavskii
Copy link
Member

Backport of #6259 to master

@cherniavskii cherniavskii added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Filtering Related to the data grid Filtering feature labels Sep 23, 2022
@cherniavskii cherniavskii mentioned this pull request Sep 23, 2022
Merged
1 task
@cherniavskii cherniavskii enabled auto-merge (squash) September 23, 2022 18:30
@mui-bot
Copy link

mui-bot commented Sep 23, 2022 •
edited
Loading

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 508.3 863.6 517.5 626.02 145.672
Sort 100k rows ms 545.9 1,006.9 821.7 835.58 163.298
Select 100k rows ms 188.1 234.7 207 208.5 15.167
Deselect 100k rows ms 134.9 258.1 205 196.48 40.17

Generated by 🚫 dangerJS against 6d8ae9d

@cherniavskii
[DataGrid] Fix undefined value being showed in filter button toolti…

Verified

This commit was signed with the committer’s verified signature. The key has expired.
aimuz aimuz
GPG key ID: 63C3DC9FBA22D9D7
Expired
Verified
Learn about vigilant mode
6d8ae9d 
…p text (mui#6259)
@cherniavskii cherniavskii force-pushed the filter-button-tooltip-undefined-value-master branch from f363003 to 6d8ae9d Compare September 23, 2022 20:18
@cherniavskii cherniavskii merged commit 0a245b8 into mui:master Sep 26, 2022
@cherniavskii cherniavskii deleted the filter-button-tooltip-undefined-value-master branch September 26, 2022 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: Filtering Related to the data grid Filtering feature
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@cherniavskii @mui-bot