Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[DataGrid] Do not publish cellFocusOut event if the row was removed #6251

Merged
merged 1 commit into from
Sep 22, 2022
Merged

[DataGrid] Do not publish cellFocusOut event if the row was removed #6251

merged 1 commit into from
Sep 22, 2022
+42 −25

Conversation

cherniavskii
Copy link
Member

Backport of #6009 to master

@cherniavskii
[DataGrid] Do not publish cellFocusOut event if the row was removed (…

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: EA557BA7F0E6BADA
Learn about vigilant mode
a79676f 
…mui#6009)
@cherniavskii cherniavskii mentioned this pull request Sep 22, 2022
Merged
1 task
@cherniavskii cherniavskii added bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! v5.x feature: State management Related to the data grid State management feature labels Sep 22, 2022
@mui-bot
Copy link

mui-bot commented Sep 22, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 460.6 737.6 591.7 606.8 114.626
Sort 100k rows ms 548.1 953 906.6 845.74 149.816
Select 100k rows ms 135.2 240.1 228.2 200.42 41.811
Deselect 100k rows ms 137.9 306.4 171.8 193.72 61.27

Generated by 🚫 dangerJS against a79676f

@cherniavskii cherniavskii merged commit 999d681 into mui:master Sep 22, 2022
@cherniavskii cherniavskii deleted the cellFocusOut-removed-rows-master branch September 22, 2022 11:00
This was referenced Sep 22, 2022
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@flaviendelangle flaviendelangle

Assignees
No one assigned
Labels
bug 🐛 Something doesn't work component: data grid This is the name of the generic UI component, not the React module! feature: State management Related to the data grid State management feature v5.x
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@cherniavskii @mui-bot @flaviendelangle