Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[pickers] Fix usage with Typescript 4.8 #6229

Merged
merged 1 commit into from
Sep 22, 2022

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Sep 21, 2022

Fixes #6134

  • Use @ts-expect-error to be aware if the error goes away in the future
  • Change the file extension to .d.ts to avoid having the @ts-expect-error comment removed during the build

Sorry, something went wrong.

Unverified

This user has not yet uploaded their public signing key.
@flaviendelangle flaviendelangle added bug 🐛 Something doesn't work typescript component: pickers This is the name of the generic UI component, not the React module! labels Sep 21, 2022
@flaviendelangle flaviendelangle self-assigned this Sep 21, 2022
@mui-bot
Copy link

mui-bot commented Sep 21, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 482 901 698.9 676.48 152.338
Sort 100k rows ms 708.7 1,065.1 807.3 873.44 117.508
Select 100k rows ms 188.2 389.3 230 252.2 71.953
Deselect 100k rows ms 163.3 364 210 230.56 69.932

Generated by 🚫 dangerJS against 111f26e

@flaviendelangle
Copy link
Member Author

@Orforio, @Methuselah96, @sheuertz, @a2441918

Could some of you test this fix on your applications ?
You just have to put the following line in place of the @mui/x-date-pickers in your package.json:

{
  "@mui/x-date-pickers": "https://pkg.csb.dev/mui/mui-x/commit/111f26e8/@mui/x-date-pickers",
  "@mui/x-date-pickers-pro": "https://pkg.csb.dev/mui/mui-x/commit/111f26e8/@mui/x-date-pickers-pro", // Only if you need it
  "@mui/x-license-pro": "https://pkg.csb.dev/mui/mui-x/commit/111f26e8/@mui/x-license-pro", // Only if you need it
}

I tested it on the reproduction case of @Methuselah96 and it seems to work.

@Orforio
Copy link

Orforio commented Sep 21, 2022

@flaviendelangle Build is green!

@flaviendelangle
Copy link
Member Author

I will release it in tomorrow's patch
I let it open until then in case some other want to test and to give feedbacks 👍

@Methuselah96
Copy link
Contributor

Works for me as well, thanks @flaviendelangle!

@flaviendelangle flaviendelangle merged commit 07b7679 into mui:master Sep 22, 2022
@flaviendelangle flaviendelangle deleted the ts-4-8 branch September 22, 2022 06:14
flaviendelangle added a commit to flaviendelangle/mui-x that referenced this pull request Sep 22, 2022

Unverified

This user has not yet uploaded their public signing key.
flaviendelangle added a commit that referenced this pull request Sep 22, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module! typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants