[pickers] Fix themeAugmentation and style overriding
#6156
Merged
+1,953
−462
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
- refactor component to functional
LukasTy
added
typescript
component: pickers
LukasTy
commented
Sep 15, 2022
packages/x-date-pickers/src/CalendarPickerSkeleton/CalendarPickerSkeleton.tsx
Show resolved
Hide resolved
LukasTy
commented
Sep 15, 2022
LukasTy
commented
Sep 15, 2022
LukasTy
commented
Sep 15, 2022
LukasTy
commented
Sep 15, 2022
alexfauquette
approved these changes
Sep 15, 2022
packages/x-date-pickers/src/internals/components/PickersPopper.tsx
Outdated
Show resolved
Hide resolved
packages/x-date-pickers/src/CalendarPickerSkeleton/CalendarPickerSkeleton.tsx
Show resolved
Hide resolved
packages/x-date-pickers/src/CalendarPickerSkeleton/CalendarPickerSkeleton.tsx
Show resolved
Hide resolved
|
Maybe some of my comments are useless. It overall looks good, I think we can merge the modification, it will fix lot of style issues |
2 tasks
This was referenced Sep 15, 2022
LukasTy
added a commit
to LukasTy/mui-x
that referenced
this pull request
Sep 15, 2022
* Add theme augmentation to components missing it * Refactor `ClockPointer` component to functional * Fix to correctly expose `classes` prop for extension
LukasTy
added a commit
that referenced
this pull request
Sep 15, 2022
* [pickers] Fix `themeAugmentation` and style overriding (#6156) * Add theme augmentation to components missing it * Refactor `ClockPointer` component to functional * Fix to correctly expose `classes` prop for extension
This was referenced Sep 16, 2022
2 tasks
Closed
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #4669
Fixes #4552
Fixes #5194
Fix community package components theme augmentation (style and prop overrides).
TL.DR.: The PR is quite big in change quantity, but the changes are more or less very similar among along the components