Skip to content

[docs] Fix server-side pagination demo #5361

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged

Conversation

cherniavskii
Copy link
Member

@cherniavskii cherniavskii commented Jun 30, 2022

I've noticed that in our server-side pagination example after changing page the data do not change: https://mui.com/x/react-data-grid/pagination/#basic-implementation
Turned out that cursor pagination was turned on by default and needed to be disabled for this demo.

Preview: https://deploy-preview-5361--material-ui-x.netlify.app/x/react-data-grid/pagination/#server-side-pagination

@cherniavskii cherniavskii added docs Improvements or additions to the documentation component: data grid This is the name of the generic UI component, not the React module! labels Jun 30, 2022
@mui-bot
Copy link

mui-bot commented Jun 30, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 262.6 423.6 340.8 335.76 54.509
Sort 100k rows ms 482.3 999 887.3 828.38 179.344
Select 100k rows ms 185.4 244.6 209.9 211.48 19.303
Deselect 100k rows ms 124.3 328.9 192.6 207.92 67.525

Generated by 🚫 dangerJS against fdb792d

Verified

This commit was signed with the committer’s verified signature.
novemberborn Mark Wubben
@cherniavskii cherniavskii force-pushed the fix-server-side-pagination-demo branch from 58b45bb to fdb792d Compare June 30, 2022 15:34
Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

good catch 🕵

@cherniavskii cherniavskii merged commit d793188 into mui:master Jul 1, 2022
@cherniavskii cherniavskii deleted the fix-server-side-pagination-demo branch July 1, 2022 10:36
joserodolfofreitas pushed a commit to joserodolfofreitas/mui-x that referenced this pull request Jul 15, 2022
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants