Skip to content

[l10n] Add Romanian (ro-RO) locale #5345

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 2 commits into from
Jun 30, 2022
Merged

[l10n] Add Romanian (ro-RO) locale #5345

merged 2 commits into from
Jun 30, 2022
+153 −0

Conversation

rolule
Copy link
Contributor

@rolule rolule commented Jun 29, 2022

Add Romanian locale to data grid.

@mui-bot
Copy link

mui-bot commented Jun 29, 2022 •
edited
Loading

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 257.6 587.7 411.6 401.96 121.758
Sort 100k rows ms 448 1,003.2 664.8 782.42 203.642
Select 100k rows ms 137.1 249 198 194.72 35.559
Deselect 100k rows ms 119.3 245.5 210.8 192.76 42.691

Generated by 🚫 dangerJS against f38e130

[l10n] Generate api after adding ro-RO locale

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
f38e130
@m4theushw m4theushw added the l10n localization label Jun 30, 2022
m4theushw
m4theushw reviewed Jun 30, 2022
View reviewed changes
packages/grid/x-data-grid/src/locales/roRO.ts
Comment on lines +31 to +33
// toolbarQuickFilterPlaceholder: 'Search...',
// toolbarQuickFilterLabel: 'Search',
// toolbarQuickFilterDeleteIconLabel: 'Clear',
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Do you mind translating these keys too? It's used in https://mui.com/x/react-data-grid/filtering/#quick-filter

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I will try adding these soon.

@flaviendelangle flaviendelangle merged commit 0d33275 into mui:master Jun 30, 2022
joserodolfofreitas pushed a commit to joserodolfofreitas/mui-x that referenced this pull request Jul 15, 2022
@rolule @joserodolfofreitas
[l10n] Add Romanian (ro-RO) locale (mui#5345)

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
9a29a52
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
@rolule @alexfauquette
[l10n] Add Romanian (ro-RO) locale (mui#5345)
b2d9f58
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@m4theushw m4theushw

@flaviendelangle flaviendelangle

Assignees
No one assigned
Labels
l10n localization
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
4 participants
@rolule @mui-bot @flaviendelangle @m4theushw