Skip to content

[pickers] Add missing type dependencies #5331

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jul 5, 2022

Conversation

Methuselah96
Copy link
Contributor

@Methuselah96 Methuselah96 commented Jun 27, 2022

The TypeScript declaration files for @mui/x-date-pickers import from @types/react-transition-group and @date-io/core, so those packages should be added as a dependency of @mui/x-date-pickers.

TS7016: Could not find a declaration file for module 'react-transition-group/CSSTransition'.
    1 | import * as React from 'react';
  > 2 | import { CSSTransitionProps } from 'react-transition-group/CSSTransition';
      |                                    ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
    3 | export declare type SlideDirection = 'right' | 'left';
    4 | export interface SlideTransitionProps extends Omit<CSSTransitionProps, 'timeout'> {
    5 |     children: React.ReactElement;

TS2307: Cannot find module '@date-io/core/IUtils' or its corresponding type declarations.
  > 1 | import { IUtils } from '@date-io/core/IUtils';
      |                        ^^^^^^^^^^^^^^^^^^^^^^
    2 | export declare type MuiPickersAdapter<TDate> = IUtils<TDate>;
    3 |

TS2307: Cannot find module '@date-io/core/IUtils' or its corresponding type declarations.
    1 | import * as React from 'react';
  > 2 | import { DateIOFormats } from '@date-io/core/IUtils';
      |                               ^^^^^^^^^^^^^^^^^^^^^^
    3 | import { MuiPickersAdapter } from '../internals/models';
    4 | import { PickersLocaleText } from '../locales';
    5 | export interface MuiPickersAdapterContextValue<TDate> {

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@mui-bot
Copy link

mui-bot commented Jun 27, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 244.1 435.8 335.8 330.5 73.297
Sort 100k rows ms 453.2 882.5 691.6 690.48 148.913
Select 100k rows ms 102.5 199.8 188.6 173.22 36.272
Deselect 100k rows ms 94.4 304.2 220.7 182.16 73.418

Generated by 🚫 dangerJS against f9857b0

@flaviendelangle flaviendelangle changed the title Add missing type dependencies [pickers] Add missing type dependencies Jul 5, 2022
Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good catch !

@flaviendelangle flaviendelangle merged commit 61ae1bc into mui:master Jul 5, 2022
@flaviendelangle flaviendelangle added typescript component: pickers This is the name of the generic UI component, not the React module! labels Jul 5, 2022
@Methuselah96 Methuselah96 deleted the add-missing-type-deps branch July 5, 2022 11:19
@oliviertassinari oliviertassinari added the bug 🐛 Something doesn't work label Jul 5, 2022
cherniavskii pushed a commit to cherniavskii/mui-x that referenced this pull request Jul 6, 2022

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
joserodolfofreitas pushed a commit to joserodolfofreitas/mui-x that referenced this pull request Jul 15, 2022

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work component: pickers This is the name of the generic UI component, not the React module! typescript
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants