Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[DataGrid] Mention Premium plan in error messages and docs warnings #5328

Merged
merged 2 commits into from
Jun 30, 2022

Conversation

cherniavskii
Copy link
Member

In #5317 (comment) I've noticed that DataGridPremium is not mentioned in the error message, so I've updated error messages.
I've also noticed that Premium plan is not mentioned on some docs pages, so I've added it there as well.

@cherniavskii cherniavskii added docs Improvements or additions to the documentation component: data grid This is the name of the generic UI component, not the React module! labels Jun 26, 2022
@mui-bot
Copy link

mui-bot commented Jun 26, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 234.7 503.2 326.5 354.2 108.328
Sort 100k rows ms 432.8 910.8 729.2 713.48 163.745
Select 100k rows ms 114 189.8 180.3 168.98 27.999
Deselect 100k rows ms 89.9 205.6 198.1 160.82 41.639

Generated by 🚫 dangerJS against 7707e83

@cherniavskii cherniavskii merged commit 4203151 into mui:master Jun 30, 2022
@cherniavskii cherniavskii deleted the add-mentions-of-premium-plan branch June 30, 2022 11:29
joserodolfofreitas pushed a commit to joserodolfofreitas/mui-x that referenced this pull request Jul 15, 2022
…ui#5328)

* mention DataGridPremium in error messages

* mention Premium plan in docs warnings
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
…ui#5328)

* mention DataGridPremium in error messages

* mention Premium plan in docs warnings
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants