-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[docs] Improve getting-started page #5293
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Improve getting-started page #5293
Conversation
These are the results for the performance tests:
|
Nice! I like the interactive proposal on defining what to install It touches a pain I felt yesterday. Perhaps we can consider updating the other installation pages as well (Not on this PR). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
A lot better than today !
The layout is a bit broken on mobile. |
Are we sure? I understood the issue as the user doesn't want to use moment. It also seems to about the lack of a live demo, e.g. with the Chinese calandar like in https://ant.design/components/date-picker-cn/ |
From the answer, I assume that adding explanations in the doc fix the pain of the user
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
We will be able to improve it later based on feedback, but it's already 100x better than the existing
@alexfauquette, thank you so much. I read the improved docs and now I can understand the architecture of date-time handling in MUI. Still, a couple of demos would be great. But this is good enough. Now everything is clear and thank you so much for this clarification. |
@alexfauquette OK great. @Nefcanto 👍 it could make sense to open a new GitHub issue about having a Chinese calendar demo. If we want to attract this audience, it would be a good opportunity to communicate them that we give it value, and to more easily test that it works as expected. |
@oliviertassinari it would be awesome. But I'm not from China. I'm from Iran. However, I would gladly help. I can create the issue, but in English. And I would test them in my own applications. Please let me know if I should open the issue or not. |
Fix #5290
main modifications:
before: https://mui.com/x/react-date-pickers/getting-started/
after: https://deploy-preview-5293--material-ui-x.netlify.app/x/react-date-pickers/getting-started/