-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[docs] Improve main demo to show new functionalities #5292
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[docs] Improve main demo to show new functionalities #5292
Conversation
These are the results for the performance tests:
|
Looking at the page makes me think of a quick win that we could marge as a different PR: the ad adds vertical space, which push the demo further below the top of the fold. Since this page is about optimizing for adoption, showing the ad also sounds counter productive. So +1 to disable it. |
As a general note, for this demo, I think that could be great is to have it "as bloated as" possible, meaning something that we could use during a sales call to show all the features and how they all integrate well together. In the rest of the docs, the demos tend to be very focused but a big part of the value is in solving the complexity of all the features working together. Now, we won't be able to demo everything, so I think that we could default to a focus on data analytics, how developers can group, pivot, and extract information from a large data set, keeping them inside the app, longer, without having to use Tableau+ or Excel. Now, having said this, maybe one demo won't be enough, so maybe we would need to demo real-world classes of use cases (instead of being feature centered):
|
I agree. The initial work I did with the demo was focused on data analytics with real APIs. |
Yes |
I like this demo, +1 for pushing it forward! |
6c2467a
to
9762dac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just few minor suggestions to the code.
Well done, demo looks great!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm leaning in the direction of #5292 (comment). The purpose of the main demo was to be equivalent to https://ag-grid.com/example/. Now we only have https://deploy-preview-5292--material-ui-x.netlify.app/x/react-data-grid/#commercial-version to experiment with the Pro version with a big dataset, but without an option to enable pagination.
What do you think of replacing https://deploy-preview-5292--material-ui-x.netlify.app/x/react-data-grid/#features with the demo you created, then keep the main demo as it is and we improve it later?
@m4theushw, I think that's a good idea! In the medium/long term, my proposal for the demo effort is:
|
19fc3e4
to
e6803f7
Compare
ec4b762
to
c80fac6
Compare
02d1d9a
to
d922823
Compare
e1c9707
to
5a7e315
Compare
@@ -6,7 +6,7 @@ title: Data Grid - Demo | |||
|
|||
<p class="description">Use the demo below to explore the available features.</p> | |||
|
|||
{{"demo": "FullFeaturedDemo.js", "defaultCodeOpen": false, "bg": "inline"}} |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I am also in favor of removing FullFeaturedDemo
and create one more fine-tuned for row virtualization
Can be done in a follow up
@joserodolfofreitas "at first to signalize its usage on the demo" it took me a while to figure this out, having master detail first didn't help me figure this out. I would recommend that a row click expands the detail. I think that the expand icon is too easy to miss. Regarding why I proposed "A default sorting per plan" with the community first: I think it's because most developers won't jump straight to use the Pro & Premium features. I think that it's more effective to have them first adopt the MIT features. Once they need the Pro & Premium feature, their first attempt will be to try our grid, rather than a competitor with whom they have to rebuild all the product knowledge. |
Summary
A new data grid demo uses the data grid master detail to showcase a list of the most popular features.
Motivation
What's coming next?
Build real use case demos.
Consider a special page for the /x/react-data-grid/demo/ to accommodate the demos.
Consider to replace the list /x/react-data-grid/#features with the demo on this PR.
Preview
https://deploy-preview-5292--material-ui-x.netlify.app/x/react-data-grid/demo/