-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[docs] New page for the action bar customization #5267
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
These are the results for the performance tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
What about using StatikDatePicker
instead of StatikDateTimePicker
for the demonstrations such that we can focus on the action bar without being distracted by the view switching between calender/clock?
About the second demo, the code is maybe over complicated. What about a CustomActionBar
that displays a cancel/validate buttons made with <IconButton />
Instead of the too long switch
could be something like
{actions.includes('cancel') && <CancelButton onClick={onCancel} />}
Such that you define the UI code (CancelButton
and ValidateButton
) on top, and CustomActionBar
only contains the interesting parts for the doc:
- dev has access to
actions
prop - dev has access to
onCancel
, ... (maybe the list of methods available should be listed)
Done
That's a recurrent topic |
This is something I've been thinking about as well (mui/material-ui#33156 (comment)) as I'm polishing up the Base docs. For those pages, I think I'm going to document the usage of |
I just remembered we have this Usage page in the Base docs that explains how these props work! Another page to be considered for a "universal" MUI docs section. |
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
Add a doc page to explain how to override components on the pickers, with a 1st detailed example for
ActionBar
The
Overriding components
section is mainly a copy paste of the grid doc.Maybe it would be nice to have a well written page shared by all our components (core and X) explaining the
components
andcomponentsProps
instead.Doc preview