-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[DateRangePicker] Fix keyboard selection #5265
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
These are the results for the performance tests:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Looks like a good bug fix.
Probably the bug caused by the remaining debts mentioned here:
Implement with controlled vs uncontrolled
rawValue
Could not reproduce the bug in the deployed Netlify link.
Edit:
Now noticed there is a failed check in the Checks
tab, and this PR is a draft ATM 😕.
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
We just started running into this. I see it's happening on the demo page in the docs, too. https://mui.com/x/react-date-pickers/date-range-picker/#basic-usage Are there any good workarounds that affected folks can use in the meantime? |
@subvertallchris Except staying at alpha-5 I do not see a workaround |
We are running into the same issue too. The fix in CSB is working perfectly. Is there any plan to roll out the fix in the next release? |
Will be in the next release |
Fix #5231
Fix #5284
I remove the
skip
on the date range picker keyboard setting. But it does not catch the bug of the key pressed ignored, so I added another oneI ensured that the input value is reset only when the
rawValue
is modified by looking at howuseAutocomplete
works