Skip to content

[DateRangePicker] Fix keyboard selection #5265

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 5 commits into from
Jun 29, 2022

Conversation

alexfauquette
Copy link
Member

@alexfauquette alexfauquette commented Jun 20, 2022

Fix #5231
Fix #5284

I remove the skip on the date range picker keyboard setting. But it does not catch the bug of the key pressed ignored, so I added another one

I ensured that the input value is reset only when the rawValue is modified by looking at how useAutocomplete works

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
@alexfauquette alexfauquette added the bug 🐛 Something doesn't work label Jun 20, 2022
@mui-bot
Copy link

mui-bot commented Jun 20, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 240.8 464.9 394.3 350.82 86.237
Sort 100k rows ms 502.7 805.9 711.9 681.5 112.649
Select 100k rows ms 135.9 208.4 161.5 163.14 25.865
Deselect 100k rows ms 110.5 285.9 162.2 184.58 61.76

Generated by 🚫 dangerJS against fece62c

Copy link

@N1mi1 N1mi1 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks like a good bug fix.
Probably the bug caused by the remaining debts mentioned here:

Implement with controlled vs uncontrolled rawValue

Could not reproduce the bug in the deployed Netlify link.

Edit:
Now noticed there is a failed check in the Checks tab, and this PR is a draft ATM 😕.

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
@alexfauquette alexfauquette marked this pull request as ready for review June 22, 2022 09:56
@alexfauquette alexfauquette self-assigned this Jun 22, 2022
@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 22, 2022
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 23, 2022
@subvertallchris
Copy link
Contributor

subvertallchris commented Jun 23, 2022

We just started running into this. I see it's happening on the demo page in the docs, too. https://mui.com/x/react-date-pickers/date-range-picker/#basic-usage

Are there any good workarounds that affected folks can use in the meantime?

@alexfauquette
Copy link
Member Author

alexfauquette commented Jun 23, 2022

@subvertallchris Except staying at alpha-5 I do not see a workaround

@flaviendelangle

@JonathanGuo
Copy link

We are running into the same issue too. The fix in CSB is working perfectly. Is there any plan to roll out the fix in the next release?

@alexfauquette
Copy link
Member Author

Will be in the next release

@alexfauquette alexfauquette merged commit 6029595 into mui:master Jun 29, 2022
@alexfauquette alexfauquette deleted the date-picker-bug branch June 29, 2022 14:42
joserodolfofreitas pushed a commit to joserodolfofreitas/mui-x that referenced this pull request Jul 15, 2022
alexfauquette added a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 Something doesn't work
Projects
None yet
6 participants