-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[pickers] Pass the generics to the components in the theme augmentation #5199
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[pickers] Pass the generics to the components in the theme augmentation #5199
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Make total sense
Thanks for your contribution !
…y-of-base-theme-to-the-components-theme-augmentation
Should we do the same for the data grid?
|
@cherniavskii yeah probably |
I'm unfamiliar with the data grid component, but I'll work on it this weekend. Should I create a new PR or add to this one? Btw guys, what should I do to merge this PR? |
@toruticas the CI seems to have a problem, could you rebase on the master branch to see if the CI is passing ? |
…se-theme-to-the-components-theme-augmentation
to trigger the CI
These are the results for the performance tests:
|
This pull request drills the base theme by using the generic of ComponentsOverrides.
Motivation:
When overriding global themes, I want to use the override values of the palette, but once the type definition of date picker components doesn't pass by the base theme, the theme will always be considered unknown.
I've also created an example of this issue with code sandbox: https://codesandbox.io/s/elated-violet-1u5qvc?file=/src/App.tsx