Skip to content

[docs] Explain how to use hooks inside a cell renderer #5158

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 7 commits into from
Jul 5, 2022
Merged

[docs] Explain how to use hooks inside a cell renderer #5158

merged 7 commits into from
Jul 5, 2022
+49 −0

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Jun 9, 2022 •
edited
Loading

Closes #4937
Closes #4815

@flaviendelangle flaviendelangle added docs Improvements or additions to the documentation component: data grid This is the name of the generic UI component, not the React module! labels Jun 9, 2022
@flaviendelangle flaviendelangle self-assigned this Jun 9, 2022
@mui-bot
Copy link

mui-bot commented Jun 9, 2022 •
edited
Loading

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 253.4 669.2 364.9 388.4 147.022
Sort 100k rows ms 528.3 1,033.7 631.3 752.72 195.946
Select 100k rows ms 138.9 200.3 175.2 172.02 20.393
Deselect 100k rows ms 127.4 231 142.8 167 39.858

Generated by 🚫 dangerJS against 9034723

alexfauquette
alexfauquette approved these changes Jun 21, 2022
View reviewed changes
Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It sounds good as it is

If you add the warning, it would maybe solve the #4815

@flaviendelangle
Merge branch 'master' into renderCell-hook

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
f8d17d0
@flaviendelangle
Code review: Alex

Partially verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
We cannot verify signatures from co-authors, and some of the co-authors attributed to this commit require their commits to be signed.
5319b5e
joserodolfofreitas
joserodolfofreitas approved these changes Jun 23, 2022
View reviewed changes
Copy link
Member

@joserodolfofreitas joserodolfofreitas left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.
Leaving just a minor suggestion.

flaviendelangle and others added 2 commits June 23, 2022 10:01
@flaviendelangle @joserodolfofreitas
Update docs/data/data-grid/column-definition/column-definition.md
80346d0 
Co-authored-by: José Rodolfo Freitas <joserodolfo.freitas@gmail.com>
@flaviendelangle @mapache-salvaje
Update docs/data/data-grid/column-definition/column-definition.md
14e3e92 
Co-authored-by: Sam Sycamore <71297412+samuelsycamore@users.noreply.github.com>
@flaviendelangle
Work
08d5969
@flaviendelangle
Merge remote-tracking branch 'origin/renderCell-hook' into renderCell…

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
GPG key ID: 4AEE18F83AFDEB23
Expired
Verified
Learn about vigilant mode
9034723 
…-hook
@alexfauquette alexfauquette mentioned this pull request Jul 4, 2022
Closed
@flaviendelangle flaviendelangle merged commit edb2135 into mui:master Jul 5, 2022
@flaviendelangle flaviendelangle deleted the renderCell-hook branch July 5, 2022 08:02
@flaviendelangle flaviendelangle mentioned this pull request Jul 5, 2022
Closed
2 tasks
cherniavskii pushed a commit to cherniavskii/mui-x that referenced this pull request Jul 6, 2022
@flaviendelangle @cherniavskii
[docs] Explain how to use hooks inside a cell renderer (mui#5158)
cc24800
joserodolfofreitas pushed a commit to joserodolfofreitas/mui-x that referenced this pull request Jul 15, 2022
@flaviendelangle @joserodolfofreitas
[docs] Explain how to use hooks inside a cell renderer (mui#5158)
be62e78
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
@flaviendelangle @alexfauquette
[docs] Explain how to use hooks inside a cell renderer (mui#5158)

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
73a00d2
@oliviertassinari
Copy link
Member

Interesting footgun here 😅. I referenced this problem in mui/base-ui#157 discussion.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joserodolfofreitas joserodolfofreitas

@alexfauquette alexfauquette

@mapache-salvaje mapache-salvaje

Assignees

@flaviendelangle flaviendelangle

Labels
component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Milestone
No milestone
6 participants
@flaviendelangle @mui-bot @oliviertassinari @joserodolfofreitas @alexfauquette @mapache-salvaje