Skip to content

[test] Fix dynamic row height test failing on Chrome #5147

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Jun 8, 2022
Merged

[test] Fix dynamic row height test failing on Chrome #5147

merged 1 commit into from
Jun 8, 2022
+25 −22

Conversation

m4theushw
Copy link
Member

Closes #5095

@mui-bot
Copy link

mui-bot commented Jun 8, 2022 •
edited
Loading

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 304 588.3 485.6 445.34 116.122
Sort 100k rows ms 581 1,141 1,141 914.28 204.607
Select 100k rows ms 148.6 226 209.4 200.24 27.036
Deselect 100k rows ms 145.3 288.9 153.1 192.96 57.771

Generated by 🚫 dangerJS against 44bdd86

@m4theushw
[test] Fix dynamic row height test failing on Chrome

Unverified

This user has not yet uploaded their public signing key.
GPG key ID: FCCF9CBCD3E32D81
Learn about vigilant mode
44bdd86
@m4theushw m4theushw marked this pull request as ready for review June 8, 2022 18:47
@m4theushw m4theushw added the test label Jun 8, 2022
@m4theushw m4theushw merged commit a48912a into mui:master Jun 8, 2022
@m4theushw m4theushw deleted the fix-karma-test branch June 8, 2022 19:09
joserodolfofreitas pushed a commit to joserodolfofreitas/mui-x that referenced this pull request Jun 13, 2022
@m4theushw @joserodolfofreitas
[test] Fix dynamic row height test failing on Chrome (mui#5147)
dd38d8f
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
@m4theushw @alexfauquette
[test] Fix dynamic row height test failing on Chrome (mui#5147)

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Learn about vigilant mode
758c6f8
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
test
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

[test] Flaky dynamic row test on master
2 participants
@m4theushw @mui-bot