Skip to content

[docs] Improve movie dataset #5142

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 2 commits into from
Jun 8, 2022

Conversation

flaviendelangle
Copy link
Member

@flaviendelangle flaviendelangle commented Jun 8, 2022

I added some movies to have more interesting results for the aggregation.

I will probably spend some time trying to generate a similar dataset automatically to go up to 500 movies.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@flaviendelangle flaviendelangle added the docs Improvements or additions to the documentation label Jun 8, 2022
@flaviendelangle flaviendelangle self-assigned this Jun 8, 2022
Fix

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@mui-bot
Copy link

mui-bot commented Jun 8, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 245.3 509.2 354.1 354.32 100.988
Sort 100k rows ms 485.4 878.8 721.3 714.82 134.314
Select 100k rows ms 113.9 191.2 141.9 145.84 25.793
Deselect 100k rows ms 99.4 227.6 196.4 165.24 45.454

Generated by 🚫 dangerJS against bb9f7ef

Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

What do you want to do with imbdRating data?

@flaviendelangle
Copy link
Member Author

What do you want to do with imbdRating data?

In the aggregation it's the example for aggregation on a cell with a custom renderer (the Rating component).
I'll probably add it to regular grouping demo later, as it creates more good-looking grids with some color.

@flaviendelangle flaviendelangle merged commit 5907944 into mui:master Jun 8, 2022
@flaviendelangle flaviendelangle deleted the movies-update branch June 8, 2022 14:27
joserodolfofreitas pushed a commit to joserodolfofreitas/mui-x that referenced this pull request Jun 13, 2022

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants