Skip to content

[tests] Remove delay on server demo for regression tests #5131

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 8, 2022

Conversation

alexfauquette
Copy link
Member

Fix comment #4186 (comment)

I copied the logic from the value generator, but I don't know how to verify it solved the flaky test

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@alexfauquette alexfauquette self-assigned this Jun 7, 2022
@mui-bot
Copy link

mui-bot commented Jun 7, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 257 606.4 423.3 429.24 146.262
Sort 100k rows ms 439.2 1,070.8 744.8 806.2 220.708
Select 100k rows ms 142.3 286.9 191.7 204.76 48.129
Deselect 100k rows ms 105.5 214.4 150.4 159.5 39.524

Generated by 🚫 dangerJS against fb54c63

@alexfauquette
Copy link
Member Author

It seems that the CI answered my question: "How to verify it's working as expected?" 😂

image

@alexfauquette alexfauquette merged commit a281d19 into mui:master Jun 8, 2022
@alexfauquette alexfauquette deleted the fix-argos branch June 8, 2022 15:39
joserodolfofreitas pushed a commit to joserodolfofreitas/mui-x that referenced this pull request Jun 13, 2022

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
alexfauquette added a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants