[date picker] Fix shouldDisableDate in range pickers
#5123
Merged
+3
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
flaviendelangle
added
bug 🐛
flaviendelangle
commented
Jun 5, 2022
| @@ -229,6 +229,7 @@ function DateRangePickerViewRaw<TInputDate, TDate>( | |||
| disablePast, | |||
| minDate, | |||
| maxDate, | |||
| shouldDisableDate, | |||
There was a problem hiding this comment.
This part of the code is very error-prone, maybe we could improve it later
There was a problem hiding this comment.
Do you have an idea about how to improve it? I only see two ways:
- Use providers to avoid having to propagate the information, and forget them somewhere
- make tests that loop on all the exported components to check we do not break props propagation
There was a problem hiding this comment.
Do you have an idea about how to improve it? I only see two ways:
- Use providers to avoid having to propagate the information, and forget them somewhere
- make tests that loop on all the exported components to check we do not break props propagation
There was a problem hiding this comment.
I did not think about it in depth tbh
We could indeed have a conformance test taking a component, 2-3 callbacks to interact with the DOM and which tests all the validation props (it would at least be a subset of our problem)
|
These are the results for the performance tests:
|
flaviendelangle
changed the title
shouldDisableDate in range pickers
alexfauquette
approved these changes
Jun 7, 2022
joserodolfofreitas
pushed a commit
to joserodolfofreitas/mui-x
that referenced
this pull request
Jun 13, 2022
alexfauquette
pushed a commit
to alexfauquette/mui-x
that referenced
this pull request
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #5111