Skip to content

[docs] Fix 301 link to render cell #5106

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 3, 2022

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jun 3, 2022

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Jun 3, 2022
@mui-bot
Copy link

mui-bot commented Jun 3, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 260.3 478 322.9 339.04 77.679
Sort 100k rows ms 492.1 881.9 695 679.26 131.808
Select 100k rows ms 132.5 199.7 190 174.2 26.505
Deselect 100k rows ms 116.7 193.3 125.5 148.48 33.618

Generated by 🚫 dangerJS against 178072e

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@@ -47,7 +47,7 @@ The grid responds to keyboard interactions from the user and emits events when k

### Tab sequence

According to [WCAG](https://www.w3.org/TR/wai-aria-practices-1.1/#grid), only one of the focusable elements contained by the grid should be included in the page tab sequence.
According to [WAI-ARIA](https://www.w3.org/WAI/ARIA/apg/patterns/grid/), only one of the focusable elements contained by the grid should be included in the page tab sequence.
Copy link
Member Author

@oliviertassinari oliviertassinari Jun 3, 2022

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The link was broken (recent change in w3.org), and since we linked WAI-ARIA which is more specific than WCAG, I have also updated the mention. See https://stereobooster.com/posts/what-are-wcag-and-wai-aria/ on the difference.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Copy link
Member

@alexfauquette alexfauquette left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks for the clarification between WAI-ARIA and WCAG 👍

@alexfauquette alexfauquette merged commit 1c4e6e8 into mui:master Jun 3, 2022
@oliviertassinari oliviertassinari deleted the fix-301 branch June 3, 2022 16:21
@oliviertassinari oliviertassinari added the component: data grid This is the name of the generic UI component, not the React module! label Jun 3, 2022
joserodolfofreitas pushed a commit to joserodolfofreitas/mui-x that referenced this pull request Jun 13, 2022

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: data grid This is the name of the generic UI component, not the React module! docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants