Skip to content

[core] Upgrade monorepo #5101

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 3 commits into from
Jun 6, 2022

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented Jun 3, 2022

Try mui/material-ui#32939 out.

An example of a problem this solves: search for "column definition" in Algolia: you will get a duplicate result:

Screenshot 2022-06-04 at 00 50 27

one with the leading slash, the other without, proof: https://www.algolia.com/apps/TZGZ85B9TB/explorer/browse/material-ui?query=column%20definition&searchMode=search 🙃.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@oliviertassinari oliviertassinari added the core Infrastructure work going on behind the scenes label Jun 3, 2022
@mui-bot
Copy link

mui-bot commented Jun 3, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 270.7 501.7 385.8 382.28 75.631
Sort 100k rows ms 493.8 1,105.8 493.8 896.6 221.537
Select 100k rows ms 138.6 259.8 188.4 188.82 44.466
Deselect 100k rows ms 126.1 222.2 149.9 168.06 38.648

Generated by 🚫 dangerJS against 824208f

@oliviertassinari
Copy link
Member Author

oliviertassinari commented Jun 3, 2022

Niiice, it works:

12:42:18 PM: Error: Missing trailing slash. The following link:
12:42:18 PM: <GridFilterPanel /> in /docs/data/data-grid/filtering/filtering.md is missing a trailing slash, please add it.

It's especially helpful for MUI X because of https://answers.netlify.com/t/no-trailing-slash-when-using-proxies/48790/18

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@oliviertassinari oliviertassinari added the dependencies Update of dependencies label Jun 3, 2022

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@oliviertassinari oliviertassinari added the docs Improvements or additions to the documentation label Jun 5, 2022
@flaviendelangle flaviendelangle merged commit 5afd2b3 into mui:master Jun 6, 2022
@oliviertassinari oliviertassinari deleted the upgrade-mono-repo branch June 6, 2022 12:50
joserodolfofreitas pushed a commit to joserodolfofreitas/mui-x that referenced this pull request Jun 13, 2022
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes dependencies Update of dependencies docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants