Skip to content

[docs] Small grammar and format fixes for Dynamic row height section #5098

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 1 commit into from
Jun 6, 2022
Merged

[docs] Small grammar and format fixes for Dynamic row height section #5098

merged 1 commit into from
Jun 6, 2022

Conversation

mapache-salvaje
Copy link
Contributor

I noticed a few small typos in this section on the new Dynamic row height feature, and wanted to quickly clean them up so we can put our best foot forward when promoting this on social media in the next few days. 😁 I'll return to this doc at a later date for a full grammar and style review.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@mapache-salvaje mapache-salvaje added the docs Improvements or additions to the documentation label Jun 2, 2022
@mapache-salvaje mapache-salvaje requested a review from m4theushw June 2, 2022 16:04
@mui-bot
Copy link

mui-bot commented Jun 2, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 261.5 597.5 402 390.38 121.309
Sort 100k rows ms 481.3 987.3 799.5 780.92 175.209
Select 100k rows ms 142.4 203.2 185 182.08 21.21
Deselect 100k rows ms 104.7 286.6 149.4 184.04 68.042

Generated by 🚫 dangerJS against 6c0774f

Copy link
Member

@m4theushw m4theushw left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Feel free to make suggestions.

@mapache-salvaje mapache-salvaje merged commit 4629138 into mui:master Jun 6, 2022
joserodolfofreitas pushed a commit to joserodolfofreitas/mui-x that referenced this pull request Jun 13, 2022

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
alexfauquette pushed a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants