Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs] Move all localization documentation in a unique page #5072

Merged
merged 6 commits into from
Jun 8, 2022

Conversation

alexfauquette
Copy link
Member

@alexfauquette alexfauquette commented Jun 1, 2022

Fix #4915

There is a localization chapter in two pages: date picker and time picker.

Having two examples is not a code duplication. They cover specific edge cases:

  • date picker: needs the have a mask adapted to the local to switch between countries using yyyy/mm/dd, dd/mm/yyyy, and dd.mm.yyyy
  • time picker: needs a paragraph about ampm management

I group the two examples in a single page. And since we had a lot of feedback about ampm being by default true or false I added a demo in which the dev can test how the component behaves for some locale engine.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@mui-bot
Copy link

mui-bot commented Jun 1, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 278.2 521 388.2 400.24 99.83
Sort 100k rows ms 464.1 875.8 772.6 706.96 141.593
Select 100k rows ms 159.9 251.6 187.2 192.98 34.029
Deselect 100k rows ms 106.2 285.7 134.4 157.4 65.791

Generated by 🚫 dangerJS against 23b8217

@alexfauquette alexfauquette added docs Improvements or additions to the documentation l10n localization labels Jun 1, 2022

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@alexfauquette alexfauquette marked this pull request as ready for review June 3, 2022 07:41
@github-actions
Copy link

github-actions bot commented Jun 8, 2022

This pull request has conflicts, please resolve those before we can evaluate the pull request.

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 8, 2022
Copy link
Member

@flaviendelangle flaviendelangle left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

The section is very clear, well done !

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label Jun 8, 2022
CI

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@alexfauquette alexfauquette merged commit a9dffd8 into mui:master Jun 8, 2022
@alexfauquette alexfauquette deleted the localization-page branch June 8, 2022 16:03
joserodolfofreitas pushed a commit to joserodolfofreitas/mui-x that referenced this pull request Jun 13, 2022

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
alexfauquette added a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation l10n localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[docs] Type pickers demo
3 participants