[docs] Section for overwriting core components i18n keys #4998
Conversation
|
These are the results for the performance tests:
|
| @@ -17,6 +17,22 @@ In the following example, the labels of the density selector are customized. | |||
|
|
|||
| {{"demo": "CustomLocaleTextGrid.js", "bg": "inline"}} | |||
|
|
|||
| > ⚠️ It's important to note that because the data grid uses components from the Material UI Core library some translation keys need to be accessed using that component key. | |||
There was a problem hiding this comment.
I'm not aware we ever reference it this way
| > ⚠️ It's important to note that because the data grid uses components from the Material UI Core library some translation keys need to be accessed using that component key. | |
| > ⚠️ It's important to note that because the data grid uses components from the Material UI library some translation keys need to be accessed using that component key. |
There was a problem hiding this comment.
Also, I think that we should use specialized callouts mui/material-ui#32402.
@siriwatknp did we ever announce the change to the other teams? I believe we didn't, maybe we should?
There was a problem hiding this comment.
Yes I need to do a PR to replace all our notes to the new callouts synthax.
There was a problem hiding this comment.
So the correct one we should use is :::info?
There was a problem hiding this comment.
I'm not aware we ever reference it this way
We never explicitly said it. I think the initial assumption was that people will use the theme to overwrite those texts but if you want to use the localeText only then this is the way.
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
Co-authored-by: Olivier Tassinari <olivier.tassinari@gmail.com>
…nested-components
…ilH/material-ui-x into fix/docs-i18n-for-nested-components
…nested-components
Co-authored-by: Matheus Wichman <matheushw@outlook.com>
Part of #4323
Reference: #4323 (comment)
Preview: https://deploy-preview-4998--material-ui-x.netlify.app/x/react-data-grid/localization/#translation-keys
The goal is to add a section that explains that since the grid uses MUI Core components some translation keys need to be accessed through the MUI Core component.