Skip to content

[l10n] Use localText for remaining texts #4986

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 8 commits into from
Jun 1, 2022

Conversation

alexfauquette
Copy link
Member

@alexfauquette alexfauquette commented May 24, 2022

Translation from the prop naming to localeText keys

deprecated prop localeText key
getViewSwitchingButtonText calendarViewSwitchingButtonAriaLabel
getClockLabelText clockLabelText
getHoursClockNumberText hoursClockNumberText
getMinutesClockNumberText minutesClockNumberText
getSecondsClockNumberText secondsClockNumberText
getOpenDialogAriaText openDatePickerDialogue
getOpenDialogAriaText openTimePickerDialogue
new timeTableLabel
new dateTableLabel

This PR has dedicated commits for scripts yarn proptypes & yarn docs:api which modify lots of files to add the deprecated props

@alexfauquette alexfauquette added l10n localization component: pickers This is the name of the generic UI component, not the React module! labels May 24, 2022
@mui-bot
Copy link

mui-bot commented May 24, 2022

These are the results for the performance tests:

Test case Unit Min Max Median Mean σ
Filter 100k rows ms 231.4 459.9 374.8 341.04 89.607
Sort 100k rows ms 468.4 1,080.5 511.4 717.26 219.291
Select 100k rows ms 92 189.4 180.8 149.1 39.884
Deselect 100k rows ms 106.1 277.3 124.4 159.34 63.572

Generated by 🚫 dangerJS against 2ff2afb

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@alexfauquette alexfauquette marked this pull request as ready for review May 24, 2022 12:09
@flaviendelangle
Copy link
Member

Nice one !

When do we intend to drop the deprecated props ?

@alexfauquette
Copy link
Member Author

What about during summer? It lets a month for users to move, and add some translations files

@github-actions github-actions bot added the PR: out-of-date The pull request has merge conflicts and can't be merged label May 25, 2022
@github-actions
Copy link

This pull request has conflicts, please resolve those before we can evaluate the pull request.

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@github-actions github-actions bot removed the PR: out-of-date The pull request has merge conflicts and can't be merged label May 30, 2022

Unverified

This commit is not signed, but one or more authors requires that any commit attributed to them is signed.
@alexfauquette alexfauquette changed the title [l10n] use localText for remaining texts [l10n] Use localText for remaining texts Jun 1, 2022
@alexfauquette alexfauquette merged commit 7e7543d into mui:master Jun 1, 2022
@alexfauquette alexfauquette deleted the l10n-folloup branch June 1, 2022 08:47
alexfauquette added a commit to alexfauquette/mui-x that referenced this pull request Aug 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
component: pickers This is the name of the generic UI component, not the React module! l10n localization
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants