-
-
Notifications
You must be signed in to change notification settings - Fork 1.4k
[l10n] Use localText
for remaining texts
#4986
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Merged
Merged
+226
−89
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
These are the results for the performance tests:
|
9724a6e
to
c3d71b2
Compare
Nice one ! When do we intend to drop the deprecated props ? |
What about during summer? It lets a month for users to move, and add some translations files |
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
flaviendelangle
approved these changes
Jun 1, 2022
localText
for remaining texts
alexfauquette
added a commit
to alexfauquette/mui-x
that referenced
this pull request
Aug 26, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
component: pickers
This is the name of the generic UI component, not the React module!
l10n
localization
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Translation from the prop naming to localeText keys
getViewSwitchingButtonText
calendarViewSwitchingButtonAriaLabel
getClockLabelText
clockLabelText
getHoursClockNumberText
hoursClockNumberText
getMinutesClockNumberText
minutesClockNumberText
getSecondsClockNumberText
secondsClockNumberText
getOpenDialogAriaText
openDatePickerDialogue
getOpenDialogAriaText
openTimePickerDialogue
new
timeTableLabel
new
dateTableLabel
This PR has dedicated commits for scripts
yarn proptypes & yarn docs:api
which modify lots of files to add the deprecated props