[DataGrid] Add reason to onFilterModelChange
#4938
Merged
+198
−41
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
These are the results for the performance tests:
|
m4theushw
commented
May 19, 2022
| /** | ||
| * Additional details passed to the callbacks | ||
| */ | ||
| export interface GridCallbackDetails { | ||
| export interface GridCallbackDetails<K extends keyof GridControlledStateReasonLookup = any> { |
There was a problem hiding this comment.
Once apiRef.current.unstable_updateControlState stops being only a wrapper for setState we can replace the any with the correct types. The any is necessary because we don't know which key of the state was changed to match with GridControlledStateReasonLookup.
m4theushw
added
component: data grid
cherniavskii
approved these changes
May 20, 2022
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
github-actions
bot
added
the
PR: out-of-date
github-actions
bot
added
PR: out-of-date
|
This pull request has conflicts, please resolve those before we can evaluate the pull request. |
cherniavskii
approved these changes
Jun 2, 2022
github-actions
bot
removed
the
PR: out-of-date
joserodolfofreitas
pushed a commit
to joserodolfofreitas/mui-x
that referenced
this pull request
Jun 13, 2022
alexfauquette
pushed a commit
to alexfauquette/mui-x
that referenced
this pull request
Aug 26, 2022
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #1803
Always when someone asks how to know why a specific model has changed, we suggest to pass a
reasonargument. We had a few moments where this suggestion was brought: #3516 (comment), #4160 (comment), #1803 (comment), #1141 (comment). This PR implements the foundation to pass areasonparam to the callback props and the events published by the controllable states. To give a concrete example, I added it toonFilterModelChangebut the other states will also receive it in follow-up PRs.The high number of files changed is because I renamed the method below. The "update" word didn't make sense where it was being used, but I needed it for the new
unstable_updateControlState.From now on, to update a sub-state that is controlled (e.g. filtering) we need to use
unstable_updateControlStateinstead ofsetState. This new method has the reason argument and correctly types the options available. In the future,setStatewill be used only for non-controlled states.