Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[docs-infra] Fix lighthouse img size issue #37415

Merged
merged 1 commit into from
Jun 9, 2023

Conversation

oliviertassinari
Copy link
Member

@oliviertassinari oliviertassinari commented May 27, 2023

I saw this on an MUI X page first, while it has no effect in our case, it removes a distraction in the report so that we can more effectively spot meaningfully suggestions

Screenshot 2023-05-28 at 00 28 29

Before: https://pagespeed.web.dev/analysis/https-mui-com-material-ui-react-button/5duvvlroxl?form_factor=desktop
After: https://pagespeed.web.dev/analysis/https-deploy-preview-37415--material-ui-netlify-app-material-ui-react-button/ax4r51tou3?form_factor=desktop

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
@oliviertassinari oliviertassinari added docs Improvements or additions to the documentation performance scope: docs-infra Specific to the docs-infra product labels May 27, 2023
@oliviertassinari oliviertassinari changed the title [docs] Fix lighthouse img size issue [docs-infra] Fix lighthouse img size issue May 27, 2023
@mui-bot
Copy link

mui-bot commented May 27, 2023

Netlify deploy preview

https://deploy-preview-37415--material-ui.netlify.app/

Bundle size report

No bundle size changes

Generated by 🚫 dangerJS against f22116c

@zannager zannager requested a review from siriwatknp May 29, 2023 08:43
@oliviertassinari oliviertassinari merged commit e0516aa into mui:master Jun 9, 2023
@oliviertassinari oliviertassinari deleted the fix-lighthouse-issue branch June 9, 2023 09:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
docs Improvements or additions to the documentation performance scope: docs-infra Specific to the docs-infra product
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants