Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[core] Replace MUI Base with Base UI #36716

Merged
merged 4 commits into from
Apr 6, 2023

Conversation

mnajdova
Copy link
Member

@mnajdova mnajdova commented Mar 31, 2023

Sorry, something went wrong.

@mnajdova mnajdova added docs Improvements or additions to the documentation core Infrastructure work going on behind the scenes package: base-ui Specific to @mui/base labels Mar 31, 2023
@mnajdova mnajdova marked this pull request as ready for review March 31, 2023 12:12
@mnajdova mnajdova requested a review from michaldudak March 31, 2023 12:12
@@ -11,7 +11,7 @@

- [_Joy UI_](https://mui.com/joy-ui/getting-started/overview/) is a beautifully designed library of React UI components.

- [_MUI Base_](https://mui.com/base/getting-started/overview/) is our library of "unstyled" components and low-level hooks. With Base, you gain complete control over your app's CSS and accessibility features.
- [_Base UI_](https://mui.com/base/getting-started/overview/) is our library of "unstyled" components and low-level hooks. With Base, you gain complete control over your app's CSS and accessibility features.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Should we also create a redirect to mui.com/base-ui?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Happy to do it, but maybe we should do it separately to make the review easier. It would change https://mui.com/base -> https://mui.com/base-ui which is not the scope of this PR.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good call on both counts!

@@ -26,7 +26,7 @@ Try importing an [Unstyled Input](/base/react-input/) component and adding it to

## Responsive meta tag

MUI Base is a _mobile-first_ component library—we write code for mobile devices first, and then scale up the components as necessary using CSS media queries.
Base UI is a _mobile-first_ component library—we write code for mobile devices first, and then scale up the components as necessary using CSS media queries.
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Whoa, I wasn't even aware we have this in the docs - that's not exactly true, as Base UI does not depend on any screen size. I'll create another small PR to correct it.

Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I believe this was copypasta from the Material UI docs!

…ailwind-css-pt.md

Signed-off-by: Marija Najdova <mnajdova@gmail.com>
@mnajdova
Copy link
Member Author

mnajdova commented Apr 4, 2023

I will update the branch once again and request a review before we can merge. The next PR will be for the structure of the links - we can release both functionalities in the next release.

@mnajdova mnajdova requested a review from michaldudak April 4, 2023 10:43
@mnajdova mnajdova merged commit 9f5ae34 into mui:master Apr 6, 2023
hbjORbj pushed a commit to hbjORbj/material-ui that referenced this pull request Apr 9, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
core Infrastructure work going on behind the scenes docs Improvements or additions to the documentation package: base-ui Specific to @mui/base
Projects
Status: Recently completed
Development

Successfully merging this pull request may close these issues.

None yet

4 participants