-
-
Notifications
You must be signed in to change notification settings - Fork 32.5k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[core] Replace MUI Base with Base UI #36716
Conversation
mnajdova
commented
Mar 31, 2023
•
edited
Loading
edited
- I have followed (at least) the PR section of the contributing guide.
@@ -11,7 +11,7 @@ | |||
|
|||
- [_Joy UI_](https://mui.com/joy-ui/getting-started/overview/) is a beautifully designed library of React UI components. | |||
|
|||
- [_MUI Base_](https://mui.com/base/getting-started/overview/) is our library of "unstyled" components and low-level hooks. With Base, you gain complete control over your app's CSS and accessibility features. | |||
- [_Base UI_](https://mui.com/base/getting-started/overview/) is our library of "unstyled" components and low-level hooks. With Base, you gain complete control over your app's CSS and accessibility features. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Should we also create a redirect to mui.com/base-ui?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Happy to do it, but maybe we should do it separately to make the review easier. It would change https://mui.com/base -> https://mui.com/base-ui which is not the scope of this PR.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good call on both counts!
@@ -26,7 +26,7 @@ Try importing an [Unstyled Input](/base/react-input/) component and adding it to | |||
|
|||
## Responsive meta tag | |||
|
|||
MUI Base is a _mobile-first_ component library—we write code for mobile devices first, and then scale up the components as necessary using CSS media queries. | |||
Base UI is a _mobile-first_ component library—we write code for mobile devices first, and then scale up the components as necessary using CSS media queries. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Whoa, I wasn't even aware we have this in the docs - that's not exactly true, as Base UI does not depend on any screen size. I'll create another small PR to correct it.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I believe this was copypasta from the Material UI docs!
docs/data/base/guides/working-with-tailwind-css/working-with-tailwind-css-pt.md
Outdated
Show resolved
Hide resolved
…ailwind-css-pt.md Signed-off-by: Marija Najdova <mnajdova@gmail.com>
I will update the branch once again and request a review before we can merge. The next PR will be for the structure of the links - we can release both functionalities in the next release. |